From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C34542CAD; Wed, 14 Jun 2023 07:51:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B872140DDB; Wed, 14 Jun 2023 07:51:48 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2104.outbound.protection.outlook.com [40.107.223.104]) by mails.dpdk.org (Postfix) with ESMTP id 4C60840A7D; Wed, 14 Jun 2023 07:51:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glCTlYHpPMKy8m7imJxsWpm/6VlLQm4ONBTbl7fKsOHYfRSQfgQv93zoN7HqZILz1c2Brzzsn9YSfy6bA8c6xpuki5ei7x5XzkHkXEeYrHnfMJ2+b3BTYhuV2rnJ+vD5Bta6CTFfHJ2SOOl7u1cQ7Gq1Iantm0+roYjxBYdX1oXRXgtZB6Vq0HlZzS8SqkAa6ua5GGgvwt7gwajDaq1zQNgZCJSvZD2xY9Nq20Loxz917RbmNdGMRNB+2bobjPAb3Z5b8w76F7xE0Ua7qvja3PA86eJyf1k9ldnz/m0ImdNW7DUVECEc1sittf3QfIMFIxzAf2BqVv2IU2PRhZ2NUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+bHQxsO0McDhZNjZYEOdiZQ4gruJONyDjqrGpi1Ta8=; b=jsacVFWz5AOriTtM8n+r8zMznLqH6180eEWUO5ru8hzYS8VPXdYrQuihv5dIaRg1O9BKlfxGupesNiLqDk6POVhaEgHSRHSINkX1a4n9eepSCGFihYD/79bl5qB0NQhnLiwjLHcBYoKkYRVE2iIDRSmtc6TmDisf4MIvLiDp5phHn3K5BlFimcJpweCm8oglC06dQkluic1MrEc5TWqJ/SgIXIrj/Xi90PR652TC+7Q6c0f9k3jiTz2OG+Z2SCVNfyoZB/Drb1lw/8fCzLBDxxF7hoct/bQySkYMMJpncWkpC6a2cL9wOL4KWF6X8ZfW/ABIfKUAWfqI2MDospYrjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+bHQxsO0McDhZNjZYEOdiZQ4gruJONyDjqrGpi1Ta8=; b=FYSt5VhLljOZTI/DIeHhqndGVYqQmQwlPLPkv2AT8ez2rt5+nrGPSWkWkRbwhuMPhPNvNOd1na9BP6yiz03jZuV7ekUlVaNV8HUtORxOXoPx5iiUTZcroZ4XQIysi789JxV3gMQysrd+cniBPnQPGrkvb+eeRK+O9yft2wS1kEk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW5PR13MB5928.namprd13.prod.outlook.com (2603:10b6:303:1ab::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.41; Wed, 14 Jun 2023 05:51:43 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.045; Wed, 14 Jun 2023 05:51:43 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Qin Ke , stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH] net/nfp: fix add redundant read configure operations Date: Wed, 14 Jun 2023 13:51:16 +0800 Message-Id: <20230614055116.784145-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0051.namprd05.prod.outlook.com (2603:10b6:a03:33f::26) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW5PR13MB5928:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f674b78-d72d-4b22-7ee0-08db6c9b6e32 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jzzRfgYr1upgZC5eFKzD1tfK3uzQIdXsOvUJBRn8ykhsQvCPvFz1F/gMoFgATjqEgog4mgrWhXy+88Lo/xfhU9GjeTLIwTMgB5C8YC5VIGbz+YkyyC/WP42itTY2HwBLTB3N9lLNG9I67Ylh7MMJpRhJl6HumZn/UVljL1k4Q3Zegfjr/NMlGd0f1k9+Y8j7ZUAW409/Wc/AtgFEg8EucoG9cdkzpS4pTDXno3jlhHqKvKLRT87Dq0G6qaOgbSXvvo5S2KWzjGCcJAvff8hG+4W8AbR00vfuJ2EXudI7H5gvqU+Jan7dNHbV4oFjwzOd+c8jGPjtkbEDctFsMgiXZu/OX18ILCktmXxkXr8DCsRwiIaLugzCgxc9IcQO7rZ2Zjj/EtAOE0LuTZTEOqG6eJu3dqEaP3cc+zvpB3LSU5v9x5L6MgPWSgiCUWt2Ysx23WKsDDZe5PdionOPIeeGD9TrwtZvGhsDgw9inby7yy6vUbMNcs/ENdvfN3x3HKQmU0ZSrRttL0Iwd1xbgR2vROGnt1OjhqjCjU3UdPYY0fqUM7HtQ7sMLFcUeWbr8QvdDObmRE2VKRNTntQD7Re6JW6cS3xDC4G6+KgjwFRGW4xxQq5IhKiZaLWSSJ49auI0VsuftcOzG1cLIh+bSbe2ITNhIuYWH0sm4XA22VB4H/A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39840400004)(376002)(136003)(366004)(396003)(346002)(451199021)(316002)(6486002)(52116002)(41300700001)(2616005)(86362001)(44832011)(6512007)(1076003)(83380400001)(26005)(6506007)(107886003)(2906002)(38100700002)(38350700002)(186003)(5660300002)(8676002)(8936002)(4326008)(66476007)(66556008)(66946007)(450100002)(478600001)(54906003)(36756003)(6916009)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0dHT3BRS1FYYVlyUnh3Q25BNnh0VW1ZRlZmSy9QZlVTRDk5b3hNeGhvZjJm?= =?utf-8?B?ZXZwOExrV3diZHg0QnNidU52Zll3N3hLSXNCMnlIRVJ4N29DQmVReVdyOUJ4?= =?utf-8?B?YVFMNkNubzlWWWZsc29GbVIyVUx2VDNLVXFCRTg2Kys3d0dwbjBYNEE1amRV?= =?utf-8?B?UGxrNnF6MS9RVC9JUTVVQ3JqaVRPWEVDWC9NV3ptZ0ZpME9JdEVGcE5PS2hk?= =?utf-8?B?dnA5d2FOZERSblhDUm1jQzlpYjJ2M3RuOFE2U3E5a01Va1dMU2lIcnp3NHFP?= =?utf-8?B?dTZKaVBQa1RLWm9rV252ejVSZ1JvRWdYa2h2THNaMDJwMXNVZlhjL0xwUEp0?= =?utf-8?B?T05xbklrMndDQnQxWnBkZzdoWXgrY2JJaVYwWmFzczB4NmhteXpCNHZqbnNY?= =?utf-8?B?TDEzM1U1dFJOOHRlQjBoT3VlSnBMSHAzcFc2M0ppL2Fobml1TlJ5ZnhrMmx4?= =?utf-8?B?UjdGeXdpR0pNYjd4bCtnczRlejhqRU43SysxeGgxMVRTZ29ZSE0rT0ZIOE1G?= =?utf-8?B?WVFOVzI1ODVPeHd6ZE5vMi8rU3FYMi94U0gzRlc2QzNNR2xJRGduallOMUdU?= =?utf-8?B?QTl1U0hJdEMyMG11TXpkZktZRTlWZlV1K0l5T0dObHZHTlltdjFBRGRyQXRq?= =?utf-8?B?N0pmWGNiVGZaM1hVSldMc3dUNGEwdmY4RmYvUVRwbFFwTThkeVpqZW5TOEsv?= =?utf-8?B?anBtZTdvNk1vajUxV25rQUtkVFRYcTZ3V0Q2b1p4a09SQnFUOFF6S1F0NEhv?= =?utf-8?B?ZUQ1SG9iT3pMYUdGVDVEVFBuUXZ2RmVyb2tPRDZOSGlXcEV2MEg5NHZlSWkr?= =?utf-8?B?bXJvN2NSLzlFR1QxbUhlRW9qMjZnN3Z3N0VDQlFOQ1dJZzd5YmNEYUFNTXNE?= =?utf-8?B?YlpBMHlIUFgrMGJEUCtIcUlxbHR1RWtraEFiRlVHL2ZZa3lkbmo3c250aXls?= =?utf-8?B?WHdER1UrRHJ2ZlJuL280d0lNT0RMTkVRUlNic21lYnBQekhuSVJVb0o2UlM2?= =?utf-8?B?Mk5OUmM0OGlpeWc5VDJITC9LMmRUd0FhMWhmeGdtRXFhTXRmQXpzVlVrY2sv?= =?utf-8?B?Nm9WVGVBaWFPdnBzRWIzSnE5Y0dkY2RJYTV6a3FiVnlOVHNlc2pRdFJ6R2t4?= =?utf-8?B?SHdkYlZZRWU5VWthUDNBWDZmZStyTm11WnhkZUxiNmpqZFdRWjFRbXVkM2p5?= =?utf-8?B?MVg4anNPLzFjY2xNbGQxRlorVkRPOC9oQjVqYitXSS9iUm1Zbi81ZGxYQXlh?= =?utf-8?B?VHQ3NHpNenpyTm9RYTIrcWU4Z0xsRkxqelpTRWpCQ0NEQmhnamd1dngwK2RF?= =?utf-8?B?bGFPeVdBQW5IemxmVllZcU5iQjh5L0ZSTGxkNW1lQ2llejJWbU51aTZGSU1m?= =?utf-8?B?WGNpUnA5MFBQamNlMWM1dXE0Z3ZocHVlTkV0SE5GNXFERkNvbkdUbE11UTRY?= =?utf-8?B?R0xQcys5QzVvVFJadkovNnZUYWRHQlZoTkFReGNUSTJaYld1cEw5NXlqci9Q?= =?utf-8?B?L3FjcG44NTFQcDdkVkhjYTBvS2xXYjljR1BndDBNVWw4NXkwb3cwVE1vZmpZ?= =?utf-8?B?UEQ4MHdPZkVNa3FPTWgzSkkrMFI2Ny9vbndINWpMVzlIZkU0aDNRRXZhK3Ez?= =?utf-8?B?bW1VYkszdGpTUVozQ3hOSE1lbC82R1poY0FuTTdzLzFydStIcXJiQzdFYU8r?= =?utf-8?B?VzQ2L0h4VjBQcFk0SndmT3ltTUdXTmlHaVFMTlMxSG1TZ0pPK3hMZENGMTFZ?= =?utf-8?B?eHc3U2x0eENtTWNRRVljN3lFbWNWbHIwUWozZ0xpUjNKaXJ5eGYybVhmcG9l?= =?utf-8?B?YllEbUxYMFY3S3FtVlY0OTBQTVZZQ09YcHdaOCtxV1NpdTVXV0RkNm5CT3Bz?= =?utf-8?B?TXd2K0pmaFpXS3VBZHgvTTRpZFkwRVZQTHNDUHZDTEFqcEdMalErOWhWc2hI?= =?utf-8?B?YnYwR3cwZDhnclVkYXRNWTFCOWEvZGN1WUxaRVkwUkorS1dEdFR2OThuK1Nm?= =?utf-8?B?Y1Rmc28wYUZURDQ0U0JKYmRFVEhpLy80VHpxQkc3NHcvQkRNTUI3Q2hTRkhj?= =?utf-8?B?S3J6dUJVRHJsVzhZMkRwSitOL1RhTmwycGZXbWpSaGxWdlJIYVhENElNRTVn?= =?utf-8?B?d2ZvUHFYejdkSHJ6ZnpSUllSOE9pd3ZpQldkZVovU2d4K3J5cThCRDlzL0JV?= =?utf-8?B?RUE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f674b78-d72d-4b22-7ee0-08db6c9b6e32 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 05:51:43.0510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PadvZeqV68J2laA7U2T8F1nd4j6LB3ON4dCCIQ5xokVZlX2kMhl7XV/WTbRqN2wphkFP7TcWg2hTRtWGir/TXxbzkV3CJenJuYPpAkplHAM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5928 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Qin Ke Performance is reduced because of adding redundant read configure operations in nfp_net_parse_ptype() called by nfp_net_recv_pkts(), which cause every received packet to spend more time. Fix the performance issue by deleting the redundant code directly. Fixes: 2e7c36128be ("net/nfp: report packet type by Rx descriptor") Cc: stable@dpdk.org Signed-off-by: Qin Ke Reviewed-by: Niklas Söderlund Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 9867db4388..297864450b 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -317,7 +317,8 @@ nfp_net_parse_meta(struct nfp_net_rx_desc *rxds, * Mbuf to set the packet type. */ static void -nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, struct rte_mbuf *mb) +nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, + struct rte_mbuf *mb) { uint32_t mbuf_ptype = RTE_PTYPE_L2_ETHER; uint8_t nfp_tunnel_ptype = nfp_ptype->tunnel_ptype; @@ -420,31 +421,19 @@ nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, struct rte_mbuf *mb) * * @param rxds * Rx descriptor including the offloading info of packet type. - * @param hw - * Device. * @param mb * Mbuf to set the packet type. */ static void nfp_net_parse_ptype(struct nfp_net_rx_desc *rxds, - struct nfp_net_hw *hw, struct rte_mbuf *mb) { - uint32_t cap_extend; - uint32_t ctrl_extend; struct nfp_ptype_parsed nfp_ptype; uint16_t rxd_ptype = rxds->rxd.offload_info; if (rxd_ptype == 0 || (rxds->rxd.flags & PCIE_DESC_RX_VLAN) != 0) return; - cap_extend = nn_cfg_readl(hw, NFP_NET_CFG_CAP_WORD1); - ctrl_extend = nn_cfg_readl(hw, NFP_NET_CFG_CTRL_WORD1); - - if ((cap_extend & NFP_NET_CFG_CTRL_PKT_TYPE) == 0 || - (ctrl_extend & NFP_NET_CFG_CTRL_PKT_TYPE) == 0) - return; - nfp_ptype.l4_ptype = (rxd_ptype & NFP_NET_PTYPE_L4_MASK) >> NFP_NET_PTYPE_L4_OFFSET; nfp_ptype.l3_ptype = (rxd_ptype & NFP_NET_PTYPE_L3_MASK) >> @@ -593,7 +582,7 @@ nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) struct nfp_meta_parsed meta = {}; nfp_net_parse_meta(rxds, rxq, hw, mb, &meta); - nfp_net_parse_ptype(rxds, hw, mb); + nfp_net_parse_ptype(rxds, mb); /* Checking the checksum flag */ nfp_net_rx_cksum(rxq, rxds, mb); -- 2.39.1