From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0816B42CB8; Wed, 14 Jun 2023 18:44:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D467340FDF; Wed, 14 Jun 2023 18:44:50 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 4C04140E0F for ; Wed, 14 Jun 2023 18:44:49 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b3d0b33dc2so22294455ad.0 for ; Wed, 14 Jun 2023 09:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686761088; x=1689353088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=leFda+GRPM2JmOdhOxi4Psq8x+HjoSuerZ9NTGJoG3M=; b=MA9Ho+rwQNl5/M99iZiocP33Po4QmLNFQ318j9Zmevjwi2qv0VGdHZu4evfOQniVWW NLf3phXqHUHyiuPMZCVSGSiQzZhuWxKkDT5haPHSUtBf0mCkmPXJAkk51OyzmZtZip7Z jWAJ1v6KQa49S7seoUpa/re2Q85/a89dm3jPdPlSgMQo0sd1o+Ir76Q4IDipGLBEFCjs BOQvuFPqNFSWMjHXVB3DavIqATnmSuVacN8f9PqgZaS1te175iyDGEgt9tg5iYuyaQS5 5K2dqWUtS2Rohht2MBoTJJxY8Ryrhg4xJYaVWDGCX5iGTPmWAvy+ecx/8XW8OF568rFw XGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686761088; x=1689353088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=leFda+GRPM2JmOdhOxi4Psq8x+HjoSuerZ9NTGJoG3M=; b=Nr37vMqEmmzCUWABkp2270Emf8zbE2juceh4KzGoCMsg9WLpya0gysgGjyk2m0sZK+ wnPxghYGcl2yKR3v1NccyQoWnuZK5ya9bZd26l4TCA5BzSPGfpnxVZ+NQ7Oh5M93Atpp 0dZTIhVCu6yZH7hlWb73gs5ZnSheASRDcwFIndruzVmlgRqUp1cMRJq8vH9GOOGtFN7T 5uMbc4g6nq6UVO03kkmEOgY97c1Nqu/p025yay3PxgQQsoYTcC6XFU4lr1Uo+rfX55En IljamvicgOe+gKIjpDJVY06YF9wYWmEHILZZeW9ACCH7wCSAqz6WT2eTeFqd9EgwmbNn a1fA== X-Gm-Message-State: AC+VfDwHs9QgsVDz04lqP1YvQ9eDNT23HlU0EextwxqOI/GgkXsI+ogG Y/jU/9trUIOrJYl0YYugO/sLWg== X-Google-Smtp-Source: ACHHUZ5LhDFhCmbPD5iMNRtlNlbVH30wByjaGEgBFBfhFecU2GW8X3wIrPL/xix82McWl5ApUn+xng== X-Received: by 2002:a17:902:a60a:b0:1b1:862b:cdbb with SMTP id u10-20020a170902a60a00b001b1862bcdbbmr10472830plq.20.1686761088157; Wed, 14 Jun 2023 09:44:48 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p6-20020a170902eac600b001b3d88d99bfsm1430802pld.157.2023.06.14.09.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 09:44:47 -0700 (PDT) Date: Wed, 14 Jun 2023 09:44:45 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko , Dengdui Huang Subject: Re: [PATCH] ethdev: rename functions checking queue validity Message-ID: <20230614094446.0e5d6047@hermes.local> In-Reply-To: <20230614152100.1664198-1-thomas@monjalon.net> References: <20230614152100.1664198-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 14 Jun 2023 17:20:59 +0200 Thomas Monjalon wrote: > Two functions helping to check Rx/Tx queues validity > were added in DPDK 23.07-rc1. > As the release is not closed, it is still time to rename. > > The name proposed originally > rte_eth_dev_is_valid_*xq > is consistent with this function: > rte_eth_dev_is_valid_port() > However, the suffixes "rxq" and "txq" are uncommon in ethdev functions. > > Also for shortness, many functions are dropping "_dev_" > as these functions which manage the queues: > rte_eth_*x_queue_info_get() > rte_eth_*x_queue_setup() > rte_eth_*x_hairpin_queue_setup > For completeness, there are some old functions having "_dev_": > rte_eth_dev_*x_queue_start() > rte_eth_dev_*x_queue_stop() > Anyway in all above examples, the subject is after the prefix, > and the verb is at the end. > > That's why I propose renaming into: > rte_eth_*x_queue_is_valid() > > Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity") > > Signed-off-by: Thomas Monjalon Shorter is better. Acked-by: Stephen Hemminger