From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8685942CB7; Wed, 14 Jun 2023 12:23:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B16040E0F; Wed, 14 Jun 2023 12:23:26 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2078.outbound.protection.outlook.com [40.107.212.78]) by mails.dpdk.org (Postfix) with ESMTP id CA75840DDB for ; Wed, 14 Jun 2023 12:23:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIfKjDDlbsflAYSrn0b4qEvWSZjfflCrkmnzKgqvJeJ2QzU/qYCyubtc1zHE/2CVpwhf7hznScXanhHsy1z7/vqUamXZQI/fAqnEn3na9mJ4f2nSzWQhrXZEIYr44Elv4Xc0mh73O/Ed6aofa887iyzzNdqhQ3vLLhs2xCewwlG3wP4XVLC+MSU1D9k/4s45KJmErly/W/OjjboxXTYiF6MOJqDaqpdhGItGGjtMbB5Y2cKsTRQVZNrxY40nY1m+H6xf9RlSz3u6EmWt96SwbQzen3emImuaCSArkOlG51f6NI+ANrw4DZnCXekFPu5qCOfdfTOsUD0Ecu6cV/H/9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5GFb+5bfSYM5NPfAVQDom4ekqBH2i6bNCa6+jwLKB1A=; b=gMyPixrAPwnEJwji09q3dA3KFhIOBZcbZNo+OUdinIUaOov/si5iXrPtTq88ZqfRc0Ib+JBnEC96/pwZQJxjyvG5ECn+6XAuYhKK8j7/yrtTWWAp+O2Dv23nF3l0SsVER02enVW2a/dlS2KV8OsM1iBGZVXahMUoPlkOiEpHs7JVNa72LGga/lU2CS2h/elH1MVu61eu7PaEqV2WJlHS0hjax2We7ubr92FDFtGSElh9sbmnFIqyaj3LXm558qaW0sCgq0heOq8IiX9xO96DYrHVWMRMJDd4iCAUu+QVr9dIq93IzyHadihKkuNzsOjidYCeLgI6uEYqpBcf2yXmAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GFb+5bfSYM5NPfAVQDom4ekqBH2i6bNCa6+jwLKB1A=; b=dKIxLa7iFWhrBZPR1wiHlRWZVELw7oowhAu9JQDQeUre/8KbusJ4yqad0cM45zPDOT0dCAYXwBkAVYd/BL7M86xQzS9xsz7gYncvf2Laab6ZzU13PVaFk5plO2JCf7UrmSrnXjxK59Fk791eRAFyleF4XFqonl9EYNP7RW8PRSA= Received: from DS7PR03CA0138.namprd03.prod.outlook.com (2603:10b6:5:3b4::23) by SJ0PR12MB5438.namprd12.prod.outlook.com (2603:10b6:a03:3ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun 2023 10:23:22 +0000 Received: from CY4PEPF0000EE35.namprd05.prod.outlook.com (2603:10b6:5:3b4:cafe::2b) by DS7PR03CA0138.outlook.office365.com (2603:10b6:5:3b4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37 via Frontend Transport; Wed, 14 Jun 2023 10:23:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE35.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.25 via Frontend Transport; Wed, 14 Jun 2023 10:23:22 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 05:23:21 -0500 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 14 Jun 2023 05:23:19 -0500 From: Abhijit Gangurde To: , CC: , , , Abhijit Gangurde Subject: [PATCH] bus/cdx: Move debug print before unmapping resource Date: Wed, 14 Jun 2023 15:53:14 +0530 Message-ID: <20230614102314.224579-1-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE35:EE_|SJ0PR12MB5438:EE_ X-MS-Office365-Filtering-Correlation-Id: c714622e-5b88-4a41-0e4a-08db6cc16180 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pdpszfiavq5orpmdrEG9p4XJcfmLV1w4+iWU5lb18yGuoj/R28RfZREMOZLI1FuC1XDbO7LjdrFuqHg7WyviC16c+/jXyDHpa9qmldUXV2lp8ilxq/HVNl1RdAhpkJXRuVjKx9DGv9D9BDi/Cf4B2R4gEyP+uCn8KLC6uwG/13pmXbcDijK7iOctL4RstwRlPfVqA6UrH5i0t2Yn6k3Uei2wJrhIekVyCOrbSHxx/A1PQHLJyFM8a6kOo8b4QbUgzlPZD68DAaZ+nk3nJIHGaAy7H3rO6NY45UuebWh0PTs9E5y3/mxvYaG/lBfHY1kQSSDOOQ8sVF9YuzR8NgEZ3oN4r0pHK1s5sjVmGRGSnEilJLQFFrTMFRfrKpY2JXjYooaUTPKrZGCke+aSlZE6K/WXTGm5QUaL31ensgrWbUjxWk8kAXxzUF9uuDzc8HpztnwL87c1KQuk9SHnf5fwDY5MKQiSRaL3gDtUHTL551Dm4ZjdEqMU0c8i5ZRePNB9ukwe1wIEfvptQoOH1XaTYx7tCOZsvTkmO9zYqyaeKtpYGR21dcIwyS7jflT3JR1TQxtmznfPPec/uw+UTv2i1WkJgAXjpEW3oeiq8Hgymdc6x4BokjoTpkoU7/E8RxDNPOVb3iJnO3GSVym78Jufjk2x9jGDR1F5tkJ5gk+R4i04vd9q1v2orOhlVAi6gD1nvMZZOhYbGpynDz/NuzVgb3KgfkB3o7FuBG9OXqrgTNxUj47gW3NrX/hwquF7XVP9lUoZ5GIeuTGiEFks3zFGEg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199021)(36840700001)(40470700004)(46966006)(8936002)(8676002)(4744005)(2906002)(82310400005)(5660300002)(70206006)(70586007)(356005)(316002)(81166007)(4326008)(6636002)(36860700001)(83380400001)(47076005)(110136005)(426003)(336012)(54906003)(41300700001)(82740400003)(2616005)(36756003)(478600001)(186003)(1076003)(26005)(40480700001)(6666004)(40460700003)(44832011)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 10:23:22.2233 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c714622e-5b88-4a41-0e4a-08db6cc16180 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE35.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5438 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Debug print is moved before unmapping requested address to fix use after free coverity issue. Coverity issue: 385381 Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/cdx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c index 28bbf92ed5..85353d8996 100644 --- a/drivers/bus/cdx/cdx.c +++ b/drivers/bus/cdx/cdx.c @@ -322,12 +322,13 @@ cdx_unmap_resource(void *requested_addr, size_t size) if (requested_addr == NULL) return; + CDX_BUS_DEBUG("Unmapping CDX memory at %p", requested_addr); + /* Unmap the CDX memory resource of device */ if (rte_mem_unmap(requested_addr, size)) { CDX_BUS_ERR("%s(): cannot mem unmap(%p, %#zx): %s", __func__, requested_addr, size, rte_strerror(rte_errno)); } - CDX_BUS_DEBUG("CDX memory unmapped at %p", requested_addr); } /* * Match the CDX Driver and Device using device id and vendor id. -- 2.25.1