From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBB3742CB7; Wed, 14 Jun 2023 12:24:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDA2440E0F; Wed, 14 Jun 2023 12:24:36 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by mails.dpdk.org (Postfix) with ESMTP id 128FE40DDB for ; Wed, 14 Jun 2023 12:24:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cDWw6MnIGIs/YdmBVyHV9GhuHpXpuUMd4qdvT9YX54mtK/+PS8nHxyAE7jFTqdiSspJo52adyJBKdO3vhaIYyzhN+oilbarQMIVtvdANR5XbE4tdKeC9sgauQLxO6lJQU6DT0+gTcwzzydvqK1jMZAXCAqxqDXpLmFvvnRfcbpGa5EzGmulWpyKmIneLoAvrEOms1aGK5i2FhXqd4jN6oHTyQtIgJtHW5S+c0DFbJkFqhQYIGxZVQ5cbQOBd71tNT+JlMqM1vZtvBMXyjJvk8bwfc6N0UqmpU17YEtAp9dnsBc7jHOL3rU5kpOGdial77isltGFKA8PKVaW9PwhVfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4X2x4cRjuXz2AoQovMnQHb32X9Q2RRPKUHB9qx60UZs=; b=U743AKDymvhrrB4Ta1kCsYFZGG8qYMC8F3oVbAQACm3agtE3aZZG9TY63n07WPOOdFp01giVVoF0kz9SuTyHUsE+PpsBeJ6f74hdhOsuWcJjIbmtihYcSLtmQ106o11zKqvUPl6MtuqoAePU9eklkufHW4qBnGFUeSHdx+AZE2JeMliijbtYaWmHK3+8dO2M3CeURfUvMWBgLyaLGnzSid++3nFR7OoKKfHc+U8aqYi9N3hU/F0iOBRmzHGMKlltXLvpP7LP5/yEaYZG28HQ/XNSZyKX7KeCyz/qEcWY+70q5P4l4Y5dp9e5CrgjeOi1mUOOB6CGC7qQX8qQ7rn+mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4X2x4cRjuXz2AoQovMnQHb32X9Q2RRPKUHB9qx60UZs=; b=C+8itJt5/ECA2A/VMWYx2Cvu85lZ0G7WuR97++HK5MHohZQjuaPiQer1I/PcNdPuUYnQaGTAHf3dC8/w6uQCFZ/Ql1lSeccUvzF7dseF/BFOvwnzXMzCPndGpyRMM7jv2QfU1xBFwWg9i+j+GibRgBGoe606n3PhnpVgkJE+ga0= Received: from CY5PR15CA0087.namprd15.prod.outlook.com (2603:10b6:930:18::13) by CH0PR12MB5123.namprd12.prod.outlook.com (2603:10b6:610:be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun 2023 10:24:33 +0000 Received: from CY4PEPF0000EE34.namprd05.prod.outlook.com (2603:10b6:930:18:cafe::17) by CY5PR15CA0087.outlook.office365.com (2603:10b6:930:18::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37 via Frontend Transport; Wed, 14 Jun 2023 10:24:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE34.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.25 via Frontend Transport; Wed, 14 Jun 2023 10:24:32 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 05:24:30 -0500 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 14 Jun 2023 05:24:28 -0500 From: Abhijit Gangurde To: , CC: , , , Abhijit Gangurde Subject: [PATCH] bus/cdx: Fix resource leak Date: Wed, 14 Jun 2023 15:54:24 +0530 Message-ID: <20230614102424.224679-1-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE34:EE_|CH0PR12MB5123:EE_ X-MS-Office365-Filtering-Correlation-Id: 8232c3fc-0492-4eb3-62c0-08db6cc18b9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qf83WbnstgDxzkaDoMAXO3425E4uElQhHoZuFgpwd46vhItK4NBoZXnD3vgMu825qGv29VDKxAwQ1v0VrQ8I3WwB17BCLrAh3bTFBDT4QhENsSJ+/V2OwWCNku9vW+fG88Y6trz2jcI+UKm5FNmcjNYmZVpzKdqLZC5SUPwGWkWai0U5xgTWOxddRLCBWBg0IfyjSjIwoTXhhuZOQNfKfYhPxTmROqwVRDvdzcoij/gP9fqwZl2W6nuERmOVggSr+LULEDtbPBR3RUX9g6gGKvlEoOIC5FvCkN82l8A2oErfCuBKY64Op3Xkk/c2nl2RpKP4Pdv0heip/RssGfohHKaL3ldLMAFhVaOQVi2oS04ZSElF08V+uJMFiLMtDgnqTbAjBJt7z9TEVBaL2xAIk5KKukawXWOaldlM8gp3bw/XQwtUJiQ6Wqzg/tjZk1jiL4uWPsqntO+Px5GpKrk6FqlHf26waEqkAkOj6i3fPIedKrac8sdl54ebox/SM7accjHthnFLMOlyqitCDTuz4AyQHz+nqLRK8CRbw5WqyOIUhI7IIh55OmcwiTpAYwn/YyzjJW43qTkQTALKr6EcqkjgKPmVhVofBREI597iUpIzGQU7CLDUUtnbEUSZqE33uuSw1PTc6n5/b+5pwrQJKucsgATUeUoiHU/CQOib/Hk3qJMqEn0yZygDsf+K3eprFDqY/Rf7pTGsbOR78qO/kpwnD+AmJFM2zpLc4W4cs3EeeneabqDuoW+8SK0dK9eb+aSIG+6oSn86UXrYGPhqtw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(8676002)(8936002)(2906002)(5660300002)(41300700001)(316002)(36860700001)(4326008)(6636002)(70206006)(70586007)(83380400001)(47076005)(336012)(426003)(2616005)(36756003)(186003)(82740400003)(54906003)(110136005)(356005)(1076003)(26005)(81166007)(40480700001)(478600001)(82310400005)(6666004)(40460700003)(44832011)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 10:24:32.8823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8232c3fc-0492-4eb3-62c0-08db6cc18b9b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE34.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Freeing the allocated resources on error scenarios. Coverity issue: 385377 Fixes: f29fb5caa135 ("bus/cdx: support MSI") Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/cdx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c index 28bbf92ed5..0f643ad2cb 100644 --- a/drivers/bus/cdx/cdx.c +++ b/drivers/bus/cdx/cdx.c @@ -208,8 +208,8 @@ cdx_scan_one(const char *dirname, const char *dev_name) ret = cdx_get_kernel_driver_by_path(filename, driver, sizeof(driver)); if (ret < 0) { CDX_BUS_ERR("Fail to get kernel driver"); - ret = -1; - goto err; + free(dev); + return -1; } /* Allocate interrupt instance for cdx device */ @@ -218,6 +218,7 @@ cdx_scan_one(const char *dirname, const char *dev_name) if (dev->intr_handle == NULL) { CDX_BUS_ERR("Failed to create interrupt instance for %s", dev->device.name); + free(dev); return -ENOMEM; } @@ -241,8 +242,8 @@ cdx_scan_one(const char *dirname, const char *dev_name) /* get device id */ snprintf(filename, sizeof(filename), "%s/device", dirname); if (eal_parse_sysfs_value(filename, &tmp) < 0) { - free(dev); - return -1; + ret = -1; + goto err; } dev->id.device_id = (uint16_t)tmp; @@ -251,6 +252,7 @@ cdx_scan_one(const char *dirname, const char *dev_name) return 0; err: + rte_intr_instance_free(dev->intr_handle); free(dev); return ret; } -- 2.25.1