From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Subject: [PATCH 0/5] cleanup in library header files
Date: Wed, 14 Jun 2023 16:26:46 +0200 [thread overview]
Message-ID: <20230614142651.1456116-1-thomas@monjalon.net> (raw)
While pulling some trees for DPDK 23.07-rc1,
I've seen that some wrong coding style for comments
were copied over and over.
In order to avoid copying wrong comment style,
the three first patches are fixing a lot of comments.
As it is not critical, they are not marked for backport.
While looking the header files, I've fixed some misuses of "extern".
Thomas Monjalon (5):
lib: remove blank line ending comment blocks
lib: remove extra asterisks ending comment blocks
lib: align comment blocks
lib: restrict use of keyword extern
cryptodev: fix comments of modular operation parameters
lib/acl/acl.h | 2 +-
lib/acl/acl_gen.c | 10 +-
lib/acl/acl_vect.h | 2 +-
lib/bbdev/rte_bbdev.h | 2 -
lib/bbdev/rte_bbdev_op.h | 1 -
lib/bbdev/rte_bbdev_pmd.h | 1 -
lib/bpf/bpf_impl.h | 8 +-
lib/cfgfile/rte_cfgfile.h | 303 ++++++++++++------------
lib/cmdline/cmdline_parse.h | 1 -
lib/cmdline/cmdline_parse_string.h | 14 +-
lib/compressdev/rte_comp.h | 1 -
lib/compressdev/rte_compressdev.h | 1 -
lib/cryptodev/cryptodev_pmd.h | 3 +-
lib/cryptodev/rte_crypto.h | 3 +-
lib/cryptodev/rte_crypto_asym.h | 16 +-
lib/cryptodev/rte_crypto_sym.h | 2 +-
lib/cryptodev/rte_cryptodev.h | 42 ++--
lib/cryptodev/rte_cryptodev_core.h | 1 -
lib/eal/arm/include/rte_cycles_32.h | 13 +-
lib/eal/arm/include/rte_cycles_64.h | 1 -
lib/eal/common/eal_common_proc.c | 1 -
lib/eal/include/generic/rte_cycles.h | 2 +-
lib/eal/include/generic/rte_pause.h | 1 -
lib/eal/include/generic/rte_spinlock.h | 1 -
lib/eal/include/rte_bitmap.h | 3 +-
lib/eal/include/rte_branch_prediction.h | 2 -
lib/eal/include/rte_eal.h | 2 -
lib/eal/include/rte_hexdump.h | 53 ++---
lib/eal/include/rte_interrupts.h | 1 -
lib/eal/include/rte_keepalive.h | 3 +-
lib/eal/include/rte_lcore.h | 1 -
lib/eal/include/rte_tailq.h | 1 -
lib/eal/include/rte_thread.h | 1 -
lib/eal/include/rte_ticketlock.h | 1 -
lib/eal/include/rte_trace_point.h | 1 -
lib/eal/linux/eal_vfio.h | 4 +-
lib/eal/ppc/include/rte_byteorder.h | 2 +-
lib/eal/windows/include/sys/queue.h | 1 -
lib/eal/x86/include/rte_byteorder_32.h | 2 +-
lib/eal/x86/include/rte_byteorder_64.h | 2 +-
lib/efd/rte_efd.c | 1 -
lib/ethdev/ethdev_driver.h | 1 -
lib/ethdev/rte_ethdev.c | 1 -
lib/ethdev/rte_ethdev.h | 66 +++---
lib/ethdev/rte_ethdev_core.h | 1 -
lib/ethdev/rte_flow.h | 23 +-
lib/ethdev/rte_mtr.h | 2 -
lib/ethdev/rte_tm.h | 4 +-
lib/ethdev/sff_8636.h | 2 -
lib/ethdev/sff_common.h | 1 -
lib/eventdev/event_timer_adapter_pmd.h | 1 -
lib/eventdev/eventdev_pmd.h | 17 --
lib/eventdev/rte_event_timer_adapter.h | 2 -
lib/eventdev/rte_eventdev.h | 11 -
lib/graph/rte_graph.h | 2 -
lib/hash/rte_hash.h | 1 -
lib/hash/rte_hash_crc.h | 1 -
lib/ip_frag/rte_ipv6_fragmentation.c | 1 -
lib/ip_frag/rte_ipv6_reassembly.c | 1 -
lib/ipsec/ipsec_telemetry.c | 1 -
lib/member/rte_member.h | 1 -
lib/mempool/rte_mempool.c | 1 -
lib/mempool/rte_mempool.h | 1 -
lib/meter/rte_meter.h | 10 +-
lib/mldev/mldev_utils.h | 1 -
lib/node/rte_node_eth_api.h | 1 -
lib/node/rte_node_ip4_api.h | 1 -
lib/node/rte_node_ip6_api.h | 1 -
lib/pcapng/rte_pcapng.h | 1 -
lib/pdcp/rte_pdcp_group.h | 1 -
lib/pipeline/rte_pipeline.c | 4 -
lib/pipeline/rte_pipeline.h | 9 +-
lib/pipeline/rte_swx_ipsec.h | 2 -
lib/pipeline/rte_swx_pipeline_spec.c | 11 -
lib/pipeline/rte_table_action.c | 2 +-
lib/port/rte_port.h | 5 +-
lib/port/rte_port_ethdev.h | 3 +-
lib/port/rte_port_eventdev.h | 3 +-
lib/port/rte_port_fd.h | 3 +-
lib/port/rte_port_frag.h | 3 +-
lib/port/rte_port_kni.h | 4 +-
lib/port/rte_port_ras.h | 4 +-
lib/port/rte_port_ring.h | 4 +-
lib/port/rte_port_sched.h | 3 +-
lib/port/rte_port_source_sink.h | 3 +-
lib/port/rte_port_sym_crypto.h | 3 +-
lib/port/rte_swx_port_fd.h | 5 +-
lib/port/rte_swx_port_ring.h | 3 +-
lib/power/guest_channel.h | 1 -
lib/rawdev/rte_rawdev.h | 2 -
lib/rawdev/rte_rawdev_pmd.h | 3 -
lib/rcu/rte_rcu_qsbr.h | 1 -
lib/regexdev/rte_regexdev_core.h | 1 -
lib/reorder/rte_reorder.h | 1 -
lib/ring/rte_ring.h | 1 -
lib/sched/rte_approx.h | 3 +-
lib/sched/rte_pie.h | 4 +-
lib/sched/rte_red.h | 6 +-
lib/sched/rte_sched.c | 3 +-
lib/sched/rte_sched.h | 8 +-
lib/sched/rte_sched_common.h | 2 -
lib/security/rte_security.h | 7 +-
lib/security/rte_security_driver.h | 1 -
lib/table/rte_swx_table_em.c | 1 -
lib/table/rte_table.h | 3 +-
lib/table/rte_table_acl.h | 3 +-
lib/table/rte_table_array.h | 3 +-
lib/table/rte_table_hash.h | 4 +-
lib/table/rte_table_hash_cuckoo.h | 4 +-
lib/table/rte_table_hash_ext.c | 37 ++-
lib/table/rte_table_hash_lru.c | 109 +++++----
lib/table/rte_table_lpm.h | 3 +-
lib/table/rte_table_lpm_ipv6.h | 3 +-
lib/table/rte_table_stub.h | 4 +-
lib/telemetry/rte_telemetry.h | 2 +-
lib/telemetry/telemetry_internal.h | 3 +-
lib/telemetry/telemetry_json.h | 3 +-
117 files changed, 386 insertions(+), 585 deletions(-)
--
2.40.1
next reply other threads:[~2023-06-14 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:26 Thomas Monjalon [this message]
2023-06-14 14:26 ` [PATCH 1/5] lib: remove blank line ending comment blocks Thomas Monjalon
2023-06-15 7:27 ` Ruifeng Wang
2023-06-14 14:26 ` [PATCH 2/5] lib: remove extra asterisks " Thomas Monjalon
2023-06-14 14:26 ` [PATCH 3/5] lib: align " Thomas Monjalon
2023-06-15 7:16 ` Ruifeng Wang
2023-06-14 14:26 ` [PATCH 4/5] lib: restrict use of keyword extern Thomas Monjalon
2023-06-14 14:26 ` [PATCH 5/5] cryptodev: fix comments of modular operation parameters Thomas Monjalon
2023-06-14 14:42 ` [PATCH 0/5] cleanup in library header files Jerin Jacob
2023-06-14 15:08 ` David Marchand
2023-06-14 15:53 ` Thomas Monjalon
2023-06-14 14:46 ` Bruce Richardson
2023-06-27 14:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614142651.1456116-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).