From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5287D42CBC; Thu, 15 Jun 2023 03:31:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A5B840E0F; Thu, 15 Jun 2023 03:31:07 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2110.outbound.protection.outlook.com [40.107.95.110]) by mails.dpdk.org (Postfix) with ESMTP id 4BC7840DDA for ; Thu, 15 Jun 2023 03:31:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZiYUKEU3WrMJ9MqVsLTpJkGzddD5TAsGBqiEW0+rHydGHltan3DTO3A+1nj2dvsf+97kiV0BWt1CPIdtWvpi5ansWUGnT9ywSyVaO1PkvkA5JvaLfZbLtjW7PE0aVgr023OiaKc63pnmCqAxSpSF9M7fSGSHk6txTs+ndZ5CdJZiiNedxOpElhXdbtmh3yvwGaT8pDPaX2Zytx1GiNBYtZHTvrQHQddxLgqGIbEfQE4WDz6MFp4sEV26riBet9BllUlta6+wr4l8IS1h2/wUunvrsI68cBtMyvIUls3ncjaQCaHCYdqy2B+KGgdZYjh10wABycHiOMi7FPuHcy9Rmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7IjJbhQzyFrjfFxO1SJc72IGn6sWybEKRfqZrD9vGps=; b=LqEuIguPXSvMl1e3saYPCzCs5X8WSuWN40Hira/YftkbQb+CPCVwpLX+ikrW+iurVs6eITXOnPYMnCm3FEuDrqdVm6f5fHDqnak7qNJESsSPaAiAqbm3IKn6wZS2lvX1VH8/M+vjrewamlsHRk0GthL6BNLT9+mLWSkGYL6+1LvR1k2N+HlVB+h9CD1K6VLnJbO1Ur3CrXHTGmjAyl/lyuLTknTcZ71VZxAY7rxSSAt/sPQKkGnPRQLRnZiGOw+251TyIZTmes8wyY5G8tPgSfAEKDqbZisPAVQ2wvjkghthaD6hcfe8wiSs8JOTfbj+Mc8B7Z1svfCeUtGKjOo6kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7IjJbhQzyFrjfFxO1SJc72IGn6sWybEKRfqZrD9vGps=; b=EceBBKxtrsLG7wpw7YGLw8Y3wsjrgTRDOtL9VNct8PPN1vsWsX7UVgHv7KxUX/A/d4gWO78aC+at+1/eM4coGxumykk2eoEpN2F1sB64xEOifSswrqeJKbh/WgZ0Dw05tspPDkeHn0thoQXNCRDXfCKLLrhNRETlwYaZyUpFxc8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DS7PR13MB4702.namprd13.prod.outlook.com (2603:10b6:5:3ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 01:31:02 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.045; Thu, 15 Jun 2023 01:31:02 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , Long Wu , Peng Zhang Subject: [PATCH] net/nfp: fix getting firmware version Date: Thu, 15 Jun 2023 09:30:38 +0800 Message-Id: <20230615013038.1243099-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0027.apcprd02.prod.outlook.com (2603:1096:3:18::15) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DS7PR13MB4702:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f2262b2-be6c-4132-4ac3-08db6d402dc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cdy6wZdRTCKKt/jCCf2Biuz2ZWeHQbOwp9qLERejM2t2uOM0wb3iIX46tRa5U/f7nCTdjzuWHFiRT4+BJKLRlwVx2l155HEvS39YfwoNdHejUqQgD1PZitc/86DmFzMgC+b5TfyjgAmL7EEvPX/OgkBm5FefI0fBrYk9lqBKwoEZZefWqXnX10uhgoT27D+2/I1T+1L7SFW1sHFyj7sEL0W3MG283/KkEN4rCAo8HDd4ktIf811BVDfWduL/MDY/IySYFdWUufHgKpSY4shQQLuUUjTXy0X+6yM5I6J0aoBQTZpBj/jNoExSsdvJ4/mfuqfmSC+jhIoDetecbBVRMcpuxUW0WTpl0MLBgd6AtwPd09RXk/XnwmxeKRTYAfV/qChAOcyRktcHZ2dnbalO6RgHsl7Y3+uPfuDVajeOntU8a4R8zJix3Xclqqug9LPxwK+6m5GR4uwMnUOUZnYA5XzlWE/0VwPeRow6YpBayuFRS9BPqCBxDWTK0AVnOVP4Nhg/4AIV9MC7MNg4HGP+9B4s/a/a541NOmmCxpZhMimrN3jSuTAsR6g9Gtd7e+4sCdoiCwQ603GNNonig6cCDLqOGJdnGSLEg98E+Y7q7TaUNQqKZBdAFiUXV2c43cicm6PA1fu0TtoTqTFxTJi9LYrXaSE4cMIvu/+t7zY65Fs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39840400004)(376002)(346002)(396003)(136003)(451199021)(5660300002)(83380400001)(186003)(6506007)(44832011)(66574015)(2906002)(2616005)(107886003)(6512007)(41300700001)(8936002)(52116002)(26005)(8676002)(6486002)(316002)(54906003)(6666004)(36756003)(478600001)(38350700002)(38100700002)(4326008)(66556008)(66476007)(86362001)(66946007)(6916009)(1076003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUJ2VFBOUWo3dVVhMnRaWnhlYVpsR1ljNFdoRWFLVzhrRFA2UWs3SHZ0VEJl?= =?utf-8?B?bkZGS0RHYnVJV3ArUmcxNGJRYmlmN3BuYkZYbXdmbnFYa0NNOWtoNFlPTHE1?= =?utf-8?B?UHcra20vcmlEaFhZMUJiM0VtWjVvbXkvcWVUOW02cU5PL09WcjhyUjZWREFJ?= =?utf-8?B?anBzVk43Q3ZYYWhZOTh2T3dHaTl4UUo3bWorZzBBRHo5MGVndFg1OWZmMnVn?= =?utf-8?B?MEFIaEZxU3VNblZ4WXpYWExCbXFQOGQ2WjRhckhlaFdNQmR5NXFrZ0NLTm9Q?= =?utf-8?B?cHNjYjRYOG8yUTVWM3I4N1BOMkZJemVPdmgyc2kvSmpuTnYvcmZZYnQzeUFU?= =?utf-8?B?Zk5BdGQ5QWovOVpVQ2RQZURyRVR4eU1EbHhpejV0RURrTE04cUdlL2UrR2Vi?= =?utf-8?B?RTFIWTErajhHWXpoWWZZNC9qdFJpemNEdW5kdloxYlprSjlOcENKRkN5LzVi?= =?utf-8?B?VW0zdlBXbm4rM1M0eE1iZXdTaU5kTm9lUUVPeHd1UlhMUnpvT3ZTT1grZHVm?= =?utf-8?B?WldWcFlXaGFvWjJORi9hNm9WYnVYWkRXK1hPazNCaXJvdjhaNC9La2tTdUha?= =?utf-8?B?SXl4MkhiN1ozODhqNjNwTzdsREV1ZnBQR0FYbEJ0TGU1ZzFtb0VBamttSmNL?= =?utf-8?B?cnFBY2N0SkxTNFFRbHFzY2E5RjRKdGo4QnVvWllvYXhNQy93eFhXUGJHNkNo?= =?utf-8?B?U1REd1JXejQzSzd6WmxzZFpNU2pIdlVldFJhMXFwZThXV3RmbkhLL1FQdEVO?= =?utf-8?B?UUIrMnZoc20vcnErcEdkQXdRc2VKNHpldVFZUFplNmZtNkZBMGFnQ3dIWDRD?= =?utf-8?B?ejBiYXE5d2dVTkV4VEdRN0l4MGtjeXJtZUtDbXNVWDRFdGVYZGFDSmVhTUg0?= =?utf-8?B?cjZ1NVdmeHZwajFHSFBFRVRkZmh2R0k1SmlwQ2RGV2Zod0VDemxpUXZmc0xK?= =?utf-8?B?VTUxTjVJV1ZnMVlidGZoN2RnZy8xWlQyTk4yWnB2elRhajM1MjlEcmtpUDAr?= =?utf-8?B?WUJieVJ0bjV0US92a3ErS09EMHY5Tzg2ckpXU3RpZGlkb3ROUkVsSU9iNGtw?= =?utf-8?B?N1d1aTNMelBweUVkbm01RW9odDdWeFloN0orN1l3WHBrdjlSSit0Y3BBeW55?= =?utf-8?B?c3l2a1ZMcm1Sei9PaXYvcWdrZjByUzUxelV6a2sweHVhbHowTGlCQi90U25O?= =?utf-8?B?U3JyOFJGK2tsTE1aTlVwbklJSi9uRU1yWjlpUnRoc29ITVVydysvMGQwSFpR?= =?utf-8?B?VkNOVjJBVU1WYmp6TkU1SjFSZS9oamJselAyTyttTjBxYUlqTGd1VjBVQTh1?= =?utf-8?B?Wm5DRXVSVlpRSEVBUWVadFI4RTVWd2VYQnEyaEJwSEpUaUNDUmRxb0tOc2JM?= =?utf-8?B?MWQ3MUFmcGkxL01nNTVHelJXa1JwZ01tVFVNTHU5VURYcmgzeUZTZ0hDTDR4?= =?utf-8?B?OWpsMlRoNlFZRkd6NXRPNUcvNU03TWpEcDdvNmRkS3NVMmNQcmpVdzZUU096?= =?utf-8?B?dElTR2ZvRW9QTy9xVmVGMlpWcGtCM294UmRsVHJXMDNtSHdWTFI2WlhOOEhk?= =?utf-8?B?M0pxMlQwQ0o2SXdYZDhJUk5VN1l2TGNqcy9Td2RMcG5kY2hhY0JweTVBVnM4?= =?utf-8?B?QjhYMG91dWMzQzh2cWttdVVzTDFsd3pkTlE0U2tBdTlobTBOSEZGL3JUQW1y?= =?utf-8?B?alpnS1l0NS9kRVltQXB3YlB6ZkY0bnQ5V1lIT29xRjJrSVFheGE4bkxXOHF4?= =?utf-8?B?WWRxT1lPYkdmV3FFMjNWOEl5ZEV2Q2pVcENHdG4yYm1DUGtOd1QwVHVmcHFJ?= =?utf-8?B?VzllMWVmNnZMcWloS21WdUpFNjY3anFkNGJ6bE0zSTRjaWE1dXNvNUNQc2tq?= =?utf-8?B?dGFGUzlRd1NqSXIwQXFmU3QrUEowdTcrL3hhYW5SblYwNTBZcWlwMjZOTExo?= =?utf-8?B?eHdaamkrbVoweGRVQmxyY2tUTGNXdWVVODFRTS8yQjVDWlZsK1U4RzJiTWtn?= =?utf-8?B?ZVJ1TjRrbXBJd2NPaW9tVERhMjVLak41M2lJQWcycDBGcm5KRzF1K2JhVzVi?= =?utf-8?B?a2dXMjZGSFhYZzFGd2N2eDhpOWZMRFgrRUpvVVcyZGdaczQvallVbGljU3Zl?= =?utf-8?B?eFdvRGFaMVpIeDdLN2t0cHZ2aWQ3Tks4U3BMbWhlbVNNa3o0VGE2S21vZjFt?= =?utf-8?B?M3c9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2262b2-be6c-4132-4ac3-08db6d402dc2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 01:31:02.2311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NbFBOraSKiR4+p6AMJonUYz4jHB9H1yOP7A4eqsxxmdAwccmEKv0ce457+wQMx6SrLgJcbcWKM2TeXvD9UM0RRBaDPJ7QcLUksmtHp10PrI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4702 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The VF PMD can not get a valid 'cpp' data filed in the 'struct nfp_net_hw', the value of which will be NULL always. This cause any logic which use of 'cpp' will make the app crash. Fix this by delete the support of getting firmware version of VF. Fixes: 128c8ad951bf ("net/nfp: support getting firmware version") Cc: chaoyong.he@corigine.com Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Niklas Söderlund Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev_vf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index f971bb8903..9020cd399b 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -241,7 +241,6 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = { .tx_queue_release = nfp_net_tx_queue_release, .rx_queue_intr_enable = nfp_rx_queue_intr_enable, .rx_queue_intr_disable = nfp_rx_queue_intr_disable, - .fw_version_get = nfp_net_firmware_version_get, }; static inline void -- 2.39.1