* [PATCH] net/nfp: fix getting firmware version
@ 2023-06-15 1:30 Chaoyong He
2023-06-21 12:44 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2023-06-15 1:30 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, niklas.soderlund, Chaoyong He, Long Wu, Peng Zhang
The VF PMD can not get a valid 'cpp' data filed in the 'struct
nfp_net_hw', the value of which will be NULL always. This cause any
logic which use of 'cpp' will make the app crash.
Fix this by delete the support of getting firmware version of VF.
Fixes: 128c8ad951bf ("net/nfp: support getting firmware version")
Cc: chaoyong.he@corigine.com
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_ethdev_vf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index f971bb8903..9020cd399b 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -241,7 +241,6 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = {
.tx_queue_release = nfp_net_tx_queue_release,
.rx_queue_intr_enable = nfp_rx_queue_intr_enable,
.rx_queue_intr_disable = nfp_rx_queue_intr_disable,
- .fw_version_get = nfp_net_firmware_version_get,
};
static inline void
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: fix getting firmware version
2023-06-15 1:30 [PATCH] net/nfp: fix getting firmware version Chaoyong He
@ 2023-06-21 12:44 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-06-21 12:44 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, niklas.soderlund, Long Wu, Peng Zhang
On 6/15/2023 2:30 AM, Chaoyong He wrote:
> The VF PMD can not get a valid 'cpp' data filed in the 'struct
> nfp_net_hw', the value of which will be NULL always. This cause any
> logic which use of 'cpp' will make the app crash.
>
It is not fixing getting FW version, but fixing crash by removing FW
get, updating patch title while merging.
> Fix this by delete the support of getting firmware version of VF.
>
> Fixes: 128c8ad951bf ("net/nfp: support getting firmware version")
> Cc: chaoyong.he@corigine.com
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-21 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 1:30 [PATCH] net/nfp: fix getting firmware version Chaoyong He
2023-06-21 12:44 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).