From: Stephen Hemminger <stephen@networkplumber.org>
To: Li Feng <fengli@smartx.com>
Cc: David Marchand <david.marchand@redhat.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
dev@dpdk.org, lifeng1519@gmail.com
Subject: Re: [dpdk-dev] [PATCH v3] log: support custom log function
Date: Thu, 15 Jun 2023 09:12:23 -0700 [thread overview]
Message-ID: <20230615091223.058b4d9b@hermes.local> (raw)
In-Reply-To: <20210210052019.802387-1-fengli@smartx.com>
On Wed, 10 Feb 2021 13:20:19 +0800
Li Feng <fengli@smartx.com> wrote:
> By default, the dpdk log is out to stdout/stderr and syslog.
> The rte_openlog_stream could set an external FILE* stream, but it asks
> the
> consumer to give it a FILE* pointer.
> For C++ or other languages, it's hard to get a libc FILE*.
>
> Support to set a hook is another choice for this scenario.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
Rejecting this patch.
You can do the same thing with a small bit of C called during application
init that creates a standard I/O stream. Like fopencookie().
The added overhead of adding callback here adds unnecessary complexity.
next prev parent reply other threads:[~2023-06-15 16:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 11:24 [dpdk-dev] [PATCH] " Li Feng
2021-02-05 11:31 ` Feng Li
2021-02-05 11:55 ` David Marchand
2021-02-05 12:22 ` Feng Li
2021-02-05 14:08 ` Dmitry Kozlyuk
2021-02-05 16:39 ` Stephen Hemminger
2021-02-05 16:10 ` Stephen Hemminger
2021-02-05 16:54 ` Feng Li
2021-02-05 17:06 ` Feng Li
2021-02-05 17:42 ` [dpdk-dev] [PATCH v2] " Li Feng
2021-02-05 17:47 ` Feng Li
2021-02-05 19:32 ` Dmitry Kozlyuk
2021-02-08 6:58 ` Feng Li
2021-02-08 22:40 ` Dmitry Kozlyuk
2021-02-10 3:59 ` Feng Li
2021-02-10 5:20 ` [dpdk-dev] [PATCH v3] " Li Feng
2021-02-18 2:55 ` Feng Li
2023-06-15 16:12 ` Stephen Hemminger [this message]
2021-02-18 6:12 ` [dpdk-dev] [PATCH v4] " Li Feng
2021-02-19 8:11 ` Dmitry Kozlyuk
2021-02-23 11:22 ` Feng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615091223.058b4d9b@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=fengli@smartx.com \
--cc=lifeng1519@gmail.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).