DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] buildtools: remove assumption about current work dir
Date: Thu, 15 Jun 2023 13:24:46 -0700	[thread overview]
Message-ID: <20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20230614144728.481566-1-bruce.richardson@intel.com>

On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote:
> According to meson documentation, we should not make any assumptions as
> to what directory a script is called from[1]. The use of "relpath" when
> processing the output of directory globbing is therefore unsafe, as it
> was stripping off paths relative to the current directory - which just
> happened to be the same as the root directory we were processing.
> 
> To improve safety, and support meson clones (like muon)  which
> don't always run things from the currently processed path, we need to
> explicitly specify that the start parameter for relpath() should be
> "root" value.
> 
> [1] https://mesonbuild.com/Reference-manual_functions.html#run_command
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>


  reply	other threads:[~2023-06-15 20:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:47 Bruce Richardson
2023-06-15 20:24 ` Tyler Retzlaff [this message]
2023-06-27 13:07   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).