DPDK patches and discussions
 help / color / mirror / Atom feed
From: Zhichao Zeng <zhichaox.zeng@intel.com>
To: dev@dpdk.org
Cc: qi.z.zhang@intel.com, songx.jiale@intel.com,
	Zhichao Zeng <zhichaox.zeng@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>
Subject: [PATCH] net/iavf: fix duplicate reset done check with large VF
Date: Wed, 21 Jun 2023 15:51:55 +0800	[thread overview]
Message-ID: <20230621075156.2997087-1-zhichaox.zeng@intel.com> (raw)

This patch fixes duplicate VF reset done check in dev_reset with large VF,
which cause some errors when starting testpmd with large VF.

Fixes: 7a93cd3575eb ("net/iavf: add VF reset check")
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 00b963128b..d32f4f826f 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -2859,15 +2859,17 @@ iavf_dev_reset(struct rte_eth_dev *dev)
 	int ret;
 	struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	/*
-	 * Check whether the VF reset has been done and inform application,
-	 * to avoid calling the virtual channel command, which may cause
-	 * the device to be abnormal.
-	 */
-	ret = iavf_check_vf_reset_done(hw);
-	if (ret) {
-		PMD_DRV_LOG(ERR, "Wait too long for reset done!\n");
-		return ret;
+	if (dev->data->nb_rx_queues <= IAVF_MAX_NUM_QUEUES_DFLT) {
+		/*
+		 * Check whether the VF reset has been done and inform application,
+		 * to avoid calling the virtual channel command, which may cause
+		 * the device to be abnormal.
+		 */
+		ret = iavf_check_vf_reset_done(hw);
+		if (ret) {
+			PMD_DRV_LOG(ERR, "Wait too long for reset done!\n");
+			return ret;
+		}
 	}
 
 	PMD_DRV_LOG(DEBUG, "Start dev_reset ...\n");
-- 
2.34.1


             reply	other threads:[~2023-06-21  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  7:51 Zhichao Zeng [this message]
2023-06-30  6:06 ` [PATCH v2] " Zhichao Zeng
2023-06-30  8:04   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621075156.2997087-1-zhichaox.zeng@intel.com \
    --to=zhichaox.zeng@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=songx.jiale@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).