DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Christensen <drc@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: David Christensen <drc@linux.vnet.ibm.com>,
	Thinh Tran <thinhtr@linux.vnet.ibm.com>
Subject: [PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10
Date: Tue, 27 Jun 2023 17:03:41 -0400	[thread overview]
Message-ID: <20230627210341.2516951-1-drc@linux.vnet.ibm.com> (raw)
In-Reply-To: <20230627205437.2476729-1-drc@linux.vnet.ibm.com>

Building DPDK with gcc 11.3.x for the power10 instruction set may
generate the following error:

../drivers/mempool/cnxk/cnxk_mempool_ops.c
during RTL pass: final
../drivers/mempool/cnxk/cnxk_mempool_ops.c:
  In function ‘cnxk_mempool_alloc’:
../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1:
  internal compiler error: output_operand: invalid expression as operand
  124 | }
      | ^
Please submit a full bug report,
with preprocessed source if appropriate.
...
ninja: build stopped: subcommand failed.

The same issue is not encountered when building with gcc 11.4 or
later, where the compiler automatically adds the option
"-mno-block-ops-vector-pair" when building for power10 which
is intended as a code optimization and also effectively avoids
the compiler bug displayed.

Modify the meson.build file for ppc and manually set the flag when
building for power10 with gcc less than 11.4.

Bugzilla ID: 1251

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
v2:
 - Fixed spelling error in commit message
---
 config/ppc/meson.build | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index 1cba44011f..160b203cb1 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -105,6 +105,14 @@ else
     endif
 endif
 machine_args = ['-mcpu=' + cpu_instruction_set, '-mtune=' + cpu_instruction_set]
+
+# gcc versions < 11.4 may fail to build for power10, see https://bugs.dpdk.org/show_bug.cgi?id=1251.
+# Explicitly specify a default used in gcc 11.4 and later to workaround the issue
+if (cpu_instruction_set == 'power10' and cc.get_id() == 'gcc' and
+        cc.version().version_compare('<=11.4'))
+    machine_args += '-mno-block-ops-vector-pair'
+endif
+
 dpdk_conf.set('RTE_MACHINE', cpu_instruction_set)


--
2.31.1


  reply	other threads:[~2023-06-27 21:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 20:54 [PATCH] " David Christensen
2023-06-27 21:03 ` David Christensen [this message]
2023-06-27 23:35   ` [PATCH v2] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627210341.2516951-1-drc@linux.vnet.ibm.com \
    --to=drc@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=thinhtr@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).