* [PATCH] net/mlx5: fix matcher index in case of insertion by index
@ 2023-06-28 12:54 Alexander Kozyrev
2023-07-18 9:19 ` Ori Kam
2023-07-18 15:02 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2023-06-28 12:54 UTC (permalink / raw)
To: dev; +Cc: matan, rasland, viacheslavo
There is only one matcher in an index-based template tables.
Pass the 0 as the matcher index, not actions template index.
Fixes: adfa4b1445 ("net/mlx5: add flow rule insertion by index")
Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index b5137a822a..2cf9e6ef3a 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -2796,8 +2796,7 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev,
*/
if (flow_hw_actions_construct(dev, job,
&table->ats[action_template_index],
- action_template_index, actions,
- rule_acts, queue, error)) {
+ 0, actions, rule_acts, queue, error)) {
rte_errno = EINVAL;
goto free;
}
--
2.18.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/mlx5: fix matcher index in case of insertion by index
2023-06-28 12:54 [PATCH] net/mlx5: fix matcher index in case of insertion by index Alexander Kozyrev
@ 2023-07-18 9:19 ` Ori Kam
2023-07-18 15:02 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Ori Kam @ 2023-07-18 9:19 UTC (permalink / raw)
To: Alexander Kozyrev, dev; +Cc: Matan Azrad, Raslan Darawsheh, Slava Ovsiienko
Hi Alexander,
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, June 28, 2023 3:55 PM
> Subject: [PATCH] net/mlx5: fix matcher index in case of insertion by index
>
> There is only one matcher in an index-based template tables.
> Pass the 0 as the matcher index, not actions template index.
>
> Fixes: adfa4b1445 ("net/mlx5: add flow rule insertion by index")
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_hw.c
> b/drivers/net/mlx5/mlx5_flow_hw.c
> index b5137a822a..2cf9e6ef3a 100644
> --- a/drivers/net/mlx5/mlx5_flow_hw.c
> +++ b/drivers/net/mlx5/mlx5_flow_hw.c
> @@ -2796,8 +2796,7 @@ flow_hw_async_flow_create_by_index(struct
> rte_eth_dev *dev,
> */
> if (flow_hw_actions_construct(dev, job,
> &table->ats[action_template_index],
> - action_template_index, actions,
> - rule_acts, queue, error)) {
> + 0, actions, rule_acts, queue, error)) {
> rte_errno = EINVAL;
> goto free;
> }
> --
> 2.18.2
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/mlx5: fix matcher index in case of insertion by index
2023-06-28 12:54 [PATCH] net/mlx5: fix matcher index in case of insertion by index Alexander Kozyrev
2023-07-18 9:19 ` Ori Kam
@ 2023-07-18 15:02 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2023-07-18 15:02 UTC (permalink / raw)
To: Alexander Kozyrev, dev; +Cc: Matan Azrad, Slava Ovsiienko
Hi,
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, June 28, 2023 3:55 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix matcher index in case of insertion by index
>
> There is only one matcher in an index-based template tables.
> Pass the 0 as the matcher index, not actions template index.
>
> Fixes: adfa4b1445 ("net/mlx5: add flow rule insertion by index")
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-18 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-28 12:54 [PATCH] net/mlx5: fix matcher index in case of insertion by index Alexander Kozyrev
2023-07-18 9:19 ` Ori Kam
2023-07-18 15:02 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).