From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEB5642D8E; Thu, 29 Jun 2023 18:27:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD738410D0; Thu, 29 Jun 2023 18:27:16 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id DEF91406B7 for ; Thu, 29 Jun 2023 18:27:15 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-262e81f6154so498450a91.2 for ; Thu, 29 Jun 2023 09:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688056035; x=1690648035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2EFqfLlkmv4MjB/iYm+Z8L1PDd+JNJ5h7nCEpTQwbr4=; b=EEyr8AU/kCRTU9betDgDMG7tSz8NZPlmS1goditT3fLwY2JtQQqXFQi/Ed8NLQ0EAc rnV5fFZtmk2E7ZuV19m8IqgOyrkzBxV+3X/iMqr9gMIEBO8JiC3VKdasM6qgnonel/af wcjci58CGIta3R2AM2T8PcgKKrVfcw9BW/ckTVbUSS6HiX//sk/AVXG4MPSkRGd5bczl 8u11X86vkom7kc9JQt1t74FJziJiAMsEtHAu/1yB+ePP3CIeVfo4oee3Qck+yfA74/vv gxhB3j4pJnxuZbxUNYK1g2+O9p0pexI6IbJA5JN4FYL+NEwYnNgMPWsXp9jH2b192Sj9 wN6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688056035; x=1690648035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2EFqfLlkmv4MjB/iYm+Z8L1PDd+JNJ5h7nCEpTQwbr4=; b=f58nHJEzTtaMSUTFdUHWmvKjOInv6mzpGY1pSkBNGlTMVeQTmv8pJ0YMaoryBQ4eAT TkuRfzIudP3NA5VTVG/LSrxBbAgyJszbifMG5ba6wSmGXFcyXMffH9eFWWFlY2XRfztl bgALZ0qz1175Z0XvWtd+ebtVa2urocPePcl9N+Y8hNgtoErThToQN7Jx8S5RbVO6Vo7I e+BbD909jeBbb2si/wdRTbIYAPtkZVoqyZKWMsvgxKE5Cv7bH0tcMnHy/Qs1C47UxrLv E2JX79FhOMkIZs0dW98EpsGrJY34vf0JwvfoHatgmWf3igQqZMsYEZncYuW3e3R4s3xw +oKQ== X-Gm-Message-State: AC+VfDwMfx6N0dY5PuhHKi5XdnK4M2eqEj9Eo/dgXWljad5zmJ+zxD3p 3kqyWct69d65D+Ja+kz2viq2Zw== X-Google-Smtp-Source: ACHHUZ7oRwOrfXgWPrb7VJ/qCfbyQJ1UF3MbmqDh6c5URV4lVT/miFgOGyxqFlyrcfLvrzZs3BEpMw== X-Received: by 2002:a17:90a:19c2:b0:25c:2c56:a8ae with SMTP id 2-20020a17090a19c200b0025c2c56a8aemr21401777pjj.19.1688056035084; Thu, 29 Jun 2023 09:27:15 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 6-20020a17090a018600b0025bd4db25f0sm10052394pjc.53.2023.06.29.09.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 09:27:14 -0700 (PDT) Date: Thu, 29 Jun 2023 09:27:13 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v5 0/4] improve options help Message-ID: <20230629092713.4e3090e3@hermes.local> In-Reply-To: <20210405193954.1115838-1-thomas@monjalon.net> References: <20210309233116.1934666-1-thomas@monjalon.net> <20210405193954.1115838-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 5 Apr 2021 21:39:50 +0200 Thomas Monjalon wrote: > After v4, this series is split in several parts. > The remaining 4 patches of this series are low priority. > > Patches 1 and 3 are simple improvements. > > Patches 2 and 4 lead to a new formatting of the usage text. > It is a matter of taste and should be discussed more. > > v5: no change > > Thomas Monjalon (4): > eal: explain argv behaviour during init > eal: improve options usage text > eal: use macros for help option > app: hook in EAL usage help > > app/pdump/main.c | 2 ++ > app/proc-info/main.c | 2 ++ > app/test-acl/main.c | 2 ++ > app/test-bbdev/main.c | 3 ++- > app/test-compress-perf/comp_perf_options.h | 2 ++ > app/test-compress-perf/comp_perf_options_parse.c | 8 ++++---- > app/test-compress-perf/main.c | 3 ++- > app/test-crypto-perf/cperf_options.h | 2 ++ > app/test-crypto-perf/cperf_options_parsing.c | 8 ++++---- > app/test-crypto-perf/main.c | 3 ++- > app/test-fib/main.c | 8 ++++++++ > app/test-flow-perf/main.c | 4 +++- > app/test-pmd/parameters.c | 4 ++-- > app/test-pmd/testpmd.c | 2 ++ > app/test-pmd/testpmd.h | 1 + > app/test-regex/main.c | 3 ++- > app/test-sad/main.c | 7 +++++++ > lib/librte_eal/common/eal_common_options.c | 13 ++++++------- > lib/librte_eal/freebsd/eal.c | 10 +++++----- > lib/librte_eal/include/rte_eal.h | 2 ++ > lib/librte_eal/linux/eal.c | 14 +++++++------- > lib/librte_eal/windows/eal.c | 12 +++++------- > 22 files changed, 74 insertions(+), 41 deletions(-) > Thomas, this patchset seems ready but never made it in. What is best disposition for it: 1. Rebase and resubmit? 2. I could add it to the log patch series WIP? 3. Drop it since old?