From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0923242D8B; Thu, 29 Jun 2023 12:01:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E252040EDB; Thu, 29 Jun 2023 12:01:19 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2051.outbound.protection.outlook.com [40.107.92.51]) by mails.dpdk.org (Postfix) with ESMTP id D4ECE406B7; Thu, 29 Jun 2023 12:01:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n98ZS9Kf4P5iAqwFycC6PI49uzzRSUlndZGWDBSIzqQyNVYScSUrPOuvh0Q25FM5v8sufi3Az3vAkLA4ZVZg5IW3eZGC3K+MaiEPHhMyG3J5vigTrguEjF9J/ngCBDDOjk7QcUUdL/pDU+esfaqmOPjvoGfU8syDBDGTI2Y2hwrj7MgVI78DLQMDnNmbY05vlgwIlQmxHcQy7e22xaU6UCoRe5j/j3cm9yvPp/yTh2b4otSYilP5wHrVzxAXaMwSxpck7FueLz7PjQhtaisDfuBO4dandnPE8Q4znjPCjW5yH2tKxXS5SGauY6eK6/aij0o3aD44Dy1zDU7JRgx5Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wbC4mXWivEMOewSHuhaehCKmzGQx1YrQ19JfL8gBAg=; b=e+Ke75XSL9plt2RXd2pMJ8GvQ/+BwubtTkoU5kMAMaNnNr3K01hfaVeV43DGHyBPulUD2GgC1hXdoVJ0W3NyP5GxQfw1xuMiqbczSxyR8NM+RjhRT6AVJws3ZBp3E9HLCFhFfghYObD793JykYNWYZyTrD3ShmGlvXPVKF9AsXXmC2gb2PV8mCSSiFb+CYkoYmEGBMlRqn6PZt5MCX5Bb6TCGvoeh+3V0Q8NBb9JKJlegnwMOF97IDTA3fT10QCk2WN419kHOXucbmYwbiZ30cZbfqEsAo/DzDRZra7J+rS0m7VW09ZKZNNKTAj4Jo5KfasmrJR3sd/S81SLrZstDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wbC4mXWivEMOewSHuhaehCKmzGQx1YrQ19JfL8gBAg=; b=Ly2RSP/ystpveMqTcJhHFmgqc4juXtjJqTG0Z2BH0BEltD8S+s0MUPcNZW8SZTOMG07LCCOd2fJfjv6Fbx7gkWtKgQFaTjVN0KVHuhvP12loKf1YkPE86zaUi8PqaHt+OQVvy9E04FYl+rHMoh5kzlpcqY1L+S/KDVlKC970EaN+zPNTp/zBXHnUujF7AAOOb3ZRhPo9EUcJBqoDnhOT10Mj9S+pzZpH9z0amg9elN/DSYA/IYl8lnciIBy4ThZdZThPSx7uxGUJkkdYrFt2qCHRa5gMok8QqCpsmvKnvwGgAVLEwV8+/G7DEQm9L3U1m/UM2vCZLrGy8LEdniOIKA== Received: from BN9PR03CA0055.namprd03.prod.outlook.com (2603:10b6:408:fb::30) by BL1PR12MB5756.namprd12.prod.outlook.com (2603:10b6:208:393::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Thu, 29 Jun 2023 10:01:17 +0000 Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fb:cafe::1e) by BN9PR03CA0055.outlook.office365.com (2603:10b6:408:fb::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 10:01:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Thu, 29 Jun 2023 10:01:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 03:01:04 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 03:01:01 -0700 From: Sean Zhang To: , Matan Azrad , "Viacheslav Ovsiienko" , Ori Kam , Suanming Mou , Haifei Luo CC: , Subject: [PATCH] net/mlx5: fix flow dump for modify field Date: Thu, 29 Jun 2023 13:00:44 +0300 Message-ID: <20230629100044.166185-1-xiazhang@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT061:EE_|BL1PR12MB5756:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ce042f0-d72a-4956-0a35-08db7887c7c0 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWbb6lfIDp9VBt0Apq0tiFpbVK4DNtt48AWUW7IjA9q818tzws/jItiR/R2teRgFHNoBm9mpuWs3WRTJ+Q0mnVhivaXqdfPzd/yM45kpMfzDv28mCiVBMTU0zVhgj4dKPA0g0uWw76SE5Y9uuZyjJSwg2oB4KWdz0AiC76qfltsKq9YudNUbmHBrqVcmLF6Zb8I0ztsxQEpcXNaDuXK4L7II4qQCYK8IfJ0yvR81zaJ3Hnr8XT6S4MlDVZRL9zShwgtTlzwURimLtq+LffjbOsTZlJtgOqvHPHl6oIYEVKGzqPtjYbtyqJLM4C/Yi226YeJm157MnaywZ6Ej5JHo06+6FIzQELcApMczdLqDcPNAJxiXz6KSoLD8z6D6Z2YkyfizQG0uNXR1mUn7TdlL7+NE6U1OamxF7j7rTwa4M9eFFB2KbbC9rudr0NS2SUGAevtYmfO0GiTQKnffYia+QSlk3D8BTPE0a1ntvrKhZzjvvnDS4L3fVkyGIJW00FNH0/cbyfC87H3FkBQPrd97CEY7Rli9jytEeoEHcb4KRkOSySc6PFcFLqMUKNVuvLG2O0VPS6nQZTh6xwKkuitRh5qRFoP4uFJTXTLnGrDt/8vwRokC3MjFDf3ztzidz0BzS12i2x1XUxg4EP8eTnsK2GA755Z3iOjTApJJasU3cVvo4jy0sgZnuPAImGkVSq5df1o+G2X1o+iq7/d3taBO/v429AtlA1F/NMAeIqCUsc0= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199021)(36840700001)(46966006)(40470700004)(36756003)(36860700001)(82310400005)(47076005)(336012)(26005)(6666004)(54906003)(2616005)(426003)(83380400001)(110136005)(186003)(2906002)(16526019)(6286002)(7696005)(478600001)(1076003)(356005)(86362001)(316002)(5660300002)(70206006)(40460700003)(82740400003)(40480700001)(7636003)(6636002)(70586007)(8676002)(4326008)(41300700001)(8936002)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 10:01:16.8195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce042f0-d72a-4956-0a35-08db7887c7c0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5756 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When using other process to dump flow information, the modify field information cannot be dumpped due to incorrect lcore value. Add loop to get modify field information from all lcore to fix the issue. Fixes: a7ac7fae4919 ("net/mlx5: enhance flow dump") Cc: stable@dpdk.org Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 58 +++++++++++++++++++++++++----------- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index cf83db7b60..abb86241fc 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -10390,23 +10390,47 @@ mlx5_flow_dev_dump_sh_all(struct rte_eth_dev *dev, } i = lcore_index; - for (j = 0; j <= h->mask; j++) { - l_inconst = &h->buckets[j].l; - if (!l_inconst || !l_inconst->cache[i]) - continue; - - e = LIST_FIRST(&l_inconst->cache[i]->h); - while (e) { - modify_hdr = - (struct mlx5_flow_dv_modify_hdr_resource *)e; - data = (const uint8_t *)modify_hdr->actions; - size = (size_t)(modify_hdr->actions_num) * 8; - actions_num = modify_hdr->actions_num; - id = (uint64_t)(uintptr_t)modify_hdr->action; - type = DR_DUMP_REC_TYPE_PMD_MODIFY_HDR; - save_dump_file(data, size, type, id, - (void *)(&actions_num), file); - e = LIST_NEXT(e, next); + if (lcore_index == MLX5_LIST_NLCORE) { + for (i = 0; i <= (uint32_t)lcore_index; i++) { + for (j = 0; j <= h->mask; j++) { + l_inconst = &h->buckets[j].l; + if (!l_inconst || !l_inconst->cache[i]) + continue; + + e = LIST_FIRST(&l_inconst->cache[i]->h); + while (e) { + modify_hdr = + (struct mlx5_flow_dv_modify_hdr_resource *)e; + data = (const uint8_t *)modify_hdr->actions; + size = (size_t)(modify_hdr->actions_num) * 8; + actions_num = modify_hdr->actions_num; + id = (uint64_t)(uintptr_t)modify_hdr->action; + type = DR_DUMP_REC_TYPE_PMD_MODIFY_HDR; + save_dump_file(data, size, type, id, + (void *)(&actions_num), file); + e = LIST_NEXT(e, next); + } + } + } + } else { + for (j = 0; j <= h->mask; j++) { + l_inconst = &h->buckets[j].l; + if (!l_inconst || !l_inconst->cache[i]) + continue; + + e = LIST_FIRST(&l_inconst->cache[i]->h); + while (e) { + modify_hdr = + (struct mlx5_flow_dv_modify_hdr_resource *)e; + data = (const uint8_t *)modify_hdr->actions; + size = (size_t)(modify_hdr->actions_num) * 8; + actions_num = modify_hdr->actions_num; + id = (uint64_t)(uintptr_t)modify_hdr->action; + type = DR_DUMP_REC_TYPE_PMD_MODIFY_HDR; + save_dump_file(data, size, type, id, + (void *)(&actions_num), file); + e = LIST_NEXT(e, next); + } } } -- 2.34.1