From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Kiran Kumar K <kirankumark@marvell.com>
Subject: [PATCH] ethdev: fix Tx queue mask endianness
Date: Thu, 29 Jun 2023 15:58:39 +0200 [thread overview]
Message-ID: <20230629135839.974700-1-david.marchand@redhat.com> (raw)
Even if harmless, this endianness tag is incorrect as the tx_queue field
is declared as a host integer.
Additionally, this breaks OVS compilation with sparse.
Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/ethdev/rte_flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 3fe57140f9..86ed98c562 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -2307,7 +2307,7 @@ struct rte_flow_item_tx_queue {
/** Default mask for RTE_FLOW_ITEM_TX_QUEUE. */
#ifndef __cplusplus
static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask = {
- .tx_queue = RTE_BE16(0xffff),
+ .tx_queue = 0xffff,
};
#endif
--
2.40.1
next reply other threads:[~2023-06-29 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:58 David Marchand [this message]
2023-06-29 14:48 ` Ferruh Yigit
2023-06-29 15:31 ` Thomas Monjalon
2023-06-29 15:40 ` David Marchand
2023-06-29 15:42 ` Thomas Monjalon
2023-06-29 16:14 ` Ferruh Yigit
2023-06-30 7:00 ` David Marchand
2023-06-30 7:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629135839.974700-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kirankumark@marvell.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).