From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A416342D73; Fri, 30 Jun 2023 08:08:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A684406B5; Fri, 30 Jun 2023 08:08:35 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 575B24021F for ; Fri, 30 Jun 2023 08:08:34 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b8303cd32aso12165865ad.2 for ; Thu, 29 Jun 2023 23:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688105313; x=1690697313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LOtSoGWvJwnMoGTaQWIFptBiTNAJcJoC9FW1jXgdazs=; b=kIwN4f/l54tiBGTNnTCZMjcfdq2QoA4h0OmIWBkRpk0swNToAZkD9VEAFsnMabgpsX jv4axLK2E/wezCIKo+6XxyhjCY7RrBx+wdZ5O1e7/tBEQBsipgpEhDQwV3HgPm3G9GiU gzkuUjxKtUuoffwwEAV6Zhelgpn/qcFFiL9YEHdeippd8A00DaoHEMx/xjR9fOjaZXJ0 e7FOBuzu0LM7mHIxivwva6xMCg1AEoU7LZ1GbthAHgENn35TjU+0vdMcUknqkhn+t5nK bl6xlwibvYxHXutzAsIDhDXTxMNedBg7TICzEkYpeRVCQx6o9jtu/am4llz84ouguSnh ifsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688105313; x=1690697313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LOtSoGWvJwnMoGTaQWIFptBiTNAJcJoC9FW1jXgdazs=; b=L0Yii1BrdkjkWEYnGCsz5w3kYlqVB/lCfnpFrWIg+emOtzPtz0qwHaICn2sHu0hRf/ P28MRgddVTcyPfvouaTTQ+sDNA4RptbYAZsBHQ45i/NVIq/F/xuVPw5dBLXnhRNdJdFl GfnfKDAyWAKlbNDBfY2mz3Ret9OuAtu4jsv++bsvv6be34RvYUcsFM8Unk/L+TyNN86w 7gd02pSe0u0hPDPELP57R7En5fDz0eh8hNPEpRF0jKlmmd8r0i9pk0JJ4lqqBQFKL++z WuYxan2Dn8Itrc9DQtjsZCtB2mXROP61n+UXAsk6PtFTYnpt5Htzsq1wBku8Hv7jOKrN l7fA== X-Gm-Message-State: ABy/qLbWqsQBgAAstbWdaKR4JhcfmtYWDSUDj42iP9/vpD5IyHlL3aum l70oMzI9jW4SkMCfxZbJZjRZxw== X-Google-Smtp-Source: APBJJlHFEFtQYRc4Ec7JuPDeYJle2NjH5oUur5JWS0HTKafpngQH7NiSO/czfrQrU8/cRn7NCOBq9Q== X-Received: by 2002:a17:903:11d1:b0:1b6:6625:d3a8 with SMTP id q17-20020a17090311d100b001b66625d3a8mr1460053plh.16.1688105313467; Thu, 29 Jun 2023 23:08:33 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jn16-20020a170903051000b001b53472353csm9981614plb.211.2023.06.29.23.08.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 23:08:33 -0700 (PDT) Date: Thu, 29 Jun 2023 23:08:31 -0700 From: Stephen Hemminger To: Bing Zhao Cc: , , , , , , Subject: Re: [PATCH 1/7] net/mlx5: fix the modify field check of tag Message-ID: <20230629230831.10023261@hermes.local> In-Reply-To: <20230630054303.432238-1-bingz@nvidia.com> References: <20230630054303.432238-1-bingz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 30 Jun 2023 08:43:03 +0300 Bing Zhao wrote: > @@ -1117,9 +1117,10 @@ flow_dv_fetch_field(const uint8_t *data, uint32_t size) > static inline bool > flow_modify_field_support_tag_array(enum rte_flow_field_id field) > { > - switch (field) { > + switch ((int)field) { > case RTE_FLOW_FIELD_TAG: > case RTE_FLOW_FIELD_MPLS: > + case MLX5_RTE_FLOW_FIELD_META_REG: Mixing internal and API fields seems like something that could get easily broken by changes to rte_flow.