From: Stephen Hemminger <stephen@networkplumber.org>
To: Xueming Li <xuemingl@nvidia.com>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Kinsella Ray <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v1] eal: update all buses default scan mode
Date: Fri, 30 Jun 2023 09:16:16 -0700 [thread overview]
Message-ID: <20230630091616.4df6c0f9@hermes.local> (raw)
In-Reply-To: <20210328131222.16584-1-xuemingl@nvidia.com>
On Sun, 28 Mar 2021 21:12:22 +0800
Xueming Li <xuemingl@nvidia.com> wrote:
> When parsing EAL allowed or blocked device arguments, only device bus
> being parsed got default scan mode updated. If the devargs was vdev, PCI
> bus default scan mode not touched, all PCI bus devices will got probed
> even none appear in allowed list.
>
> This patch update all buses default scan mode when parsing first
> devargs.
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Looking back at this old patch, and wondering why it never got applied.
Probably because it wasn't clear the exact problem.
It does raise the issue that scan_mode is currently a property
of the bus, not global. This patch would cause setting of allowed list
for PCI to also impact other bus types. That doesn't follow current
practice.
If you want to resubmit, make it per bus.
prev parent reply other threads:[~2023-06-30 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:45 [dpdk-dev] [PATCH] " Xueming Li
2021-03-22 23:32 ` Dmitry Kozlyuk
2021-03-23 9:33 ` Kinsella, Ray
2021-03-23 9:34 ` Kinsella, Ray
2021-03-23 9:57 ` Dmitry Kozlyuk
2021-03-23 9:58 ` Kinsella, Ray
2021-03-28 13:14 ` Xueming(Steven) Li
2021-03-28 13:12 ` [dpdk-dev] [PATCH v1] " Xueming Li
2023-06-30 16:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630091616.4df6c0f9@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=mdr@ashroe.eu \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).