From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD49342D98; Fri, 30 Jun 2023 18:16:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D24740EDB; Fri, 30 Jun 2023 18:16:21 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 600CA406B6 for <dev@dpdk.org>; Fri, 30 Jun 2023 18:16:20 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b7db2e162cso11234495ad.1 for <dev@dpdk.org>; Fri, 30 Jun 2023 09:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688141779; x=1690733779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=d1EAnPtow98irWjOi0tP8w2uJVQbw0Rlj8uKr0+t6m0=; b=daGj/q5v1ZUculxWJkAnr7eHK+q2l/fnAbYxW465oHjN8FNm2p0cJyQbeuU9GqRBE8 py7PA11oSrqJi5xEWfL63dPsdfZo957D4vSx5YUtov8XkDFFqBO0ULvWWmG4XJINlKKA AVKu7CWiU7qZpWD9Ihzc0Zk+zt+U3wK4tUA5pah70ZN3whQzRNxLSENRLUC1543L5Nfn ofAnPNCVhIeNMcwpuibtH+Wl5EldfipWgyvzedY1hpZyerz0ruiH6WwTDvnuuqn7KINB wIwvD7azHDtQaRvvSOPv7ardpOEUy7BG3VMxs7AYdBOQlf/p66+dSo2U1sWF09dIldI3 T74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688141779; x=1690733779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d1EAnPtow98irWjOi0tP8w2uJVQbw0Rlj8uKr0+t6m0=; b=eO4cs018DAZtZY0PFEc7sH0wDm1mJsgfdHuAQ/OpMdnTBfyPfEmYVFgTMsO9zoL7nQ JIpV5IR08cBj+r65ykLLPoKqL6Vscaao/UNlb40RD4SQOeYmbs7ZQ4XTw7yVrhBSh/tJ 6q6TkYcehuxB4zPvBP8ON9ghVlV5Ph2w7KqSpx66m72kRaoqJk/7t/2eKekESC4BaNJA +mp5HcrXpQ00ff9UidK9q89UdWwPTbsof7egx1zXcT17Ucc/dNu/saa5ptWLBDL0hS/X Wc01YeEFnqsji9T2hV3xCHGlxrpShN1htlgaH+A+ZwUZ23mrLu3RqKSaXk211aWMxMma vYvw== X-Gm-Message-State: ABy/qLZMt08gYP7W1MHq46OGi40prgDfPQb6VQzbfL6L0qyA5cJxH6vw W6/RKjbnreMC2BguYr7JMsc6KDS3IcdIxZrzT7jE+g== X-Google-Smtp-Source: APBJJlHs9ZL2gn5Ut3OZ4kfQplYG81cv0vaRNUdLI47GkLe1WBUAtaLcqLi6iXkdweMb0AmdEbEjig== X-Received: by 2002:a17:902:ea08:b0:1b6:bced:1dd6 with SMTP id s8-20020a170902ea0800b001b6bced1dd6mr2268085plg.35.1688141779370; Fri, 30 Jun 2023 09:16:19 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y17-20020a170902b49100b001b54d064a4bsm10913756plr.259.2023.06.30.09.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 09:16:19 -0700 (PDT) Date: Fri, 30 Jun 2023 09:16:16 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Xueming Li <xuemingl@nvidia.com> Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Kinsella Ray <mdr@ashroe.eu> Subject: Re: [dpdk-dev] [PATCH v1] eal: update all buses default scan mode Message-ID: <20230630091616.4df6c0f9@hermes.local> In-Reply-To: <20210328131222.16584-1-xuemingl@nvidia.com> References: <20210316124520.19726-1-xuemingl@nvidia.com> <20210328131222.16584-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sun, 28 Mar 2021 21:12:22 +0800 Xueming Li <xuemingl@nvidia.com> wrote: > When parsing EAL allowed or blocked device arguments, only device bus > being parsed got default scan mode updated. If the devargs was vdev, PCI > bus default scan mode not touched, all PCI bus devices will got probed > even none appear in allowed list. > > This patch update all buses default scan mode when parsing first > devargs. > > Signed-off-by: Xueming Li <xuemingl@nvidia.com> Looking back at this old patch, and wondering why it never got applied. Probably because it wasn't clear the exact problem. It does raise the issue that scan_mode is currently a property of the bus, not global. This patch would cause setting of allowed list for PCI to also impact other bus types. That doesn't follow current practice. If you want to resubmit, make it per bus.