From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FD042D99; Fri, 30 Jun 2023 20:14:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E155410FC; Fri, 30 Jun 2023 20:14:35 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 832EF40EDB for ; Fri, 30 Jun 2023 20:14:34 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1b7e6512973so15522495ad.3 for ; Fri, 30 Jun 2023 11:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688148873; x=1690740873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=U3Dv65dnf+adCxHT+TA0LLwyg89DYos7czf4C3/AC+k=; b=VpSEug11n/TFQZMxlX9hcevNVPwlGb9Rw7z0JQlIe3hl7ss/+CbOOziwUN6nU1Dl/R i9YL9i3KjE8NXXDPZg9q2dKpNuh+2Ezj8HUWnk+OjJ13pyzPS6d0tp0SNF8rabmBXgJQ Oanxgx5L4p3Nfn4djTO3YnozqdIL4Wd/fWW2BbthguhAwc2CO4zzWb9fVEXaIDntFLbr lUmZYrfsBv14L5HQBgjz+UNbp8JKsMkLWw/E/Qup1gG2++T4WG5PzwLrr3hEqsQ2kCfX ag2T+37k9YHrOGgTKxIbCWNvbvhYW/6IH71hhr84zFbkokMCHHluVEu3NYEwZBgVE4IJ PvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688148873; x=1690740873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U3Dv65dnf+adCxHT+TA0LLwyg89DYos7czf4C3/AC+k=; b=bUn1XVkLDCNdWv7IDjw6zjF3ampweNSuh7jTAeIqIrotE2tqAnnLWNSudmaVv3b+nB jmLTWyPaDHX1Y5rIJ+myBi27iLmCgitbCJ7tjYB8JLyLWrzxRk1lTgzramP2J0K7xXjD HBYBiB+8qeLux4uF0NPiseWzZV+y8ssKmW5oGXVNasGmEuE6t9V6TYZeJh23gArdyent e05n8/yRQQhiA1HCI2+6cshpTWHDbr+eXqGeq6G+484JgLalYWLaY+pt7usD6/a4YUFT J9h9xBr1l4clILvtjqL3mtIGhQj58XDtn3x1ghiwAZIWrlpMdYjBEH1yhw9AyikNyUgN ItqA== X-Gm-Message-State: ABy/qLZrO7qx6Df+66umZE+o/DI//Oane5i9j1QIJACfM5ksZUcYnunu 9KLA8kFACavmQJ4Qr6bxGfCrfw== X-Google-Smtp-Source: APBJJlGrh0rYqQaAGC1Lv2NF72wSkvwMjkEsTi01Q3tw0piVBElWbM0XGQDUSyobR9q1VPaF8/do6A== X-Received: by 2002:a17:903:230d:b0:1b8:7bd2:f77d with SMTP id d13-20020a170903230d00b001b87bd2f77dmr964142plh.64.1688148873689; Fri, 30 Jun 2023 11:14:33 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x10-20020a170902820a00b001b564563f32sm11001037pln.186.2023.06.30.11.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 11:14:33 -0700 (PDT) Date: Fri, 30 Jun 2023 11:14:31 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" , jianjay.zhou@huawei.com Cc: , , , , , , , , , Subject: Re: [dpdk-dev] [PATCH 08/10] crypto/virtio: fix return values check error Message-ID: <20230630111431.5c983063@hermes.local> In-Reply-To: <1618839289-33224-9-git-send-email-humin29@huawei.com> References: <1618839289-33224-1-git-send-email-humin29@huawei.com> <1618839289-33224-9-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 19 Apr 2021 21:34:47 +0800 "Min Hu (Connor)" wrote: > From: HongBo Zheng > > In virtio_crypto_pkt_tx_burst, we check the return values of > virtqueue_crypto_enqueue_xmit, which may returns -ENOSPC/-EMSGSIZE, > but we only check ENOSPC/EMSGSIZE, and cause the result of checks > is always false. > > This patch fix this problem. > > Fixes: 82adb12a1fce ("crypto/virtio: support burst enqueue/dequeue") > Cc: stable@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) This patch looks correct. Acked-by: Stephen Hemminger