* [PATCH v1] crypto/qat: fix struct alignment
@ 2023-06-30 11:30 Brian Dooley
2023-06-30 21:19 ` Power, Ciara
0 siblings, 1 reply; 3+ messages in thread
From: Brian Dooley @ 2023-06-30 11:30 UTC (permalink / raw)
To: Kai Ji; +Cc: dev, gakhil, Brian Dooley
The qat_sym_session struct variable alignment was causing a segfault.
AES expansion keys require 16-byte alignment. Added __rte_aligned to
the expansion keys.
Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations")
Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
drivers/crypto/qat/qat_sym_session.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_session.h b/drivers/crypto/qat/qat_sym_session.h
index 68cf3eaaf4..674a62ee12 100644
--- a/drivers/crypto/qat/qat_sym_session.h
+++ b/drivers/crypto/qat/qat_sym_session.h
@@ -142,10 +142,10 @@ struct qat_sym_session {
qat_sym_build_request_t build_request[2];
#ifndef RTE_QAT_OPENSSL
IMB_MGR *mb_mgr;
-#endif
- uint64_t expkey[4*15];
- uint32_t dust[4*15];
+ uint64_t expkey[4*15] __rte_aligned(16);
+ uint32_t dust[4*15] __rte_aligned(16);
uint8_t docsis_key_len;
+#endif
};
int
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] crypto/qat: fix struct alignment
2023-06-30 11:30 [PATCH v1] crypto/qat: fix struct alignment Brian Dooley
@ 2023-06-30 21:19 ` Power, Ciara
2023-07-03 14:15 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Power, Ciara @ 2023-06-30 21:19 UTC (permalink / raw)
To: Dooley, Brian, Ji, Kai; +Cc: dev, gakhil, Dooley, Brian
> -----Original Message-----
> From: Brian Dooley <brian.dooley@intel.com>
> Sent: Friday 30 June 2023 12:31
> To: Ji, Kai <kai.ji@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian
> <brian.dooley@intel.com>
> Subject: [PATCH v1] crypto/qat: fix struct alignment
>
> The qat_sym_session struct variable alignment was causing a segfault.
> AES expansion keys require 16-byte alignment. Added __rte_aligned to the
> expansion keys.
>
> Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations")
>
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> ---
Acked-by: Ciara Power <ciara.power@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] crypto/qat: fix struct alignment
2023-06-30 21:19 ` Power, Ciara
@ 2023-07-03 14:15 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2023-07-03 14:15 UTC (permalink / raw)
To: Power, Ciara, Dooley, Brian, Ji, Kai; +Cc: dev, Dooley, Brian
> > Subject: [PATCH v1] crypto/qat: fix struct alignment
> >
> > The qat_sym_session struct variable alignment was causing a segfault.
> > AES expansion keys require 16-byte alignment. Added __rte_aligned to the
> > expansion keys.
> >
> > Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations")
> >
> > Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> > ---
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-03 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 11:30 [PATCH v1] crypto/qat: fix struct alignment Brian Dooley
2023-06-30 21:19 ` Power, Ciara
2023-07-03 14:15 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).