From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Tianli Lai <laitianli@tom.com>, dev@dpdk.org
Subject: Re: [PATCH] mempool: fix rte primary program coredump
Date: Fri, 30 Jun 2023 14:36:46 -0700 [thread overview]
Message-ID: <20230630143646.36cbfed6@hermes.local> (raw)
In-Reply-To: <YfJuwGdRxi7QS+CG@platinum>
On Thu, 27 Jan 2022 11:06:56 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:
> >
> > this array in primary program is different with secondary program.
> > so when secondary program call rte_pktmbuf_pool_create_by_ops() with
> > mempool name “ring_mp_mc”, but the primary program use "bucket" type
> > to alloc rte_mbuf.
> >
> > so sort this array both primary program and secondary program when init
> > memzone.
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
>
> I think it is the same problem than the one described here:
> http://inbox.dpdk.org/dev/1583114253-15345-1-git-send-email-xiangxia.m.yue@gmail.com/#r
>
> To summarize what is said in the thread, sorting ops look dangerous because it
> changes the index during the lifetime of the application. A new proposal was
> made to use a shared memory to ensure the indexes are the same in primary and
> secondaries, but it requires some changes in EAL to have init callbacks at a
> specific place.
>
> I have a draft patchset that may fix this issue by using the vdev infrastructure
> instead of a specific init, but it is not heavily tested. I can send it here as
> a RFC if you want to try it.
>
> One thing that is not clear to me is how do you trigger this issue? Why the
> mempool ops are not loaded in the same order in primary and secondary?
>
> Thanks,
> Olivier
Agree with Olivier, hard coded sort is not the best way to fix this.
Some work is needed to address either the ordering or communicate the list from primary/secondary
prev parent reply other threads:[~2023-06-30 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 15:57 Tianli Lai
2021-11-10 16:00 ` David Marchand
2021-11-10 16:07 ` laitianli
2021-11-10 17:15 ` Jerin Jacob
2022-01-27 10:06 ` Olivier Matz
2023-06-30 21:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630143646.36cbfed6@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=laitianli@tom.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).