* [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD
@ 2023-06-26 14:06 Mingxia Liu
2023-06-30 9:08 ` Zhang, Qi Z
2023-06-30 18:51 ` [PATCH v2] net/idpf: refine vport parameter string Mingxia Liu
0 siblings, 2 replies; 5+ messages in thread
From: Mingxia Liu @ 2023-06-26 14:06 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, beilei.xing, Mingxia Liu
This patch refines 'IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
drivers/net/idpf/idpf_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index 3e66898aaf..34ca5909f1 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map);
RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci");
RTE_PMD_REGISTER_PARAM_STRING(net_idpf,
- IDPF_TX_SINGLE_Q "=<0|1> "
- IDPF_RX_SINGLE_Q "=<0|1> "
- IDPF_VPORT "=[vport_set0,[vport_set1],...]");
+ IDPF_TX_SINGLE_Q "=<0|1> "
+ IDPF_RX_SINGLE_Q "=<0|1> "
+ IDPF_VPORT "=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]");
RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE);
RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE);
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD
2023-06-26 14:06 [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Mingxia Liu
@ 2023-06-30 9:08 ` Zhang, Qi Z
2023-06-30 10:47 ` Liu, Mingxia
2023-06-30 18:51 ` [PATCH v2] net/idpf: refine vport parameter string Mingxia Liu
1 sibling, 1 reply; 5+ messages in thread
From: Zhang, Qi Z @ 2023-06-30 9:08 UTC (permalink / raw)
To: Liu, Mingxia, dev; +Cc: Wu, Jingjing, Xing, Beilei, Liu, Mingxia
> -----Original Message-----
> From: Mingxia Liu <mingxia.liu@intel.com>
> Sent: Monday, June 26, 2023 10:06 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Liu, Mingxia <mingxia.liu@intel.com>
> Subject: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF
> PMD
No need to mention the PMD in the title as its duplicate with the prefix.
How about
net/idpf: refine vport parameter string
>
> This patch refines 'IDPF_VPORT' param string in
> 'RTE_PMD_REGISTER_PARAM_STRING'.
>
> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> ---
> drivers/net/idpf/idpf_ethdev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
> index 3e66898aaf..34ca5909f1 100644
> --- a/drivers/net/idpf/idpf_ethdev.c
> +++ b/drivers/net/idpf/idpf_ethdev.c
> @@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map);
> RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci");
> RTE_PMD_REGISTER_PARAM_STRING(net_idpf,
> - IDPF_TX_SINGLE_Q "=<0|1> "
> - IDPF_RX_SINGLE_Q "=<0|1> "
> - IDPF_VPORT "=[vport_set0,[vport_set1],...]");
> + IDPF_TX_SINGLE_Q "=<0|1> "
> + IDPF_RX_SINGLE_Q "=<0|1> "
> + IDPF_VPORT
> +"=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]");
Better to use "<>" to wrap a symbol
How about " [<begin>[-<end>][,<begin >[-<end>]][, ... ]]"?
>
> RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE);
> RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD
2023-06-30 9:08 ` Zhang, Qi Z
@ 2023-06-30 10:47 ` Liu, Mingxia
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Mingxia @ 2023-06-30 10:47 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: Wu, Jingjing, Xing, Beilei
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Friday, June 30, 2023 5:08 PM
> To: Liu, Mingxia <mingxia.liu@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Liu, Mingxia <mingxia.liu@intel.com>
> Subject: RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of
> IDPF PMD
>
>
>
> > -----Original Message-----
> > From: Mingxia Liu <mingxia.liu@intel.com>
> > Sent: Monday, June 26, 2023 10:06 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Liu, Mingxia <mingxia.liu@intel.com>
> > Subject: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of
> > IDPF PMD
>
> No need to mention the PMD in the title as its duplicate with the prefix.
>
> How about
>
> net/idpf: refine vport parameter string
>
> >
> > This patch refines 'IDPF_VPORT' param string in
> > 'RTE_PMD_REGISTER_PARAM_STRING'.
> >
> > Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> > ---
> > drivers/net/idpf/idpf_ethdev.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/idpf/idpf_ethdev.c
> > b/drivers/net/idpf/idpf_ethdev.c index 3e66898aaf..34ca5909f1 100644
> > --- a/drivers/net/idpf/idpf_ethdev.c
> > +++ b/drivers/net/idpf/idpf_ethdev.c
> > @@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
> > RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map);
> > RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci");
> > RTE_PMD_REGISTER_PARAM_STRING(net_idpf,
> > - IDPF_TX_SINGLE_Q "=<0|1> "
> > - IDPF_RX_SINGLE_Q "=<0|1> "
> > - IDPF_VPORT "=[vport_set0,[vport_set1],...]");
> > + IDPF_TX_SINGLE_Q "=<0|1> "
> > + IDPF_RX_SINGLE_Q "=<0|1> "
> > + IDPF_VPORT
> > +"=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]");
>
> Better to use "<>" to wrap a symbol
> How about " [<begin>[-<end>][,<begin >[-<end>]][, ... ]]"?
>
[Liu, Mingxia] Thanks, new patch has been sent.
> >
> > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE);
> > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE);
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] net/idpf: refine vport parameter string
2023-06-26 14:06 [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Mingxia Liu
2023-06-30 9:08 ` Zhang, Qi Z
@ 2023-06-30 18:51 ` Mingxia Liu
2023-07-03 2:25 ` Zhang, Qi Z
1 sibling, 1 reply; 5+ messages in thread
From: Mingxia Liu @ 2023-06-30 18:51 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, beilei.xing, Mingxia Liu
This patch refines 'IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
drivers/net/idpf/idpf_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index 6d9a53c94c..75b4f301ab 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -1472,9 +1472,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map);
RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci");
RTE_PMD_REGISTER_PARAM_STRING(net_idpf,
- IDPF_TX_SINGLE_Q "=<0|1> "
- IDPF_RX_SINGLE_Q "=<0|1> "
- IDPF_VPORT "=[vport_set0,[vport_set1],...]");
+ IDPF_TX_SINGLE_Q "=<0|1> "
+ IDPF_RX_SINGLE_Q "=<0|1> "
+ IDPF_VPORT "=[<begin>[-<end>][,<begin >[-<end>]][, ... ]]");
RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE);
RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE);
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] net/idpf: refine vport parameter string
2023-06-30 18:51 ` [PATCH v2] net/idpf: refine vport parameter string Mingxia Liu
@ 2023-07-03 2:25 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2023-07-03 2:25 UTC (permalink / raw)
To: Liu, Mingxia, dev; +Cc: Wu, Jingjing, Xing, Beilei, Liu, Mingxia
> -----Original Message-----
> From: Mingxia Liu <mingxia.liu@intel.com>
> Sent: Saturday, July 1, 2023 2:52 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Liu, Mingxia <mingxia.liu@intel.com>
> Subject: [PATCH v2] net/idpf: refine vport parameter string
>
> This patch refines 'IDPF_VPORT' param string in
> 'RTE_PMD_REGISTER_PARAM_STRING'.
>
> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-03 2:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 14:06 [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Mingxia Liu
2023-06-30 9:08 ` Zhang, Qi Z
2023-06-30 10:47 ` Liu, Mingxia
2023-06-30 18:51 ` [PATCH v2] net/idpf: refine vport parameter string Mingxia Liu
2023-07-03 2:25 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).