From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3EC542DBC; Mon, 3 Jul 2023 05:03:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A21AA410DC; Mon, 3 Jul 2023 05:03:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1072240EF0 for ; Mon, 3 Jul 2023 05:03:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688353425; x=1719889425; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5ktIUZ0CwGaPCKjtZC3JXxJZUmO745w0SIAleH0I1Ts=; b=TY/Kj58hx9xR/dAAeDlyDqBjHMoILGTze7eGYF8k845l/ux0iZfxrZHx mkNK8RB63W+I/HVI7TI4cHyrtmpFdjA2Q/7f/nbHyHjBXV3xcLc+LZ4An TKXXJCky+EJca0hc2rdJY7P+MQkE3j+pH22udkQdLSG3E2JLnFpnaHdGu RpeKkQsayeZ1qqhQOkG62Hu33o89Cu8g3Y4GVUu2knyNjQuK9AEhJIPYm RDwO+zc2/iQ3gXAKagXfzGCHbmDfKj2AJ93+5lWgbDL4NddGNCrLq/X8G xCnBY1S7G93h3D75JYV6S1nYuIuXY3Rn9avw01sh8yuyk2tyb/dFnpksr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="342367129" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="342367129" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 20:03:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="712420551" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="712420551" Received: from dpdk-mingxial-ice.sh.intel.com ([10.67.110.210]) by orsmga007.jf.intel.com with ESMTP; 02 Jul 2023 20:03:41 -0700 From: Mingxia Liu To: dev@dpdk.org Cc: jingjing.wu@intel.com, beilei.xing@intel.com, Mingxia Liu Subject: [PATCH v3] net/idpf: refine dev_link_update function Date: Mon, 3 Jul 2023 11:22:17 +0000 Message-Id: <20230703112217.13930-1-mingxia.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230630185532.13343-1-mingxia.liu@intel.com> References: <20230630185532.13343-1-mingxia.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch refines dev_link_update() of IDPF PMD, optimizing the code style. Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 63 +++++++++++++++------------------- 1 file changed, 28 insertions(+), 35 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index fb59655555..4aa0a18cd8 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = { NULL }; +uint32_t idpf_supported_speeds[] = { + RTE_ETH_SPEED_NUM_NONE, + RTE_ETH_SPEED_NUM_10M, + RTE_ETH_SPEED_NUM_100M, + RTE_ETH_SPEED_NUM_1G, + RTE_ETH_SPEED_NUM_2_5G, + RTE_ETH_SPEED_NUM_5G, + RTE_ETH_SPEED_NUM_10G, + RTE_ETH_SPEED_NUM_20G, + RTE_ETH_SPEED_NUM_25G, + RTE_ETH_SPEED_NUM_40G, + RTE_ETH_SPEED_NUM_50G, + RTE_ETH_SPEED_NUM_56G, + RTE_ETH_SPEED_NUM_100G, + RTE_ETH_SPEED_NUM_200G +}; + static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP] = RTE_ETH_RSS_NONFRAG_IPV4_UDP, @@ -110,47 +127,23 @@ idpf_dev_link_update(struct rte_eth_dev *dev, { struct idpf_vport *vport = dev->data->dev_private; struct rte_eth_link new_link; + unsigned int i; memset(&new_link, 0, sizeof(new_link)); - switch (vport->link_speed) { - case RTE_ETH_SPEED_NUM_10M: - new_link.link_speed = RTE_ETH_SPEED_NUM_10M; - break; - case RTE_ETH_SPEED_NUM_100M: - new_link.link_speed = RTE_ETH_SPEED_NUM_100M; - break; - case RTE_ETH_SPEED_NUM_1G: - new_link.link_speed = RTE_ETH_SPEED_NUM_1G; - break; - case RTE_ETH_SPEED_NUM_10G: - new_link.link_speed = RTE_ETH_SPEED_NUM_10G; - break; - case RTE_ETH_SPEED_NUM_20G: - new_link.link_speed = RTE_ETH_SPEED_NUM_20G; - break; - case RTE_ETH_SPEED_NUM_25G: - new_link.link_speed = RTE_ETH_SPEED_NUM_25G; - break; - case RTE_ETH_SPEED_NUM_40G: - new_link.link_speed = RTE_ETH_SPEED_NUM_40G; - break; - case RTE_ETH_SPEED_NUM_50G: - new_link.link_speed = RTE_ETH_SPEED_NUM_50G; - break; - case RTE_ETH_SPEED_NUM_100G: - new_link.link_speed = RTE_ETH_SPEED_NUM_100G; - break; - case RTE_ETH_SPEED_NUM_200G: - new_link.link_speed = RTE_ETH_SPEED_NUM_200G; - break; - default: - new_link.link_speed = RTE_ETH_SPEED_NUM_NONE; + /* initialize with default value */ + new_link.link_speed = vport->link_up ? RTE_ETH_SPEED_NUM_UNKNOWN : RTE_ETH_SPEED_NUM_NONE; + + /* update in case a match */ + for (i = 0; i < RTE_DIM(idpf_supported_speeds); i++) { + if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; + break; + } } new_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX; - new_link.link_status = vport->link_up ? RTE_ETH_LINK_UP : - RTE_ETH_LINK_DOWN; + new_link.link_status = vport->link_up ? RTE_ETH_LINK_UP : RTE_ETH_LINK_DOWN; new_link.link_autoneg = (dev->data->dev_conf.link_speeds & RTE_ETH_LINK_SPEED_FIXED) ? RTE_ETH_LINK_FIXED : RTE_ETH_LINK_AUTONEG; -- 2.34.1