From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C58A142DC6; Mon, 3 Jul 2023 23:38:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A46E40151; Mon, 3 Jul 2023 23:38:03 +0200 (CEST) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by mails.dpdk.org (Postfix) with ESMTP id 5A1C9400EF for <dev@dpdk.org>; Mon, 3 Jul 2023 23:38:02 +0200 (CEST) Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-558a79941c6so3029437eaf.3 for <dev@dpdk.org>; Mon, 03 Jul 2023 14:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688420281; x=1691012281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ME0H/QZOAHF9iCeSSgp6TLuo8o/jOFDF6q5/JkC3uy4=; b=hElRz7AJAmvREI76R2dcltidgq41JGPPxdPfms6BPWwIIi4XeeQD4zv3DpA07reJdL qxSSWGgobioWgss+YsT0qCZiyxweOr6TG4aSNTSkZ+eM1BzynyRDQQMld6/HRV3DEkd5 qsOrELQ37F7EYa5+B1UdmWzeKaMXTP1YuUKU4ySsweck36QYR6NKusufTIByku4Gv8vC oIvnDSDr8txl3O4/kPGjqA6kWw0iQPmZGtNpepQ8tSVukrCDnq3xlmzPHhETdFd5YR4u upH5vk2aM6bQgHOM0twjbpMak2dN3Bg9oP0iZGBQ2u3xhw/+EkHa/btW0W4HHSd/eNIP or7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688420281; x=1691012281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ME0H/QZOAHF9iCeSSgp6TLuo8o/jOFDF6q5/JkC3uy4=; b=WsbNZC0TqzMy/ab8p0crXFjM9E0FEN4XQPspp4xUi8sQIgssz0bF17jUDCNfMtjH0w l+EdO2xhmM0H3TQZIEG0Y3yfPNPIzUqXI+HAmmSuZCqToeWRS8lRPdThJWeCOu48y8Ge A/JSb7bP/+wPsMGiaKl7sZRXfpU7s+fuZvyufbP7/+3NWHKn9l3OUb9GlD0yeUrvdxaM TmTKAfqLIDIoZ7M3gdpZ6NMAMZh3/6oB62fgF/amExJG2EgLdrDUlaOK1XFnfLT0HMzb KjVEDEb9xpRt9I+Qd5X7UbfhBc8N+O0L4qtmlaeJd4hQ6TWX2zveaSIllSZO/ky6MiuJ oItg== X-Gm-Message-State: AC+VfDyVU7iY39tSRk53tjySrskxBJHK5z/LZSB3nGIZ8O8BUhPIWyXx SP78vUWPBAgHni7JMYFRK778yQ== X-Google-Smtp-Source: ACHHUZ5UaoiMMyYZlAlaNrLVWLb++Py29a5KDW8uAdBnblNCkbO+/bpa7BwBHy+C10+J3RY9pSAvfQ== X-Received: by 2002:a05:6808:13ca:b0:3a3:6acc:2306 with SMTP id d10-20020a05680813ca00b003a36acc2306mr12495359oiw.55.1688420281502; Mon, 03 Jul 2023 14:38:01 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g7-20020a62e307000000b0065016fffc81sm8594786pfh.216.2023.07.03.14.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 14:38:01 -0700 (PDT) Date: Mon, 3 Jul 2023 14:37:59 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: "Min Hu (Connor)" <humin29@huawei.com> Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH V1 0/2] examples/ethtool: fix MTU set and add MTU query Message-ID: <20230703143759.62012cda@hermes.local> In-Reply-To: <df30d28f-17e8-7e5b-e292-a8ea99f83dfc@huawei.com> References: <1619693609-28244-1-git-send-email-humin29@huawei.com> <df30d28f-17e8-7e5b-e292-a8ea99f83dfc@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 28 Jun 2021 11:23:12 +0800 "Min Hu (Connor)" <humin29@huawei.com> wrote: > Hi, all, > any comments? >=20 > =E5=9C=A8 2021/4/29 18:53, Min Hu (Connor) =E5=86=99=E9=81=93: > > From: Huisong Li <lihuisong@huawei.com> > >=20 > > This patchset fixes MTU data type when set MTU, and supports the query > > of MTU. > >=20 > > Huisong Li (2): > > examples/ethtool: fix data type of MTU > > examples/ethtool: support the query of MTU > >=20 > > examples/ethtool/ethtool-app/ethapp.c | 54 ++++++++++++++++++--------= -- > > examples/ethtool/lib/rte_ethtool.c | 16 ++++++++--- > > examples/ethtool/lib/rte_ethtool.h | 16 ++++++++++- > > 3 files changed, 63 insertions(+), 23 deletions(-) > > =20 There were several review comments. In patch 1, the comment was that strtoul will return unsigned long. Therefore new_mtu should be of type unsigned long, and check that is is less than UINT16_MAX. For the second patch, David's comment was that get and set should logically be separate functions. The overlap was poor design in original ethtool program, and lets not repeat that. Overall, not many people looked at this patch because the ethtool example is one of those "throw it over the wall and forget it" applications that originally came from Cisco, and has seen little interest since then.