From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AA2242DC5; Mon, 3 Jul 2023 20:22:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31BB440ED5; Mon, 3 Jul 2023 20:22:52 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id 3A195400EF for ; Mon, 3 Jul 2023 20:22:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YQOrfrQQUhyfDIF4I03e0uKrv+Sfy+EwOHbzM1Ie4V8rA9R9LRHRo8LRAAXTxQH7gjua5JARmC2nVZ+dZ9bB2plT+bMpS1K2YpslddwZG1qUDKlkvOaut0dONxMda9LNwpuceU62x0Bz/JLb/gvFNphLS+FHM0hFFcEDoNDriFSaliQ+1PZr9fY7sYwqV29dDae/+0TvvLofoifOiJSoygETA6s3XZmAr4leuuBeGBJe4RgGYwr03G6aHclzWOVo5qhmg6Nw9p8jLa4GIfTrYxdeEkZArQIdssjHlUbKohxr28zYQJFIe7Cw7iIN/ygTXmYdQImjAZXz5Si/4vMGqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvn8Ul22+0+W6RXFV1ezb1NGb7EoXP50WhoPWqPb40o=; b=J5yWpgt88dSmFYZItdk31NRf2pClMrZ9j+QLWTyYAUqXEL1DRMcocKE5iVGM6M/qd3a7C3h3v/QlpAlgkEbGofO+n7tTphXBO8ACh+UzQbQd5Lo5DC+27YJzkTeJBXkS+YxyZD3bX1HOreQFVQ8YToQkxTb7QD5VQIS5FCv4UY4y9dTokzXnc8izoRcYi5NbcIYIY0Mymi+Ej4EYwnqnla+T/CPw2tcry965mUJgfKfz2KYBNJyKcU5b6ugZTN6/3xx8jhZS0RxDUi5EYYY+WgrD+g64tZqxce2bqJeBq3mnf6X3cgoMqgvulN6sSlM47Bpxgj5BIa6RAseaJowBrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvn8Ul22+0+W6RXFV1ezb1NGb7EoXP50WhoPWqPb40o=; b=ni9cWKFxG5fN0qBqMTQa35qE9NZb4WKyqxX/rV1yfGAVJMFzNbx+fBzn2hi578GgliNS2ABtDgG+1BNORAOzu6PPaGkNAc4PWOLl/Y8s4NGRPWDldqaQLNvcxrWW/0EEitsK2T4W9pLAkYJQHenWx9p5xtQBJrXWXO2iqQmm8s0088010oEuNbvS+Bdm9vggXedULdFY0LI/AGPG/uuWHd0/wxDU7dfBluyMdyRQeaGzenxICpR44o8+WmL5lrB1JWSyT6CnMaRf4qXOMjjSHqe5edEz0ZaY32aIluJt+Hx32JTa5RlWqfnpyAIwgwyf72EHxhqJACBMpQtZyoMttQ== Received: from SJ0PR03CA0362.namprd03.prod.outlook.com (2603:10b6:a03:3a1::7) by SA1PR12MB5672.namprd12.prod.outlook.com (2603:10b6:806:23c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 18:22:48 +0000 Received: from DM6NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:3a1:cafe::65) by SJ0PR03CA0362.outlook.office365.com (2603:10b6:a03:3a1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 18:22:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT089.mail.protection.outlook.com (10.13.173.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.44 via Frontend Transport; Mon, 3 Jul 2023 18:22:48 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 3 Jul 2023 11:22:37 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 3 Jul 2023 11:22:36 -0700 Received: from nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Mon, 3 Jul 2023 11:22:34 -0700 From: Maayan Kashani To: CC: , , , "Matan Azrad" , Viacheslav Ovsiienko , Suanming Mou Subject: [PATCH] net/mlx5: fix non-ip packets are not delivered when RSS hash type ESP is used. Date: Mon, 3 Jul 2023 21:21:14 +0300 Message-ID: <20230703182123.210117-1-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT089:EE_|SA1PR12MB5672:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c222512-5edf-4931-90cb-08db7bf28129 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ljtf0ZDPEnckHFfYgr8p7E55e6IB3Mkhi6ERJ4ZsYlX7p6qsTXwmMG0eYfwcDD6OYwQlNOeJdrdHUDEuRy9XEHs7PAvl14ahjFjN/3HBg7YcTNrgWRkqi9F4qPavSWGCeND7aQav2Y/ih9cjDYkwzH27+c7sZNCofO8JMkaUrCVEh6A+p7S3Ep4Opbk4fM1+n810nupgJsCBnehRDj2shQPVccLRNXpC+paJlijpcLCp2FRAaglx0S9Ovv0Ox9netVaPf26sIFRGhbz2fk4N50eR6FNt2LUBIhPjFdls+gC5UmiuHmm1oTPOrdVlTJj4H7PtNLv3mhF8CP5nGBDFtXqnC2rhJ2kjWFBTzeEPW5ejdu7ROhHZMN6w/RWnoAiOsCxHMr7ZhEIhcqM2CuKHZPEcRZbYJtKrmCnqbHEtG8S/cTsC3tHVdP6m86SjEfInhMgaGpSZjZsdTPYbSOhbJOphuCg09PcwqyyDrf50soUXvihahxKuxqrn7nwqy1ZSfMXReq4+fAgxO/dWmSJIiKpSrj6TPAbwAHB3eZkvRlQ9lGtillrpRLCDUPNQp5X8d6rZvjRW7GSw8hkgjiRejjIZVbk4csm4mLQ72FvbOvm7tGgYBUrMofYx3SLzDIfhBk/Tn88k4lsJQB9C6NTcjXKpUCjjc1Fhj8meZLH4W+nRF5yIfGlWBKBieoaGktVoUCaG8+85OdFoPVTWHSSr2WFZTBKNFJ+V1zG9FSg36UFpwmVv2FOD74IBS4YSaCUG X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(40470700004)(46966006)(36840700001)(336012)(40460700003)(41300700001)(86362001)(7696005)(82310400005)(6666004)(2616005)(6286002)(7636003)(82740400003)(107886003)(356005)(83380400001)(186003)(1076003)(26005)(426003)(47076005)(36860700001)(40480700001)(55016003)(54906003)(478600001)(2906002)(316002)(36756003)(70206006)(70586007)(6916009)(4326008)(8936002)(8676002)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 18:22:48.0937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c222512-5edf-4931-90cb-08db7bf28129 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5672 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Non-ip packets such as ARP or LACP are not delivered if you use RTE flow rule with empty pattern and rss action with specific combination of RSS hash types: "ipv4-tcp ipv4-udp ipv4-other ipv6-tcp ipv6-udp ipv6-other esp". The stack which used for RSS expansion was overflowed and trashed rss expanstion data(buf->entry[MLX5_RSS_EXP_ELT_N]). Use bigger stack size instead. And add relevant ASSERT for the future. Signed-off-by: Maayan Kashani Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index cf83db7b60..41e298855b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -374,7 +374,7 @@ mlx5_flow_expand_rss_skip_explicit(const struct mlx5_flow_expand_node graph[], return next; } -#define MLX5_RSS_EXP_ELT_N 16 +#define MLX5_RSS_EXP_ELT_N 32 /** * Expand RSS flows into several possible flows according to the RSS hash @@ -539,6 +539,7 @@ mlx5_flow_expand_rss(struct mlx5_flow_expand_rss *buf, size_t size, if (lsize > size) return -EINVAL; n = elt * sizeof(*item); + MLX5_ASSERT((buf->entries) < MLX5_RSS_EXP_ELT_N); buf->entry[buf->entries].priority = stack_pos + 1 + missed; buf->entry[buf->entries].pattern = addr; -- 2.25.1