DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rma Ma <rma.ma@jaguarmicro.com>
Cc: dpdk-dev <dev@dpdk.org>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [PATCH v2] vhost: add notify reply ops to fix message deadlock
Date: Mon, 3 Jul 2023 19:51:34 -0700	[thread overview]
Message-ID: <20230703195134.689ec65a@hermes.local> (raw)
In-Reply-To: <20230704023228.24879-1-rma.ma@jaguarmicro.com>

On Tue,  4 Jul 2023 10:32:28 +0800
Rma Ma <rma.ma@jaguarmicro.com> wrote:

> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 901a80bbaa..aa61992939 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -3365,13 +3365,14 @@ rte_vhost_backend_config_change(int vid, bool need_reply)
>  static int vhost_user_backend_set_vring_host_notifier(struct virtio_net *dev,
>  						    int index, int fd,
>  						    uint64_t offset,
> -						    uint64_t size)
> +						    uint64_t size,
> +							bool need_reply)
>  {

I think indentation should match existing code here.

  reply	other threads:[~2023-07-04  2:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  2:32 Rma Ma
2023-07-04  2:51 ` Stephen Hemminger [this message]
2023-07-04  2:51 ` [PATCH v3] " Rma Ma
2023-07-11  9:25   ` 回复: " Rma Ma
2023-07-11 13:25     ` Maxime Coquelin
2023-07-12  2:17       ` 回复: " Rma Ma
2023-07-12  8:06         ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703195134.689ec65a@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=rma.ma@jaguarmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).