From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E552342DC7; Tue, 4 Jul 2023 04:51:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 754E240F18; Tue, 4 Jul 2023 04:51:39 +0200 (CEST) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by mails.dpdk.org (Postfix) with ESMTP id 3FDEE40E03 for ; Tue, 4 Jul 2023 04:51:37 +0200 (CEST) Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5661e8f4c45so1168987eaf.1 for ; Mon, 03 Jul 2023 19:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688439096; x=1691031096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1bh6OoJS6xx5PvNzRG73sc1xcquzLxqQaz5ZLMh7zEA=; b=xqDTNtinEVz1lUg+3bT/RJ7NVOvKfCP/Eoymk5NQLf+dgHBWseqjO8Xq/rHF3ZhS+y an0MSJf8lmToa6XdPlAChRhQRjkoBLVWyJXh4RDYTKC8WCCWf8mkd5oPTu+wuZMQtapx kfP9OwiP9Td0NGfNWAQEY591d8NruRiPWfN8f69H0TuvkKFMmU24xclWvLr4wxlsr0DG BR5JKV94roiZnRfO1nty6YgNjuWYVTFKXVxydzNxt/AODCaE5k/3LCtO8l4fL6UZ2azj KNjKZPNKyDwBuxqQETnGHI/9MC4H5emcYqjaJ9MI3tCF+cq9lVZHi6iTtQESZuj92QV8 DScg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688439096; x=1691031096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1bh6OoJS6xx5PvNzRG73sc1xcquzLxqQaz5ZLMh7zEA=; b=SNhR1U7MFTDX3bnMTrRVn9hwTIPikUIEKgAO8yfAq9Uvp8UFw9Iv5XPmViquxEF9gb N4tIEiPXxP4yLNBt/uyXWAI/Lkd5hh+F+dbQIaCEMdy/jDd2MFBEFLPtIdMZwBPScrn8 M/nryhWS93veaL1nkVDsK/ldMO1tbtANOeRlc0YBCA7xgarQQ15jxkotFYJ/etD3S8/9 FMTqxmgrjc4OHZMKkFpUw7hVhaTnuAUD1Ce2em2qALB6HLrQYv+zRxoEX9x5PlzCaq4b TApidzsgHBlz+bxOjTWc+rQ23hECVxDV8eXVn/dyP9ItX0VulkuJpDfApk+0BlO1MlvV cupA== X-Gm-Message-State: ABy/qLZfPuFI1vqvlAqaMzON5bovS4G2S5r2jc4aC3TDyVWOkdJwC1nh QurMBPck2CgJp4pVEPDZoojGqg== X-Google-Smtp-Source: APBJJlGbWPV8Su+OLZNeoQZu3m7/br0ievukMcLT8DxmGGDetAVZuMZ9ekrq+nME2rxrfWs8Urjleg== X-Received: by 2002:a05:6359:617:b0:133:ec3:1079 with SMTP id eh23-20020a056359061700b001330ec31079mr8265505rwb.10.1688439096379; Mon, 03 Jul 2023 19:51:36 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id n2-20020a170902968200b001b7cbc5871csm11170858plp.53.2023.07.03.19.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 19:51:36 -0700 (PDT) Date: Mon, 3 Jul 2023 19:51:34 -0700 From: Stephen Hemminger To: Rma Ma Cc: dpdk-dev , Maxime Coquelin , Chenbo Xia Subject: Re: [PATCH v2] vhost: add notify reply ops to fix message deadlock Message-ID: <20230703195134.689ec65a@hermes.local> In-Reply-To: <20230704023228.24879-1-rma.ma@jaguarmicro.com> References: <20230704023228.24879-1-rma.ma@jaguarmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 4 Jul 2023 10:32:28 +0800 Rma Ma wrote: > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 901a80bbaa..aa61992939 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -3365,13 +3365,14 @@ rte_vhost_backend_config_change(int vid, bool need_reply) > static int vhost_user_backend_set_vring_host_notifier(struct virtio_net *dev, > int index, int fd, > uint64_t offset, > - uint64_t size) > + uint64_t size, > + bool need_reply) > { I think indentation should match existing code here.