From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 886C642D60; Tue, 4 Jul 2023 04:56:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5940640F18; Tue, 4 Jul 2023 04:56:33 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id C774640E03 for ; Tue, 4 Jul 2023 04:56:31 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-53fa455cd94so2529796a12.2 for ; Mon, 03 Jul 2023 19:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688439391; x=1691031391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Y0i/5x/ESmbe2u7wneCL+ormZW5/cWPnC15x3RJzCho=; b=4vYbzhnW9MfyYYIBQQTVvGlgTtcd2BVhq+kNDsSWFJB8TvbPuL0M2TXg5JiNrELeZ+ O+QWevhilMXSb+aPQJ4HoLT8fz+qrceJ72eY5A+BTv35BnCCyaWXOsdLY6mWL1xwY/I9 K9pr7mB4CHYvdzPw8DhiLWjet9jlLVU49aeedq0Q3YGfDYiM8XcXxCQSRf26PgrRluxr WTzpJvccdE49LAeoA3OVVP8Yv4PFVhybbhQC9fe6TZbhI6S6DL4xBd5XoErIjmTRXo7Y zYklLSeN21B584wpU8eTNCvVch+2bU/8KMq5YOEY5iaFmEX0RlX2fbGvXDPI7BMwdnve AMAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688439391; x=1691031391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y0i/5x/ESmbe2u7wneCL+ormZW5/cWPnC15x3RJzCho=; b=Xef/3IbJ54xLzPXyspHXoBvgyYb5TH/SshcGE/PxlWetUE7NgoGP4kgzX05mNQBMbJ 0mKgx9GBXIWf4OaLz9e9AMd8lVroPdw4wcBbYYXKG6sd/XeAn45TkX2GMoc378buNLdH O7WzN91arqDtO/bVVF3w4DNxkh5W39uMejR18z1Kd4s0aTWNQOCNq9vbgKRScv7YZqFC raegK/9wsQAIviDAx56XPU+BXV6y/sccPqLOF7A/owIZ99Ngdt8ohnpUfAUaeSTHIteU ZFDPTxcveAqPR/XVRQQcphI71wzLpVYzb9HWdQBqrhKqZHHmq4gnoVLOyYuLKxMKVgPt BRiQ== X-Gm-Message-State: ABy/qLZcWDAeeskpnzmdfCUux+Uzpli8J8FeZX2rJoEBq4w7lbWQ+njW ob1VxPOjmqZe6QskrJYlK9Rfr/m0LW1DLOQemxk= X-Google-Smtp-Source: APBJJlG9/jrrPsOTJ3R+nCmAeSrHxwonc8FlRcGu9i9fHtg+RWUw2nThbpCE3fIP69nUILfhf4S1PQ== X-Received: by 2002:a05:6a00:2d0d:b0:680:ddd6:7d8b with SMTP id fa13-20020a056a002d0d00b00680ddd67d8bmr12612891pfb.15.1688439390901; Mon, 03 Jul 2023 19:56:30 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x22-20020aa79196000000b00666b3706be6sm705368pfa.107.2023.07.03.19.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 19:56:30 -0700 (PDT) Date: Mon, 3 Jul 2023 19:56:29 -0700 From: Stephen Hemminger To: Stephen Coleman Cc: dev@dpdk.org, Ray Kinsella , Ferruh Yigit Subject: Re: kni: check abi version between kmod and lib Message-ID: <20230703195629.69b747dd@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 21 Apr 2022 12:38:26 +0800 Stephen Coleman wrote: > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: sometimes various fields contain garbage value, > sometimes it cause a kmod soft lockup. > > Some common distros ship their own rte_kni.ko, so this is likely to > happen. > > This patch add abi version checking between userland lib and kmod so > that: > > * if kmod ioctl got a wrong abi magic, it refuse to go on > * if userland lib, probed a wrong abi version via newly added ioctl, it > also refuse to go on > > Bugzilla ID: 998 > > Signed-off-by: youcai KNI is deprecated and scheduled for removal. Even though this fixes a bug, because it changes API/ABI it can't go in. Dropping the patch.