From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA0B542D60; Tue, 4 Jul 2023 05:04:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1D6240F18; Tue, 4 Jul 2023 05:04:56 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 9970240E03 for ; Tue, 4 Jul 2023 05:04:54 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b8033987baso30602305ad.0 for ; Mon, 03 Jul 2023 20:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688439893; x=1691031893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MVfdcYVGB9TvPpNzDvJXltjd5YZ3whxznWWBO1Zo12w=; b=HPl4GfjvkHnwc8Mr28jJlx/49ZIMXXzwlDDvGxGRFrgKaqLlocQkwnJKQ7IWR4zVfE JJx2C2BTbg4tQbrc3sHZ2mikUYy+ZfTqw4cETgubEoKh2Wno9Zs3nvEAQNuEhYz8pNvh wzb55ZBNLH1giJ2ckoSFA2y6TkI5n1cYrwQW0QogssbC50QGv88lQyVlSEfPPRj1a/A2 8rHmXft8l4HoCSaoK372EttbZyBwrUyuI7Yj3DTy8rMeSOc+sn08N3p6tXjCFKZyQ0XF q6oJdH3iRqm+ENNqlud8/6xlAZoXElEewWpKAsE83QziBgB4IqTcMCSPEMwM7+ek6dsG uleg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688439893; x=1691031893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MVfdcYVGB9TvPpNzDvJXltjd5YZ3whxznWWBO1Zo12w=; b=h8EbdkB+E6GhL9XAfl+TydlILp5yPYwvgSd/JOrKAqg3dS8/MBhK58PeQAVcD4Ajct jThUhjtkpvkNKkKTpfiIyXMv1H/MCoN/HzcFM8JC5xdW+vnHJero5RpI4Vq0bRTMU1y4 LeyuLZRi7Nf7of3zUpfjQeeL3TcTFZogJY650+mm1sVfm0uy2fwv/MWKQXWFIkQABJVz qdB3YyPGGlRXOW4Ti3gCF4PPQYX6nxScfwLe+dSRuVOjr4Q18Dq//aGnnnragQ7RAdiI q9Srzrw4e25Qm7y8sdPSLILDkTZoTN5gkRmKhgJtQ6ozjMm7LO0uQN02RngxR04PCEXI SIig== X-Gm-Message-State: AC+VfDz+2U94w8hQGUPXCGycg3cunxO3k6ge+p4IA18aJdrk8DUhn75R nZVsPd99d4LvdeQYAfglZpvBnw== X-Google-Smtp-Source: ACHHUZ4/iBtdO+KfzZ5zFiAMj8M8UlNCNwv26o1870QdK7PN1k1xSRePQokTKTU0YXUF3xMKj4T0BQ== X-Received: by 2002:a17:902:e84e:b0:1b7:de50:7d9c with SMTP id t14-20020a170902e84e00b001b7de507d9cmr27390405plg.15.1688439893610; Mon, 03 Jul 2023 20:04:53 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001b86f410341sm6403725plg.189.2023.07.03.20.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 20:04:53 -0700 (PDT) Date: Mon, 3 Jul 2023 20:04:51 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Ido Goshen , Ferruh Yigit , Juhamatti Kuusisaari , Cian Ferriter , Subject: Re: [PATCH v2 04/44] net/pcap: fix segment fault when parse devargs Message-ID: <20230703200451.3e6da0eb@hermes.local> In-Reply-To: <20230320092110.37295-5-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> <20230320092110.37295-5-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 Mar 2023 09:20:30 +0000 Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args with 'only keys'. > > Fixes: 4c173302c307 ("pcap: add new driver") > Fixes: 53bf48403409 ("net/pcap: capture only ingress packets from Rx iface") > Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") > Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger