From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A72E42DAB; Tue, 4 Jul 2023 18:01:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B7AD42D10; Tue, 4 Jul 2023 18:01:31 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 606E042BFE for ; Tue, 4 Jul 2023 18:01:29 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6687446eaccso4347935b3a.3 for ; Tue, 04 Jul 2023 09:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688486488; x=1691078488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=i9QdYwouDcpYVDGTla+U9MbD2V8YXXAruVYrGH9+Hxg=; b=i/Y3PNE3FNlKg9AAuIl5UmzWM3X2i5Ikvtuh4XLI7tfEweJX3eNVXlo53ceCsiCCI7 EB6OpKOvHm9ah+xmmjJGb9jgOrXtTM6O1oXE5jxzJgc8AMHW9ra+RZwRBYk2Yyu03nOf Dc73VBNLfjLm10Qu9XSQP5cztmuSbxyYigHM5p2fEilzK95ymPuw9dA3HmFsZASgA9Wi YzaOHpTT85YVQDbaHSBfvt+naKtYu28/4LG7b8HJ30T7k5XQU0bsiiUN1+vT880XOTw6 NpQjvmA6g0dWOdhzxjr1d/L7QzgUoVQSMzmsV0sEdD8WQ/cpefkkUmhx/2LybDPsEfZ3 l3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688486488; x=1691078488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i9QdYwouDcpYVDGTla+U9MbD2V8YXXAruVYrGH9+Hxg=; b=YqLO9pS5j7reTN8okyMGYLLvCzbyqBr3REGJKgjGvTPRrN3MBteQkipuNKenmyYOvb pQDHscUoaYcNglZGdqDdIsHYCc+aVER7QnlV/zWg6dF3IsX/szrOIqcESfK1slMVtIq/ 1zuq0uJv5ayMfnmdTUUIQG9YuV4wccz17tUb+B4HYFHMqL33PgNTDhK0ALl0Shh6TArN yPphLwWA7+jMnbsVaUjkqJtmxTAInyD4zCMmn2xuwyf23/U2w3qjHsIxs4xHxkichKbI TS+eQSqr+dCeo9JzbbD9XjuzolnMhWIsnp+W9I7Gd7IQ8oZlUs9yiZPfJobC47PBpztz sW6A== X-Gm-Message-State: ABy/qLbdJ7NVrwcYm2Qx+ZejeGiCt1v8mwf1F3BCr641BXxue+1YdK3f 6AuraLYkhxob9BooFQyJcnt/8g== X-Google-Smtp-Source: APBJJlEMErr4SAhmD2GD3Ibv3o4h6syg93f9H0OqI4hAfw+DzCmB4INZKVQ1LFTnM44bbUMK9TzxCg== X-Received: by 2002:a05:6a21:3389:b0:12e:5017:ad3a with SMTP id yy9-20020a056a21338900b0012e5017ad3amr10331419pzb.23.1688486488589; Tue, 04 Jul 2023 09:01:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id h20-20020aa786d4000000b00677af363905sm13650537pfo.59.2023.07.04.09.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 09:01:28 -0700 (PDT) Date: Tue, 4 Jul 2023 09:01:26 -0700 From: Stephen Hemminger To: Cc: , , , Tyler Retzlaff Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: fix side effects in align mul macros Message-ID: <20230704090126.236ee995@hermes.local> In-Reply-To: <20210510194008.403-1-pbhagavatula@marvell.com> References: <20210510140214.2627-1-pbhagavatula@marvell.com> <20210510194008.403-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 May 2021 01:10:06 +0530 wrote: > Avoid expanding parameters inside the macro multiple times. > For example: > RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ); > Here rte_rdtsc() call is expanded multiple times in the macro > causing it to return different values that leads to unintended > side effects. This was already fixed.