From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A3F42DD9; Wed, 5 Jul 2023 17:18:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 997DD406B5; Wed, 5 Jul 2023 17:18:52 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 7CF3A4021F for ; Wed, 5 Jul 2023 17:18:51 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b8a8154f9cso6225195ad.1 for ; Wed, 05 Jul 2023 08:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688570330; x=1691162330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MIB1f6VvyZoBJLd0B3eXzMiAvfXIj9bCBqoljZPS3F4=; b=iZINqHg4/I2VVytPOv66iZlml4tuwOyJ+591UMVJ3JS7JjTUEFQnIuqb8Cbwu8JYqP 93Xrq8074vdhxtw6eItQewKU2GqQsssYvmdW7mkHj0R7kWXLtw/IDSVElx5nb+s8uG1B qTRuGM0xIGPTkw3RK+bsZttVqd3w0C5EbAl9ijtUY6TRfuvzO96k7Z9yWphVYb9fZokW oGjZxZWhUnqOURyJ+JhDiIsrYNLBFy59lx8YmputyjCnFBuZCYjQyp1Yb/0KfgqiE49Y YegPvAZBtmUZD80Z9fTG5tZxlAQRu9Q5PUeGSMiEdTFT4etZ/oCofH/K3zMxQf9cyHCY 5Gng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688570330; x=1691162330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MIB1f6VvyZoBJLd0B3eXzMiAvfXIj9bCBqoljZPS3F4=; b=Nm8TRlPyAACMzDBXN0z++gAsBukr+kj0rIEyGmFY2do465VpnT0Q/qe09WyftNK9TN hzyD3CdaGRyMZNxHO5wZW1I04wx4QgjmQBQ1KFO0uQeFcemuTClcVjqwbuL59L/erZWz HYA+mjI0tdtE6NysZL+19yY3uMF+h9e2S5PPyt1BG4yLPBTlRYGVDiurrSIixsbGRoKu RQO+QZ4/YhaVjIzV1eh1XTsrbD0m5P7Mafj4YgeI2CsNz4p/8VfJwXdeq+uBov6/BrGf u4npmbSAWq6TKCTvPMiNN0MyyV9ofuhV0h/HyTFNhdF1yz79L51MMzhXl4LsxLDiAWVv 6fmA== X-Gm-Message-State: ABy/qLY7rJKchvmDXRpWIhM3mczliJTpKOO6LV/odggBeOIMRx8uBVXN Cmcxc9iJfRDQfn+uoGpQYXGf3w== X-Google-Smtp-Source: APBJJlFelt/lYUrJWRGIebvvTuZ+2+x0ZHWHatzh8c369ZGLz0a1EiswJ1MNnG/gUkXNVV9duT59qg== X-Received: by 2002:a17:902:e843:b0:1b7:de50:7d9c with SMTP id t3-20020a170902e84300b001b7de507d9cmr3855282plg.15.1688570330471; Wed, 05 Jul 2023 08:18:50 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e3-20020a170902744300b001b1c3542f57sm17652120plt.103.2023.07.05.08.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 08:18:50 -0700 (PDT) Date: Wed, 5 Jul 2023 08:18:48 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Ido Goshen Subject: Re: [PATCH v2] pcap: support MTU set Message-ID: <20230705081848.33899f5e@hermes.local> In-Reply-To: References: <20220317174347.110909-1-ido@cgstowernetworks.com> <20230704210237.72933-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 5 Jul 2023 12:37:41 +0100 Ferruh Yigit wrote: > On 7/4/2023 10:02 PM, Stephen Hemminger wrote: > > Support rte_eth_dev_set_mtu for pcap driver when the > > pcap device is convigured to point to a network interface. > > > > This is rebased an consolidated from earlier version. > > Added support for FreeBSD. > > > > As far as I understand motivation is to make pcap PMD behave close the > physical NIC and able to test the application MTU feature. > If so, Ido's v4 was simpler, which doesn't distinguish if pcap backed by > physical interface or .pcap file. > What was wrong with that approach? I started with Ido's patch, then: - combined the two patches into one. - fixed the error handling (propogate errno correctly) - add missing freebsd support Normally would just give feedback but patch was so old not sure if it was stuck and unlikely to get merged.