From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 541DF42DD6; Wed, 5 Jul 2023 11:44:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33AE3406BC; Wed, 5 Jul 2023 11:44:37 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2081.outbound.protection.outlook.com [40.107.237.81]) by mails.dpdk.org (Postfix) with ESMTP id 4338740150 for ; Wed, 5 Jul 2023 11:44:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=as1tq4EzlJFQzdzViyg14Da+zqsVoD0IBw+8Ou6m+gKoy4+fP5UJr4C1iANG9fUyeyzgO55vyShNKRtjNtc/0jN1UCj4/yus6fPbpptgyLS0JKgLJpnrZ/Pf0Nug7V2jsQKOBjlStdYOxXaDZmgpru+glFnpzYgWPD6NTBe47PDcQJRGHFhbeIj1qcE16lmKqhhwcV1nBr9TLQ8Vp7kwdjtK/lERpEcB/COWDCdgAbaq+0N0s5u88R/7y8sDuOr2HYNU7vq9t2APH84STyAz+sbii4pOQ58GQI0cwsRts2UVAw5F6jXD9u6q44tbMgL6GRGiSIRmuHi3Uw7z/LQBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvn8Ul22+0+W6RXFV1ezb1NGb7EoXP50WhoPWqPb40o=; b=b1NjqFzb6cMZocZIm6v89KUq0MY97bbQLVZbzceIZxxolU49Pn1PUbuWHxqc61bSJ6mCIFsthSsrteA64k/60sYxxk69bLYQH8FhuuYpjXK3mejvzzKzQPTtg5G4zKvCdiOcaD9nXAhIrp04s7ct14qsQw53cdLVm0prXsODVSXZc8tzkH9l+/uFM1t2W0yXq/t3PD+FxzEf7frzb3LKVbk0dcw4lHS/t2nLg2cJ8ePmDN1KFHDSl6M5aS3Zj0tIKADF3qRzmhMJFCxeQnkVv3rBuuzv5hsRC9yVFghzpi2VehY6+z0kNtd76dkee9ylWeM2RB/KJAw+WS1ox5LaGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvn8Ul22+0+W6RXFV1ezb1NGb7EoXP50WhoPWqPb40o=; b=GgfYeiQn4zl155T3EaDTSyxScFlulmy49T4hwarAr1VPgjC/9jNRFcHanBcwr73zCstqChaWOtD+CMLMHsyB8ZFGy78gKNRckLPi8yrmbbxE7HaL5/Lz5A3+WyAC2jrcjewRf8gSh51QJfeTpvHZ5uSEztqh4lWkLwRqusxH8JdMbeopR/d1HbuHR9V7Pu72cX8ZHSYChhtWxR5AP8sFalFf1ph7IOSUigZ15izp5k5GBFzehaBsofOuVV5/8N4HcnwW1zXYfCKtl2qq0LW2ZPw6QHYXYe9lwP/H/Co/xEuZzxAL4RdYr5FHY1q1Np2SeYV2YvWbnS9nHlE2M6tNqA== Received: from BN9PR03CA0077.namprd03.prod.outlook.com (2603:10b6:408:fc::22) by DM4PR12MB6613.namprd12.prod.outlook.com (2603:10b6:8:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 09:44:33 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::95) by BN9PR03CA0077.outlook.office365.com (2603:10b6:408:fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend Transport; Wed, 5 Jul 2023 09:44:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.44 via Frontend Transport; Wed, 5 Jul 2023 09:44:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 5 Jul 2023 02:44:21 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 5 Jul 2023 02:44:21 -0700 Received: from nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Wed, 5 Jul 2023 02:44:19 -0700 From: Maayan Kashani To: CC: , , , "Matan Azrad" , Viacheslav Ovsiienko , Suanming Mou Subject: [PATCH] net/mlx5: fix non-ip packets are not delivered when RSS hash type ESP is used. Date: Wed, 5 Jul 2023 12:44:02 +0300 Message-ID: <20230705094404.53840-1-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT017:EE_|DM4PR12MB6613:EE_ X-MS-Office365-Filtering-Correlation-Id: d5c5607a-5fba-406c-c162-08db7d3c6fd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KypSayMOlcs9G86m74vZY5rSK2WS5fips80wnE2cWsxXlEVCZ/iJ86FFHFolrMa+N+QDTFBZXd9imIl8JUYaaKIIfP50Qg+z1pEnxJ2P/7F0BcxwQ4FP61r62LCiUq6ibl1x/+K9jMjK+Z3Bpzsvws/gWTN13sDnndcjkBiVqiByJMGh3M5is5RrUlinS2qktRVnJyPgvRHSMrb7OxRHsaI4bmnG9KtIcdIwHeiOtTIOy/bm9e9mzHvC/5UB2qmgsfXH+l9TCPlF1EGGerCrYV6HdPuk2a4gftafflXCuGYpWJhthZs5ta2qEi2QOKgr9rOUOVDYlZLZF7IeJg0a26i+qq70kxHjgTQZq27MxGMWcVaaCRx6ry4UFgsXY70UzIhSGGFElGpWR1lhByX29G9Of9Y8FarS415YLGPwYCx1sqA6lPhnSUXu+KiRoXzG8obdJZY0MbbITD5Hzt+3Bf4o1fx4253yyTqbRECUi1n0gStsAO3m9wB1OxBB88Bg0TlYm6F8l56DXnOzfl/4jHGZWriwxYBO4F08X2E8KR3MJz0iSpDNsJFMPPev+MqZuJlrJgxbNPOGivABY1WITgzLDDXDUjMQDfIM2nGYdzx3CbdkAwJf7X4SU2EWaZoQXNUPWRYqBrftA4qjC2kQIUAJnMucHtq/Yxf18I1wrgFNnMvLMzCgmsf2Gei3DB8Lqh7CwK+KM8U4LvyzoQDWWibs8jDfFutiCK/+xcUkg3XV8g+L4d94mAWLcTe8zf/x X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199021)(36840700001)(46966006)(40470700004)(186003)(82740400003)(336012)(426003)(478600001)(6286002)(26005)(1076003)(107886003)(86362001)(2616005)(6666004)(316002)(83380400001)(47076005)(54906003)(356005)(7636003)(7696005)(36860700001)(6916009)(70586007)(70206006)(4326008)(5660300002)(8676002)(8936002)(40460700003)(2906002)(41300700001)(55016003)(40480700001)(82310400005)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 09:44:32.9233 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d5c5607a-5fba-406c-c162-08db7d3c6fd9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6613 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 20230703182123.210117-1-mkashani@nvidia.com Errors-To: dev-bounces@dpdk.org Non-ip packets such as ARP or LACP are not delivered if you use RTE flow rule with empty pattern and rss action with specific combination of RSS hash types: "ipv4-tcp ipv4-udp ipv4-other ipv6-tcp ipv6-udp ipv6-other esp". The stack which used for RSS expansion was overflowed and trashed rss expanstion data(buf->entry[MLX5_RSS_EXP_ELT_N]). Use bigger stack size instead. And add relevant ASSERT for the future. Signed-off-by: Maayan Kashani Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index cf83db7b60..41e298855b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -374,7 +374,7 @@ mlx5_flow_expand_rss_skip_explicit(const struct mlx5_flow_expand_node graph[], return next; } -#define MLX5_RSS_EXP_ELT_N 16 +#define MLX5_RSS_EXP_ELT_N 32 /** * Expand RSS flows into several possible flows according to the RSS hash @@ -539,6 +539,7 @@ mlx5_flow_expand_rss(struct mlx5_flow_expand_rss *buf, size_t size, if (lsize > size) return -EINVAL; n = elt * sizeof(*item); + MLX5_ASSERT((buf->entries) < MLX5_RSS_EXP_ELT_N); buf->entry[buf->entries].priority = stack_pos + 1 + missed; buf->entry[buf->entries].pattern = addr; -- 2.25.1