From: Stephen Hemminger <stephen@networkplumber.org>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Li Feng <fengli@smartx.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH v2] eal/linux: enable the hugepage mem dump
Date: Wed, 5 Jul 2023 16:19:26 -0700 [thread overview]
Message-ID: <20230705161926.2e06e8b7@hermes.local> (raw)
In-Reply-To: <20220406021446.0cf75ada@sovereign>
On Wed, 6 Apr 2022 02:14:46 +0300
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> > Don't merge this patch as is please; it would cause a lot of pain
> > in a cloud environment.
> >
> > In our environment core dumps are collected (via systemd) and uploaded
> > to a central server. With this kind of change the processing would get
> > overloaded with multi-gigabyte core dump size. Probably couldn't even
> > save a core dump on these kind of smart nics.
> >
> >
> > This needs to be optional (from command line) and default to the current
> > behavior (not dumping huge pages).
>
> Maybe expose eal_mem_set_dump() as rte_mem_set_dump()?
> This would allow to implement the feature easily using memory callbacks.
> Better, one can enable hugepages to dump selectively:
> for example, dump some interesting hash tables but skip rings and mempools.
As was mentioned in thread core_dump_filter will also control these.
So it won't impact users who do not enable it.
Since the granularity is a the page level, it doesn't make sense
to try and be selective for hash tables, rings, mempools etc.
Looks good as is, though it might need a rebase.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-07-05 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220308094125.2716847-1-fengli@smartx.comOD>
2022-04-01 9:10 ` Li Feng
2022-04-05 22:46 ` Stephen Hemminger
2022-04-05 23:14 ` Dmitry Kozlyuk
2023-07-05 23:19 ` Stephen Hemminger [this message]
2022-04-06 2:11 ` Li Feng
2024-10-02 16:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705161926.2e06e8b7@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fengli@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).