From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85A3D42DDE; Thu, 6 Jul 2023 01:19:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1540940144; Thu, 6 Jul 2023 01:19:31 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 3AA16400D5 for ; Thu, 6 Jul 2023 01:19:29 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6686a05bc66so132271b3a.1 for ; Wed, 05 Jul 2023 16:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688599168; x=1691191168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XSkh4jdJ5DyJH0lXNV3HIJrDOhIUTVRBVL2WMuRrYrM=; b=IveFVFZRFGu6uWs/GDWYqa+Ns/z8r2WPIyshxMjoH5bGuw6bt9rr7welp/MptFcxuJ x2pvWmghlWLNBkSPfh9ImTChbScx/9RlucnzKkFkVpwYWh0gxpGqOidTVDDc/pyMGD6I asFaRmGeu5lRXc2kZgDAHKu0r2yZMs/I6CRYl0KkR61L2gkCTulzOkoUuq51ZykpnJ2W V+beNVNuok76zHqT0PuNTgNJ3303H+8vO8rixGjZpf57fxkBVoBKg7LjCRVHdLyrmAOv JITqfQh5Riiqy6lvLWAfeRLzTsjniUe1dBW54Bjfs26rYiUGKTdSwL8vgLGJz4ZFF7TW As+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688599168; x=1691191168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XSkh4jdJ5DyJH0lXNV3HIJrDOhIUTVRBVL2WMuRrYrM=; b=OH/PdmN3LxxeYKpmJapE78vCnOaYODmxhlkvU7/X3nbrLGociQsXS/WP6Bdg+QZa+y XhMgnjG5g7ArqH4XJ3COdLjk8A3pekdGwxnZb1jK+8DlOzKvG4p5SfyLmK61lbqVG6sA 073XiCrnEwJvYIzCte/EvF1b5xOJc75P4/huN0HN+XzQ9ZcEYRp2WvmgFOkTOypJchc+ tHF2pOXCKZSsDJoojRZl11jPz239QbNFb7FhEPwmrqo+f3Rwez+KJi7I5UN1QhVCFCRw pT42XmOYenwRTjwNuwJFKkJ8Sq5BNrrZVGJORLTkAy1goC5beCR6QcO/jrD9gw+yh4b2 tOQw== X-Gm-Message-State: ABy/qLYCqekpAsJyn5BjqlSUe+eRaNCk4TKHOzvlg0Q+U5CCcgJi8fw6 XLChw2QwwMal8j9AaY340IWh+w== X-Google-Smtp-Source: APBJJlHLG58NwBF0BmvZyNNfcmfad7imwTZNwsZATHYgLEWmgFny2a2nq9R6gAT44VJj7tvRGOgYig== X-Received: by 2002:a05:6a00:39a5:b0:66a:4a45:e017 with SMTP id fi37-20020a056a0039a500b0066a4a45e017mr327867pfb.20.1688599168162; Wed, 05 Jul 2023 16:19:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id fe27-20020a056a002f1b00b0064d47cd117esm73605pfb.39.2023.07.05.16.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 16:19:28 -0700 (PDT) Date: Wed, 5 Jul 2023 16:19:26 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: Li Feng , Anatoly Burakov , dev@dpdk.org Subject: Re: [PATCH v2] eal/linux: enable the hugepage mem dump Message-ID: <20230705161926.2e06e8b7@hermes.local> In-Reply-To: <20220406021446.0cf75ada@sovereign> References: <20220308094125.2716847-1-fengli@smartx.comOD> <20220401091004.3227117-1-fengli@smartx.com> <20220405154655.60900b0d@hermes.local> <20220406021446.0cf75ada@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 6 Apr 2022 02:14:46 +0300 Dmitry Kozlyuk wrote: > > > > Don't merge this patch as is please; it would cause a lot of pain > > in a cloud environment. > > > > In our environment core dumps are collected (via systemd) and uploaded > > to a central server. With this kind of change the processing would get > > overloaded with multi-gigabyte core dump size. Probably couldn't even > > save a core dump on these kind of smart nics. > > > > > > This needs to be optional (from command line) and default to the current > > behavior (not dumping huge pages). > > Maybe expose eal_mem_set_dump() as rte_mem_set_dump()? > This would allow to implement the feature easily using memory callbacks. > Better, one can enable hugepages to dump selectively: > for example, dump some interesting hash tables but skip rings and mempools. As was mentioned in thread core_dump_filter will also control these. So it won't impact users who do not enable it. Since the granularity is a the page level, it doesn't make sense to try and be selective for hash tables, rings, mempools etc. Looks good as is, though it might need a rebase. Acked-by: Stephen Hemminger