From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 857A942DE1; Thu, 6 Jul 2023 04:40:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2034D40144; Thu, 6 Jul 2023 04:40:41 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 08FB3400D5 for ; Thu, 6 Jul 2023 04:40:39 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b8303cd32aso696745ad.2 for ; Wed, 05 Jul 2023 19:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688611239; x=1691203239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=554X3oEgE14j0dCV1sduRX/gvt96NhxRGellD9DnM2g=; b=NzFmYAO0rFxjRZX4+Uufb+vgoKD2fLJUkFVaLxFmqvfNlO0yQBXYZELcXWX73ZiFNz TNEGSnKd+BkiKmIhPu3EcLcuXwbbuLxtrKuJxxSJ/4xwz73ATTUfwSkK/ArrYTwqIK+g hJF/mR7ke17a7FoMRwj6yFRSwhOpV9YoZjfJqlclkReSxfAZuzXjNd+WSI8uCubaF2Wx YoycHEMFQq2MbKMWCwM/hO9PB7jdpq78sJEjg32jSMCtXZir8eYvZPznXI6CLhX6F9Kw /lisNd394dRThjs0ULAuRPZU+jmNXf5E6ZcQdBz8COUWuN9UHO8FoM27DJlcU+oa0Yrs llIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688611239; x=1691203239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=554X3oEgE14j0dCV1sduRX/gvt96NhxRGellD9DnM2g=; b=DshO6XnIO2kDREDcdKJKt2FMJ2hKH+bJ1qzB2fpZn2MeQYHzl2MSwox2q/vivIzQ9g hIjTkrwgebjwAwEzehdNFPqRM5Bc74TZHgCrCWxGhb4BHTVZRThZzngrHWDYiaDYcrfw jJSh4uTTbSjLt+T2Jgz1h52ygXAC2fyOoyMs9z3yPbMeLxjC5jP0QwsgGCNw5t//kNgd 5VLxEnTIkmHNBuSRFYAbtnHAB3/rDWTIfYcJD1NNbEVpmBvpliE+J8Vb1/y9s+fEESEh rzfph/5wQeC+iD1aAVf0W626F8KKyizR4YSnYm2VI57Y5+EbPjYipnh6HyYe2ceVwT3s EAtw== X-Gm-Message-State: ABy/qLZNyEXJB8IAlDgtwopUyDvp6WNLz3lgrlTvaYGctUoMEHGoQ/WS ghoU8Kg/qUYStHDbKMMAvwZpkA== X-Google-Smtp-Source: APBJJlF2X0DiRsYAl8pyqQJ6jLbSRLQ8jJUViD0ZSBCTIIovGJ5hSYx4VXgDHLvBrJA5oDbyckYRnA== X-Received: by 2002:a17:902:ed44:b0:1b8:6cbd:96f1 with SMTP id y4-20020a170902ed4400b001b86cbd96f1mr708966plb.66.1688611238935; Wed, 05 Jul 2023 19:40:38 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jj17-20020a170903049100b001b8422f1000sm156696plb.201.2023.07.05.19.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 19:40:38 -0700 (PDT) Date: Wed, 5 Jul 2023 19:40:36 -0700 From: Stephen Hemminger To: Shinae Woo Cc: dev@dpdk.org Subject: Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs Message-ID: <20230705194036.0f1ad691@hermes.local> In-Reply-To: <20220821221213.9591-1-shinae@alkira.net> References: <20220821221213.9591-1-shinae@alkira.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 21 Aug 2022 15:12:13 -0700 Shinae Woo wrote: > - explicitly set default value for intr_mode > - give read permission on wc_activate > - applying patch gives below visibility > > ``` > $ more /sys/module/igb_uio/parameters/* | cat > :::::::::::::: > /sys/module/igb_uio/parameters/intr_mode > :::::::::::::: > msix > :::::::::::::: > /sys/module/igb_uio/parameters/wc_activate > :::::::::::::: > 0 > ``` > > Signed-off-by: Shinae Woo Looks ok. This would have to go against dpdk-kmods tree. Checkpatch is being overly picky here Reviewed-by: Stephen Hemminger