From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4747C42DEC; Thu, 6 Jul 2023 22:08:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18D3341101; Thu, 6 Jul 2023 22:08:13 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 85C5C40A79 for ; Thu, 6 Jul 2023 22:08:11 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1b8b318c5a7so7263845ad.3 for ; Thu, 06 Jul 2023 13:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688674091; x=1691266091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zAy/ADePj7pjOiRxhtSN19BEeIic3WJiZ6/NX6QcSOA=; b=bhWgx3eY6lNC690JDisa5uZe5GXZGgj4YrcmYjmOO7irxJux2M5r7pywhLFbNTcGth uMkfC9moNHzObTij9K90KMN0y38w7cdt8CwResIrEOJY+9FjLzyI4ii9Lzwh2aFhX5T/ Rg//j8HGDbyIV/T7FZWNB8ouau/8iy4+3rpZuuA3mQZXgf9g0n6fuf0nr8GdtHrPodCe TeUtaQ+ewumpiS21AXVZqgenglXNVmbryBgzWIwl8FHolfFNyA+XeuWFLyoeTuYa9lkt c7a8b72a8/9nplPw5WuFic2670Q+p1HGlLg970ItmkENxIUs9nZnFIfZ2zsIhtECkVYi nHdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688674091; x=1691266091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zAy/ADePj7pjOiRxhtSN19BEeIic3WJiZ6/NX6QcSOA=; b=bDgg1sWSq2w207pBW5Mtyhe0eEEzLjKqFXIuSgn02SPbhjNlY0Vkx8LF5U/u4cX36b 5Am8tNA2gwW9M/3A+ogSnrApnCb2USI2fz0GgZ0JQ1XTagf2pMAvMeqJQZvZniwnf7b9 gb3En3FnU/wMuPQOWkTewFBVCjt6tDaEvNcVZqyGwhdeM2tFLIl9U5OOOdhju7TZ7lCy yD1zxEWzgZcSAB41QThyhxoWd5cyhMFoNi2Oc11ronuOGNcRAfVREH1hWdwTfbsx1KhH R2RdP+dUtn7Cy0ieQ11wSxuCGlAsApr0T+eOFOfHtJKgUuntVaRqqbcmK/b85EwCLrfw AO7Q== X-Gm-Message-State: ABy/qLbtSnpVvhVcsBBY/2kirQ9cEXNrHFIubJob2rlY555S4V58GHJn KjoBhPb0HuX0S/odMomhfMY2pg== X-Google-Smtp-Source: APBJJlFNmLy+xrSNJ8nGJejXp9kmEPEFPz/xZRvBKon5ywcrciiLDqnXTC7JmT2A2L4pM8n5QjRvYw== X-Received: by 2002:a17:902:e54a:b0:1b8:7e53:704 with SMTP id n10-20020a170902e54a00b001b87e530704mr3899245plf.27.1688674090697; Thu, 06 Jul 2023 13:08:10 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d5-20020a170902cec500b001b8ab115ce4sm1778852plg.278.2023.07.06.13.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 13:08:10 -0700 (PDT) Date: Thu, 6 Jul 2023 13:08:08 -0700 From: Stephen Hemminger To: Bili Dong Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, vladimir.medvedkin@intel.com Subject: Re: [PATCH v8] hash: add XOR32 hash function Message-ID: <20230706130808.75e8d154@hermes.local> In-Reply-To: <20230629173304.2195376-1-qobilidop@gmail.com> References: <20230620191253.3218830-1-qobilidop@gmail.com> <20230629173304.2195376-1-qobilidop@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 29 Jun 2023 17:33:00 +0000 Bili Dong wrote: > + > +/** > + * The following bytes access helper functions are expected to work > + * without any particular input buffer alignment requirements. > + */ > + Probably need to avoid users getting tempted to use these helpers ad exported API's? Mark them with @internal tag?