From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B34E42DEC; Fri, 7 Jul 2023 00:43:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 349A8406B5; Fri, 7 Jul 2023 00:43:31 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id CB6FE40685 for ; Fri, 7 Jul 2023 00:43:29 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1b8bbce9980so8682215ad.2 for ; Thu, 06 Jul 2023 15:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688683409; x=1691275409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YCCkpCplh+Ow4udGi8JvVNXZdl1fYkG1FR3+5eILCXM=; b=s8+C9zJP5QZFqhVGkP3hx+CrR1YNAJZIhD9swjnIEzLV1CqiTCJbpmr7lgOr/Ku17k p887GsD1+qXgjjjQLh0dOsnNXyr8YWWI3dpkY+KBMxeIQDTRqPWi/O9vj9gAM99qZXrJ Z3Rg9ySLCJl4DB/NUjQ27n3moLbMHiukALnaj+sri8k96gmfbIhKK541Vv3OmfXF+76k TbzsEP7wBzBmMhttsY0w3p/8zxlOLpXWegKqehTCvgy8L8VzM/5J7Ibjl4/ZFQc4kfdI 30JsDqfFznU6CGrTr6OwJIyzaIGVwkAOLyTeED6Pk3tnn31YiUYrZBb/ga6bpkAnNgbF O9Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688683409; x=1691275409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YCCkpCplh+Ow4udGi8JvVNXZdl1fYkG1FR3+5eILCXM=; b=X+MQQ9M4B+/5AcRlEgDAdb6Y3XPehmzGG7OxRRb0t4Way5K4ukKhYK+KlA9W2qhFi+ eB2+L2UZ2PoofhXFJY6+7TtRiR6TW0p/ZxQ2GlWsQWN6rnTMc0A+g4s74UwRyo/bnf9/ fY3gIX0CAqHocFF9EHs4tBNFhQFfO/Xljl/bRK9CVLdTqrSiMDBBKWDGkHVfQPMrI2LD B5B7G61K2S9ToZKdvZqr5F6Mz1XlrRwmppg9x3F3qDYoPN1JWeZsBJWCO3WhDjokKmYj uiG1aCN3sauUAzfR9c+DrUEPUfN6gmzTxaRoEMMjh3LieKxqJ1luS0Uf8ICwgnJpcde+ LFsw== X-Gm-Message-State: ABy/qLaqazKZ3dKt5viyQBklp0jt4emd9JLychkS5deSZ6WAWBvpgU2F LtsgR5CnVig1lNW3oELvHh3n/mq6nibysVrxIW06ZtouLl4= X-Google-Smtp-Source: APBJJlFRtf61WPqYL2t+5ZUAqLx6rQAb9R2UNXm9M0rKW/g2qY42PlCpTDcrp1rX7gIB3EJKoiQF/w== X-Received: by 2002:a17:902:d2cd:b0:1b7:d0b3:1678 with SMTP id n13-20020a170902d2cd00b001b7d0b31678mr2861498plc.17.1688683408900; Thu, 06 Jul 2023 15:43:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id i19-20020a170902eb5300b001b9be2e2b3esm297704pli.277.2023.07.06.15.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 15:43:28 -0700 (PDT) Date: Thu, 6 Jul 2023 15:43:26 -0700 From: Stephen Hemminger To: okaya@kernel.org Cc: dev@dpdk.org Subject: Re: [PATCH v3 00/10] codeql fixes for various subsystems Message-ID: <20230706154326.4b7c408f@hermes.local> In-Reply-To: <20230120044140.95975-1-okaya@kernel.org> References: <20230120044140.95975-1-okaya@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 Jan 2023 23:41:30 -0500 okaya@kernel.org wrote: > From: Sinan Kaya > > Following up the codeql reported problems first submitted > by Stephen Hemminger here: > > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null pointer accesses. > > Changes from v3: > - Dropped net/tap: check if name is null > - Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get > > Changes from v2: > - Remove braces around single line statements > - use NULL comparisons > > > Sinan Kaya (10): > ethdev: check return result of rte_eth_dev_info_get > memzone: check result of rte_fbarray_get > memzone: check result of malloc_elem_from_data > malloc: malloc_elem_join_adjacent_free can return null > malloc: check result of rte_mem_virt2memseg_list > malloc: check result of rte_fbarray_get > malloc: check result of rte_mem_virt2memseg > malloc: check result of malloc_elem_free > malloc: check result of elem_start_pt > bus/vdev: check result of rte_vdev_device_name > > lib/eal/common/eal_common_memalloc.c | 5 ++++- > lib/eal/common/eal_common_memzone.c | 10 +++++++++- > lib/eal/common/malloc_elem.c | 14 +++++++++++--- > lib/eal/common/malloc_heap.c | 9 ++++++++- > lib/ethdev/ethdev_vdev.h | 2 ++ > lib/ethdev/rte_class_eth.c | 4 +++- > 6 files changed, 37 insertions(+), 7 deletions(-) The patches are fine, only warning was from the requirement that all submitters be in .mailmap now. Do you mind if I rebase these, add a mailmap and combine the like ones together? Acked-by: Stephen Hemminger