From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0695042DEC; Fri, 7 Jul 2023 00:47:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 845B5406B5; Fri, 7 Jul 2023 00:47:28 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id DC60240685 for ; Fri, 7 Jul 2023 00:47:26 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1b8303cd32aso8099395ad.2 for ; Thu, 06 Jul 2023 15:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688683646; x=1691275646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bbqEvOa/x0QSyGnHucgkqS2gJTBmwEyyGfo3+QZARv4=; b=PijSCFCw57cqyYTqRoLfPmOHzpFIlnG6iHaC0D2updaHorSCx46N4+a4ciSh037xIf wWo6saBGxNZkiYYMmr5vMOYxyE3clQukKGY5JIYjZ4DSsM7EnrDQfh6tztt8LYVcoI/i 9xPNtoUdjqsX1MUqbVDKrnDW0k20LTTkeiuJiFp/LUVuIUbTP4OtDKJ2cpyXd/SqchM+ kDYnWGlR0DjKljLD2gOvjUg0RClFJDue20q0vi78C5RSQA64l5gJfwjeTDzy2yOUOuV6 IuFWsD7BC0DHX2KWjbFi7EckU8BGwg2EUC09cJcmse4/D56bISeSSqEll6GGeF5P2rb8 J7rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688683646; x=1691275646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bbqEvOa/x0QSyGnHucgkqS2gJTBmwEyyGfo3+QZARv4=; b=dkoMEDkJ41bsz/kmMMvugTSbgLZI2xbdYm8CpU2P55LSp9Sf6MjWjrVdkw6Zxbim1f q4u8ZytYXL27+sG6dmsOvkG1fcrZGmmlRPo55OsoQJDwwbALEoJVOiGMXT7Q5VRE5WM8 Ko1A0APZp8cTDaG6M64qxFB8+jnJeVYULT2xOmCpSbeuE9pz0VVXGbLonVsueTF0Pizx u5tGMxw52t+c3JNIdYSKGoRUvR1q/Dmzh0/I0w6+UxjfAQqdCfYBQMqveGS0O/ON8JQW 1V+J2mFWxaUXIFnKHi7ndG+IL4G7ZpYeW4bIo7q5vTnwFVdt9/b6WfKOdGaWmssoaeF2 stgQ== X-Gm-Message-State: ABy/qLaZJ179FOqncm0fOfhQzPd2Ju8AEtxC6ZUbPYvMyI4YDXFzlLLE ydft2SOBk05ZqWXvdDfaQpSsgQ== X-Google-Smtp-Source: APBJJlGsa8FBvaBxiNuLD1OMgvYXTnxhaK0M7AD+Br5zL3x4JbMx5zi9gYLI11MXUV4vsTUgtqSoxg== X-Received: by 2002:a17:902:c3c6:b0:1b8:1c9e:444e with SMTP id j6-20020a170902c3c600b001b81c9e444emr3184234plj.25.1688683646028; Thu, 06 Jul 2023 15:47:26 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jc20-20020a17090325d400b001b3f039f8a8sm1894647plb.61.2023.07.06.15.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 15:47:25 -0700 (PDT) Date: Thu, 6 Jul 2023 15:47:23 -0700 From: Stephen Hemminger To: David Miller Cc: dev@dpdk.org, Mathew S Thoennes , Konstantin Ananyev , Xiaoyun Li , Aman Singh , Yuying Zhang , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Neil Horman , Dmitry Kozlyuk , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Haiyue Wang , Jakub Grajciar , Harman Kalra Subject: Re: [PATCH] Add support for IBM Z s390x Message-ID: <20230706154723.2f921b28@hermes.local> In-Reply-To: <20221028215240.103365-1-dmiller423@gmail.com> References: <20221028215240.103365-1-dmiller423@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 28 Oct 2022 17:52:40 -0400 David Miller wrote: > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index cc8e7aa138..2a863f3d39 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -245,9 +245,9 @@ nic_stats_display(portid_t port_id) > static uint64_t prev_bytes_tx[RTE_MAX_ETHPORTS]; > static uint64_t prev_ns[RTE_MAX_ETHPORTS]; > struct timespec cur_time; > - uint64_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx, > - diff_ns; > - uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx; > + __uint128_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx, > + diff_ns; > + __uint128_t mpps_rx, mpps_tx, mbps_rx, mbps_tx Not all platforms DPDK supports are likely to handle 128 bit numbers. And unsigned long long is not 128 bit on many platforms. Better to leave this part alone.