From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5550A42DEC; Fri, 7 Jul 2023 00:59:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43630406B5; Fri, 7 Jul 2023 00:59:34 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 4D8A440685 for ; Fri, 7 Jul 2023 00:59:33 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6682909acadso809667b3a.3 for ; Thu, 06 Jul 2023 15:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688684372; x=1691276372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=h9rOs8L+w5sk6pfhZa9ICFwfOSnDHEvGfTPb5yUa9zM=; b=Mb06MgQSAWBuI7JNABCNIJRheNTQC9hY5TUY+jme3t8qGBoE9Bq2vL99OwWbpsClBA gGH5EX5McnuvjMJTSx4BXerYUuhAltL79NhBKb3Gsee0pHgI+ua4bH+8CIkWWIUZLyAl ROisxQfJiNb2erHuHDAFJ0qbIrlpfL8gEl7osr+RGiRwCISEugGonmOs4OD7CEDTaWQ6 P1+mwbOGs4z9I+BaeZRJZk45J8EMLm6k4+b4ypEV/oLfMAXQ4ED4zDHluy3SunGI2IJP L81WfwCSP45iVmOGy4xN9q7fnPYSgsjYoI/jxLElYm4QjTFdWVODLMihX13rZDJnyuMR /5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688684372; x=1691276372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h9rOs8L+w5sk6pfhZa9ICFwfOSnDHEvGfTPb5yUa9zM=; b=ddODKPA9p3e4kWvThr8Q2gkaLZXAJe8QiosUGamnJznuf10awQaAE+ktO2pX2aA1yn S06+ut4HPb8OWSY43yeeqCf070wcGBywHQ7EJHH8KbNOqoWULHc6r0tK+6dIHUYAgHvQ vJzaPLeiX/GOGBVVjaFXPy9W57FkkborQQBcVVXTGNL3eXkvYwajL0i+9qxClLYbE+6U qfvtpjOX+cHvXPXmQKf7tsGGIspsBoxIhCS1v9Y0evxxLanQDwjyoPSDWUYZk7Gv1Jxf KX3uAj2RoKVtYW2KiGXB8BrNyw9bnNiRdmAnzV44i3nGH3KvaL/DHjGIePhMq5mdpB3d sl7g== X-Gm-Message-State: ABy/qLYNmaJunnzEfJeYJDxGLhDlvbiUi3jGQ7XOEoI1mDz55/2UCXSm Q0FQzRzWZh01Ys0xXyhFtbGxCg== X-Google-Smtp-Source: APBJJlFVV2w9EgvZgqBvTpVPXjQbTE9r0m9CRQo+BN1sBBqZRbu3b1NXRKIEbgMjfH86FvH/mQRAfg== X-Received: by 2002:a05:6a00:b4f:b0:668:6eed:7c12 with SMTP id p15-20020a056a000b4f00b006686eed7c12mr3309209pfo.22.1688684372493; Thu, 06 Jul 2023 15:59:32 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e16-20020aa78c50000000b0066f37665a63sm1735977pfd.73.2023.07.06.15.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 15:59:32 -0700 (PDT) Date: Thu, 6 Jul 2023 15:59:30 -0700 From: Stephen Hemminger To: Amit Prakash Shukla Cc: Bruce Richardson , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "thomas@monjalon.net" , "david.marchand@redhat.com" , "dmitry.kozliuk@gmail.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" Subject: Re: [EXT] Re: [PATCH] build: enable static analyzer Message-ID: <20230706155930.34519c64@hermes.local> In-Reply-To: References: <20220714072722.879156-1-amitprakashs@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 15 Jul 2022 12:05:41 +0000 Amit Prakash Shukla wrote: > Thanks Bruce for the review. Please find my comments in-line. > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Thursday, July 14, 2022 4:31 PM > > To: Amit Prakash Shukla > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > > thomas@monjalon.net; david.marchand@redhat.com; > > dmitry.kozliuk@gmail.com; navasile@linux.microsoft.com; > > dmitrym@microsoft.com > > Subject: [EXT] Re: [PATCH] build: enable static analyzer > > > > External Email > > > > ---------------------------------------------------------------------- > > On Thu, Jul 14, 2022 at 12:57:22PM +0530, Amit Prakash Shukla wrote: > > > This patch adds support to enable compiler static analyzer for gcc and > > > clang. > > > > > > Signed-off-by: Amit Prakash Shukla > > > --- > > > config/meson.build | 14 ++++++++++++++ > > > doc/guides/prog_guide/index.rst | 1 + > > > doc/guides/prog_guide/static_analyzer.rst | 21 > > +++++++++++++++++++++ > > > meson_options.txt | 2 ++ > > > 4 files changed, 38 insertions(+) > > > create mode 100644 doc/guides/prog_guide/static_analyzer.rst > > > > > > diff --git a/config/meson.build b/config/meson.build index > > > 7f7b6c92fd..1154396326 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -440,6 +440,20 @@ if get_option('b_sanitize') == 'address' or > > get_option('b_sanitize') == 'address > > > endif > > > endif > > > > > > +if get_option('static_analyzer') > > > + if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.1.0') > > > + add_project_arguments('-fanalyzer', language: 'c') > > > > Rather than checking for specific compiler versions, we should instead just > > check for particular flags and use those. > > Sure, I will make the change as part of v2 patch. Never saw a v2 of this patch??