From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C8FA42DF9; Fri, 7 Jul 2023 16:55:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E69A94014F; Fri, 7 Jul 2023 16:55:48 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 27E16400D5 for ; Fri, 7 Jul 2023 16:55:47 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1b8bbce9980so13933115ad.2 for ; Fri, 07 Jul 2023 07:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688741746; x=1691333746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=C+PoGN+NbC9nVv1IqEMBfKuJ1vmd0BEIkQea0Z2mmNw=; b=zCqaZrNGB+ur01vSlRg8sEGdRAMecomwYxjrJ9rFnp7EbeKR5oPvQ8eNVQvtA66KLt y3RcUkqMAk3LshJJa0MuP1ltFfYOif/3ceDk4SQsbLxPzTWbMVcsFj1tQami2OvMq47Z Kf7gBcPBjHqoM6XJD6uwPETOSKqrISlc5Yb6mx4T6Jeqrvqy45PvFODdJ0EEXPL1ITfK ahb3w9f+mKdKxW1vSu6f3cbg/dgyMwLK1RjWVk8V+dLkLy1Mi0FvtAAGZFCNwxF7et+8 fyFfioUYrzqtw2HXVJDoSZaR3Q6CR8g2lExv6ztWhewbK4aqk5adDiz+RMLoo5ktOjnr UadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688741746; x=1691333746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C+PoGN+NbC9nVv1IqEMBfKuJ1vmd0BEIkQea0Z2mmNw=; b=lDCXg3fA27Xi9V3fRogRFd7On5iaXSoOg5V8nz6qeQnmDDLIl+0a9IDbHfdLHdA6As MZ55S0a5sSFwe6o7dwn07oZ6RpaSkOJFiD8/W6e//dgi4W+UqjvyMwnay+p4Y3CxXcij 6ChNTEIQx3jbwVlTlkNVSTcNm/OIvgT+VuEcL8Uz9I5REjgToLZ72SV236AviIQXGxe5 Ce/p78rCVl3fp02aPDNGZdZdQnYGMc+CH9V4bo/jskpipFWoDVS7l5QWayKqKYPTSrcm 5lSSNycwFz+x4K7Xhg5TXNSH7IWV0iCa3oM/5QfjVHMkvdJgu4Vfxz97KNIn52bDtgH7 +XqQ== X-Gm-Message-State: ABy/qLaaXY3XGZ1YjyP6a38FHCJ6FJ4ITuRK4/BVjVHguoxaGlqHK39E yTaiZF/3QMu/0WojSMC0ZQ+rIw== X-Google-Smtp-Source: APBJJlHhDskjDFmZzUGQYljt1FrtVNtKpJmviLu0dIZ9BWHxO6puT/QwR8f7acfVMci9/hcAzq3qVw== X-Received: by 2002:a17:902:7447:b0:1b6:7db2:57dd with SMTP id e7-20020a170902744700b001b67db257ddmr4426486plt.19.1688741746214; Fri, 07 Jul 2023 07:55:46 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id s18-20020a170902a51200b001b8a85489a3sm3350586plq.262.2023.07.07.07.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 07:55:45 -0700 (PDT) Date: Fri, 7 Jul 2023 07:55:43 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Abdullah Sevincer , dev@dpdk.org, jerinj@marvell.com, reshma.pattan@intel.com Subject: Re: [PATCH v17] app/procinfo: display eventdev xstats Message-ID: <20230707075543.46a36fc4@hermes.local> In-Reply-To: <3736714.CbtlEUcBR6@thomas> References: <20230525164127.3046135-1-abdullah.sevincer@intel.com> <20230525184731.3056328-1-abdullah.sevincer@intel.com> <20230525130713.3ecf0ded@hermes.local> <3736714.CbtlEUcBR6@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 07 Jul 2023 11:15:22 +0200 Thomas Monjalon wrote: > 25/05/2023 22:07, Stephen Hemminger: > > On Thu, 25 May 2023 13:47:31 -0500 > > Abdullah Sevincer wrote: > > > > > This commit extends proc-info application to > > > display xstats for the eventdev devices. > > > > > > New command line arguments are introduced to > > > display xstats for eventdev devices. The command > > > example is like: > > > > > > For displaying a specific port stats (e.g. port 1): > > > ./dpdk-proc-info -- --show-edev-port-xstats=1:0 > > > > > > If any xstats parameters for eventdev passed through > > > proc-info command line, proc-info will only display > > > requested eventdev data and exit. > > > > > > Users should not pass any eventdev xstats parameters > > > if they desire to dump other proc-info data such as > > > Rx/Tx descriptor dump. > > > More information can be found in proc-info app doc. > > > > > > Signed-off-by: Abdullah Sevincer > > > > Acked-by: Stephen Hemminger > > Applied, thanks. Has new coverity issue. The reason is the boolean is set every time because it gets every time. Looks like code goes over eventdev_var[] even if no eventdevs are present. Should only look for the number of eventdevs *** CID 395458: Control flow issues (DEADCODE) /app/proc-info/main.c: 2114 in process_eventdev_xstats() 2108 } 2109 } 2110 2111 if (processing_eventdev_xstats) 2112 return 1; 2113 >>> CID 395458: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 0;". 2114 return 0; 2115 } 2116 2117 int 2118 main(int argc, char **argv) 2119 {