From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C793F42DF7; Fri, 7 Jul 2023 12:43:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 371C343044; Fri, 7 Jul 2023 12:43:59 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id F263640685; Fri, 7 Jul 2023 12:43:56 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Qy90r6NpDztQst; Fri, 7 Jul 2023 18:41:00 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 7 Jul 2023 18:43:54 +0800 From: Dongdong Liu To: , , , CC: Subject: [PATCH] net/hns3: fix non-zero weight for disabled TC Date: Fri, 7 Jul 2023 18:40:53 +0800 Message-ID: <20230707104053.6571-1-liudongdong3@huawei.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Huisong Li hns3 PF driver enables one TC, allocates to 100% weight for this TC and 0% for other disabled TC by default. But driver modifies the weight to 1% for disabled TC and then set to hardware to make all TC work in DWRR mode. As a result, the total percent of all TC is more than 100%. Actually, this operation is also redundant, because these disabled TC will never be used. So this patch sets the weight of all TC based on user's configuration. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: stable@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dcb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c index af045b22f7..07b8c46a81 100644 --- a/drivers/net/hns3/hns3_dcb.c +++ b/drivers/net/hns3/hns3_dcb.c @@ -237,9 +237,9 @@ hns3_dcb_qs_weight_cfg(struct hns3_hw *hw, uint16_t qs_id, uint8_t dwrr) static int hns3_dcb_ets_tc_dwrr_cfg(struct hns3_hw *hw) { -#define DEFAULT_TC_WEIGHT 1 #define DEFAULT_TC_OFFSET 14 struct hns3_ets_tc_weight_cmd *ets_weight; + struct hns3_pg_info *pg_info; struct hns3_cmd_desc desc; uint8_t i; @@ -247,13 +247,6 @@ hns3_dcb_ets_tc_dwrr_cfg(struct hns3_hw *hw) ets_weight = (struct hns3_ets_tc_weight_cmd *)desc.data; for (i = 0; i < HNS3_MAX_TC_NUM; i++) { - struct hns3_pg_info *pg_info; - - ets_weight->tc_weight[i] = DEFAULT_TC_WEIGHT; - - if (!(hw->hw_tc_map & BIT(i))) - continue; - pg_info = &hw->dcb_info.pg_info[hw->dcb_info.tc_info[i].pgid]; ets_weight->tc_weight[i] = pg_info->tc_dwrr[i]; } -- 2.22.0