From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB91142DFC; Sat, 8 Jul 2023 03:52:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AEE740DDB; Sat, 8 Jul 2023 03:52:55 +0200 (CEST) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by mails.dpdk.org (Postfix) with ESMTP id 366F740A8A for ; Sat, 8 Jul 2023 03:52:54 +0200 (CEST) Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-38e04d1b2b4so2153036b6e.3 for ; Fri, 07 Jul 2023 18:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688781173; x=1691373173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZGMRfD9Z7oO63wCHcVl5vfstO7KOVhVinxukgM54+RI=; b=cqKL0XzJSVBz9AN0T1spA0ORRx+YR4S/K8y79NDSLVnnls1m5NUHbkqGYEUCA551pp MhXgZJiszZJwbQHmBGmk4dfN1Zg6MU+S+O+K8JyR6swTbDvItIWvx96WKXczBQ5UMcps yF7caXnLmfUoi6cFZI+sjTSWzXTj3xEMFiC82zR2CYOTqljwxkxM+LzasMXxiFZsZya5 uyDk4SNWMg6jCHUTBPiUin9N94RhCTDLm1+kjbdIKD+1sEZDpTSaQQEzSEhoOZ7eqBgf X5zukq36hFYUD+PbZDajTXmnG8KNY9ylmeM7iU+JKDf/UXh2tsHEqkMpnBXaCS9ERyc2 GSfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688781173; x=1691373173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZGMRfD9Z7oO63wCHcVl5vfstO7KOVhVinxukgM54+RI=; b=Rz/eJpIP76nSDYr3b9xx8z3YhBIKC/mdpeYx18EtNfssEr1t+9/2aRg5MpWqcQUUkX u40X6hSSK5+Oz+OpsR6/37q4JJqrIAUIkmmAJ4LSLZBO8Wfk+NYeifoJfzDkmye04Eph FwwQ/pu1xoLCY7gyj5savVgox6GeUjInE0QEfsAZpWkKQomf8oaBfz+FTy06DC7D+kHY zH5K8zXi9G17BFydxxMLXt4jSZClq/WR83iK0jFOK2JGgIPksvFXgjO23/EIwC2aVRy5 HmI+lZA2ESL6KQ1iR3ZSINOAQ74g6Jpj6Foal97rIMmQNL4tCPvDEGoE8r3jpxWyWzO7 EqRA== X-Gm-Message-State: ABy/qLZ9HLubGlTF9ClFJJm30Xfze2mglpd28urvsPEGOVk6JiMJ+hys shhpPLCPQw+FF8CQzdDrI/17Ww== X-Google-Smtp-Source: APBJJlGX6zG1yhO2kFPSmeEFqOgDnWCwQlf26CZWUmoy3hH3DvHT5MCreBUjlBoKCaS+df8VtyGkQg== X-Received: by 2002:a05:6808:d47:b0:3a3:f7b8:576f with SMTP id w7-20020a0568080d4700b003a3f7b8576fmr553031oik.19.1688781173193; Fri, 07 Jul 2023 18:52:53 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id a5-20020aa78645000000b00682af82a9desm3520013pfo.98.2023.07.07.18.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 18:52:52 -0700 (PDT) Date: Fri, 7 Jul 2023 18:52:50 -0700 From: Stephen Hemminger To: Long Li Cc: "longli@linuxonhyperv.com" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Ajay Sharma Subject: Re: [PATCH] net/netvsc: set the correct queue state Message-ID: <20230707185250.32538127@hermes.local> In-Reply-To: References: <1688755996-25172-1-git-send-email-longli@linuxonhyperv.com> <1688755996-25172-2-git-send-email-longli@linuxonhyperv.com> <20230707131601.1b2f9cd1@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 7 Jul 2023 20:43:51 +0000 Long Li wrote: > > Subject: Re: [PATCH] net/netvsc: set the correct queue state > > > > On Fri, 7 Jul 2023 11:53:16 -0700 > > longli@linuxonhyperv.com wrote: > > > > > From: Long Li > > > > > > Set the queue state when queue is started/stopped. > > > > > > Signed-off-by: Long Li > > > --- > > > drivers/net/netvsc/hn_ethdev.c | 15 ++++++++++++++- > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > Interesting that not all drivers do this. > > > > Acked-by: Stephen Hemminger > > > > The ones not doing it. > > af_packet > > af_xdp > > avp > > axgbe > > bnx2x > > bonding > > dpaa > > dpaa2 > > e1000 > > ena > > enetfec > > gve > > hinic > > igc > > ipn3ke > > kni > > liquidio > > mana > > memif > > mlx4 > > netvsc > > nfp > > null > > octeon_ep > > pfe > > ring > > softnic > > vdev_netvsc > > vhost > > virtio > > vmxnet3 > > Testpmd added the check for stopped queues: > 3c4426db54 app/testpmd: do not poll stopped queues > > To pass testpmd, PMD needs to set queue state. So there are 20 drivers broken by that change! Sounds like it needs to be reverted.