From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 823AA42E38;
Mon, 10 Jul 2023 09:39:01 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6B97242B8C;
Mon, 10 Jul 2023 09:38:59 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id 0DF13410EF
for <dev@dpdk.org>; Mon, 10 Jul 2023 09:38:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1688974737; x=1720510737;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=xPY8RGKYv86qAitURVOywKitJbOasU1FZLbKVGwUjec=;
b=V29q2v8aOXEV4cjWDkvpzW8Il9ck2PNHnhsjge+b1iCcz/zGOUxpgbvv
s+/WN86vMNmoKy68/XEMWI/kWPhAAv1gtVsklAfcSRmI05gg1ONL57mpM
Wkh0VJD1ktTOjsgJZbbya9jSQSGxtE9LG0FaPoDVdl37D3FI3YjVrEVNR
+Rl0af5dunFXeTW29IU+ulnronCQyBlkfSYcHClx3XmiBvVf3SDjbGD/l
V2zElrgXcELl2YFUkqhCkHK74ObRU3cHHAl69UGXP+zo5wtu2HJzGBYur
rOdz3HAiUfzUFZsWWUevglOEL4BGpq9IHQQxfdeePscaoNUZS18sxFhYT g==;
X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="364314491"
X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="364314491"
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Jul 2023 00:38:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="790696503"
X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="790696503"
Received: from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.138])
by fmsmga004.fm.intel.com with ESMTP; 10 Jul 2023 00:38:54 -0700
From: Zhirun Yan <zhirun.yan@intel.com>
To: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,
ndabilpuram@marvell.com
Cc: qi.fu@intel.com,
Zhirun Yan <zhirun.yan@intel.com>
Subject: [PATCH v4 1/2] graph: fix graph functional tests with valid params
Date: Mon, 10 Jul 2023 15:15:14 +0800
Message-Id: <20230710071515.3143533-2-zhirun.yan@intel.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20230710071515.3143533-1-zhirun.yan@intel.com>
References: <20230705015633.1465235-1-zhirun.yan@intel.com>
<20230710071515.3143533-1-zhirun.yan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
rte_graph_clone() should use valid param rather than NULL pointer, cause it
needs the param for alloc work queue memory for mcore dispatch model in
graph_sched_wq_create().
Fixes: 67e2303cd823 ("test/graph: add functional tests for mcore dispatch model")
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
app/test/test_graph.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/app/test/test_graph.c b/app/test/test_graph.c
index 8609c0b3a4..47f5ab8395 100644
--- a/app/test/test_graph.c
+++ b/app/test/test_graph.c
@@ -665,7 +665,7 @@ test_graph_clone(void)
{
rte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;
rte_graph_t main_graph_id = RTE_GRAPH_ID_INVALID;
- struct rte_graph_param graph_conf;
+ struct rte_graph_param graph_conf = {0};
int ret = 0;
main_graph_id = rte_graph_from_name("worker0");
@@ -700,6 +700,7 @@ test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
{
rte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;
unsigned int worker_lcore = RTE_MAX_LCORE;
+ struct rte_graph_param graph_conf = {0};
rte_node_t nid = RTE_NODE_ID_INVALID;
char node_name[64] = "test_node00";
struct rte_node *node;
@@ -711,7 +712,7 @@ test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
printf("Set node %s affinity to lcore %u\n", node_name, worker_lcore);
nid = rte_node_from_name(node_name);
- cloned_graph_id = rte_graph_clone(graph_id, "cloned-test1", NULL);
+ cloned_graph_id = rte_graph_clone(graph_id, "cloned-test1", &graph_conf);
node = rte_graph_node_get(cloned_graph_id, nid);
if (node->dispatch.lcore_id != worker_lcore) {
@@ -729,11 +730,12 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)
{
rte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;
unsigned int worker_lcore = RTE_MAX_LCORE;
+ struct rte_graph_param graph_conf = {0};
struct rte_graph *graph;
int ret = 0;
worker_lcore = rte_get_next_lcore(worker_lcore, true, 1);
- cloned_graph_id = rte_graph_clone(graph_id, "cloned-test2", NULL);
+ cloned_graph_id = rte_graph_clone(graph_id, "cloned-test2", &graph_conf);
ret = rte_graph_model_mcore_dispatch_core_bind(cloned_graph_id, worker_lcore);
if (ret != 0) {
@@ -765,10 +767,11 @@ static int
test_graph_worker_model_set_get(void)
{
rte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;
+ struct rte_graph_param graph_conf = {0};
struct rte_graph *graph;
int ret = 0;
- cloned_graph_id = rte_graph_clone(graph_id, "cloned-test3", NULL);
+ cloned_graph_id = rte_graph_clone(graph_id, "cloned-test3", &graph_conf);
ret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);
if (ret != 0) {
printf("Set graph mcore dispatch model failed\n");
--
2.37.2