From: Zhirun Yan <zhirun.yan@intel.com>
To: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,
ndabilpuram@marvell.com
Cc: qi.fu@intel.com, Zhirun Yan <zhirun.yan@intel.com>
Subject: [PATCH v4 2/2] graph: fix graph model check in core binding
Date: Mon, 10 Jul 2023 15:15:15 +0800 [thread overview]
Message-ID: <20230710071515.3143533-3-zhirun.yan@intel.com> (raw)
In-Reply-To: <20230710071515.3143533-1-zhirun.yan@intel.com>
This function is used for mcore dispatch model only, correct the check to
make sure it is the expected model. And specific the model by
rte_graph_worker_model_set() before call it in test. Update release notes
for new mcore dispatch model.
Fixes: ecb22a294980 ("graph: introduce graph bind unbind API")
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
app/test/test_graph.c | 6 ++++++
doc/guides/rel_notes/release_23_07.rst | 10 ++++++++++
lib/graph/graph.c | 2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/app/test/test_graph.c b/app/test/test_graph.c
index 47f5ab8395..af90ac07ec 100644
--- a/app/test/test_graph.c
+++ b/app/test/test_graph.c
@@ -737,6 +737,12 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)
worker_lcore = rte_get_next_lcore(worker_lcore, true, 1);
cloned_graph_id = rte_graph_clone(graph_id, "cloned-test2", &graph_conf);
+ ret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);
+ if (ret != 0) {
+ printf("Set graph mcore dispatch model failed\n");
+ ret = -1;
+ }
+
ret = rte_graph_model_mcore_dispatch_core_bind(cloned_graph_id, worker_lcore);
if (ret != 0) {
printf("bind graph %d to lcore %u failed\n", graph_id, worker_lcore);
diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst
index dcfd692425..7f1c2e66d5 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -185,6 +185,12 @@ New Features
* Added SM2 algorithm support in asymmetric crypto operations.
+* **Added mcore dispatch model in rte_graph library.**
+
+ * Added set, get and validate model APIs to enhance graph framework
+ to chose different walk models.
+ * Added mcore dispatch model to support cross-core dispatching mechanism.
+
* **Added PDCP Library.**
Added an experimental library to provide PDCP UL and DL processing of packets.
@@ -206,6 +212,10 @@ New Features
See the :doc:`../tools/dmaperf` for more details.
+* **Update l3fwd-graph sample application.**
+
+ Added a new cmdline option ``--model`` which can be used to chose
+ RTC or mcore dispatch model.
Removed Items
-------------
diff --git a/lib/graph/graph.c b/lib/graph/graph.c
index 0c28d925bc..26f0968a97 100644
--- a/lib/graph/graph.c
+++ b/lib/graph/graph.c
@@ -287,7 +287,7 @@ rte_graph_model_mcore_dispatch_core_bind(rte_graph_t id, int lcore)
if (graph->id == id)
break;
- if (graph->graph->model == RTE_GRAPH_MODEL_MCORE_DISPATCH)
+ if (graph->graph->model != RTE_GRAPH_MODEL_MCORE_DISPATCH)
goto fail;
graph->lcore_id = lcore;
--
2.37.2
next prev parent reply other threads:[~2023-07-10 7:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 7:29 [PATCH v1] " Zhirun Yan
2023-07-03 9:55 ` [PATCH v2] " Zhirun Yan
2023-07-04 9:10 ` Jerin Jacob
2023-07-05 0:50 ` Yan, Zhirun
2023-07-05 1:56 ` [PATCH v3] " Zhirun Yan
2023-07-07 10:16 ` Jerin Jacob
2023-07-10 5:08 ` Yan, Zhirun
2023-07-10 7:15 ` [PATCH v4 0/2] fix graph issues Zhirun Yan
2023-07-10 7:15 ` [PATCH v4 1/2] graph: fix graph functional tests with valid params Zhirun Yan
2023-07-10 9:21 ` Jerin Jacob
2023-07-10 7:15 ` Zhirun Yan [this message]
2023-07-10 9:29 ` [PATCH v4 2/2] graph: fix graph model check in core binding Jerin Jacob
2023-07-12 14:01 ` [PATCH v4 0/2] fix graph issues Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710071515.3143533-3-zhirun.yan@intel.com \
--to=zhirun.yan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=qi.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).