From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Chengwen Feng <fengchengwen@huawei.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Timothy McDaniel <timothy.mcdaniel@intel.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Rosen Xu <rosen.xu@intel.com>,
Wenjun Wu <wenjun1.wu@intel.com>, Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Tianfei Zhang <tianfei.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Harman Kalra <hkalra@marvell.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Naga Harish K S V <s.v.naga.harish.k@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Ciara Power <ciara.power@intel.com>
Subject: Re: [PATCH v2] set namespace prefix to threads
Date: Mon, 10 Jul 2023 11:42:20 -0700 [thread overview]
Message-ID: <20230710184220.GA6934@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20230703121505.12026-1-thomas@monjalon.net>
On Mon, Jul 03, 2023 at 02:14:06PM +0200, Thomas Monjalon wrote:
> When looking at threads in a system, it can be confusing
> to find some unknown threads without a clue it is started by DPDK.
>
> Let's start all thread names with "dpdk-"
> plus the driver name if it comes from a driver.
>
> One more constraint: the thread names are generally limited
> to 16 characters, including the NUL character.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> Please review carefully, I may have missed things.
i think the only caution here is that some of the new names may be
truncated where the valuable information is lost in the truncation?
#define RTE_MAX_THREAD_NAME_LEN 16
a limit inherited from linux and adopted as the dpdk standard/maximum.
by prefixing dpdk- we end up with a bit less name length budget to spend
potentially causing the most important part of the thread name to be lost.
a couple of notes though.
* some of the existing names may already suffer from truncation. i
didn't check but can see some that look close.
* some of your new names have reduced the length so they are in fact
better.
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
next prev parent reply other threads:[~2023-07-10 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:23 [PATCH] " Thomas Monjalon
2023-07-03 11:38 ` David Marchand
2023-07-03 11:49 ` Thomas Monjalon
2023-07-17 14:09 ` Bruce Richardson
2023-07-17 16:07 ` Thomas Monjalon
2023-07-17 16:14 ` Bruce Richardson
2023-07-03 12:14 ` [PATCH v2] " Thomas Monjalon
2023-07-04 9:18 ` fengchengwen
2023-07-10 18:42 ` Tyler Retzlaff [this message]
2023-08-31 14:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710184220.GA6934@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=ed.czeck@atomicrules.com \
--cc=fengchengwen@huawei.com \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=kevin.laatz@intel.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=navasile@linux.microsoft.com \
--cc=orika@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rosen.xu@intel.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=shepard.siegel@atomicrules.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
--cc=timothy.mcdaniel@intel.com \
--cc=viacheslavo@nvidia.com \
--cc=wenjun1.wu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).