From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DE1F42E3D; Mon, 10 Jul 2023 20:42:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B8A940698; Mon, 10 Jul 2023 20:42:23 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 94D8E40150 for ; Mon, 10 Jul 2023 20:42:21 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id A768721C424C; Mon, 10 Jul 2023 11:42:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A768721C424C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1689014540; bh=rt2nHz9PvJzqwujpMFCBBQ7q47Kqm2gj83yBQUZlj1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d+nnnevaLlWcFJMqyB46Al4tr0LX30hZBwS+CUQz/RccVyWV0d/XqKXHu9SY6VHFC NNW3pYgandmOq5P3ogRGBpgL1zTL8hwtF0TBAzkDB88QTfP3hfnOTQMoItmUe0AO0K 9Gu3q957K+0gkabvXHvccJiUA2TnMIQOei9Up6T0= Date: Mon, 10 Jul 2023 11:42:20 -0700 From: Tyler Retzlaff To: Thomas Monjalon Cc: dev@dpdk.org, Chengwen Feng , Kevin Laatz , Bruce Richardson , Timothy McDaniel , Shepard Siegel , Ed Czeck , John Miller , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Rosen Xu , Wenjun Wu , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , Tianfei Zhang , Xiao Wang , Maxime Coquelin , Chenbo Xia , Anatoly Burakov , Harman Kalra , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Naga Harish K S V , Jerin Jacob , Ciara Power Subject: Re: [PATCH v2] set namespace prefix to threads Message-ID: <20230710184220.GA6934@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230703112359.5067-1-thomas@monjalon.net> <20230703121505.12026-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703121505.12026-1-thomas@monjalon.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 03, 2023 at 02:14:06PM +0200, Thomas Monjalon wrote: > When looking at threads in a system, it can be confusing > to find some unknown threads without a clue it is started by DPDK. > > Let's start all thread names with "dpdk-" > plus the driver name if it comes from a driver. > > One more constraint: the thread names are generally limited > to 16 characters, including the NUL character. > > Signed-off-by: Thomas Monjalon > --- > Please review carefully, I may have missed things. i think the only caution here is that some of the new names may be truncated where the valuable information is lost in the truncation? #define RTE_MAX_THREAD_NAME_LEN 16 a limit inherited from linux and adopted as the dpdk standard/maximum. by prefixing dpdk- we end up with a bit less name length budget to spend potentially causing the most important part of the thread name to be lost. a couple of notes though. * some of the existing names may already suffer from truncation. i didn't check but can see some that look close. * some of your new names have reduced the length so they are in fact better. Acked-by: Tyler Retzlaff