From: Xiao Liang <shaw.leon@gmail.com>
To: dev@dpdk.org
Cc: stable@dpdk.org,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>
Subject: [PATCH v2] ipsec: fix NAT-T header length calculation
Date: Tue, 11 Jul 2023 10:13:17 +0800 [thread overview]
Message-ID: <20230711021335.7239-1-shaw.leon@gmail.com> (raw)
In-Reply-To: <20230418084613.52740-1-shaw.leon@gmail.com>
UDP header and L2 header (if any) length is included in sa->hdr_len.
Take care of that in L3 header and pakcet length caculation.
Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
Cc: stable@dpdk.org
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
---
lib/ipsec/esp_outb.c | 2 +-
lib/ipsec/sa.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ipsec/esp_outb.c b/lib/ipsec/esp_outb.c
index 9cbd9202f6..ec87b1dce2 100644
--- a/lib/ipsec/esp_outb.c
+++ b/lib/ipsec/esp_outb.c
@@ -198,7 +198,7 @@ outb_tun_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,
struct rte_udp_hdr *udph = (struct rte_udp_hdr *)
(ph + sa->hdr_len - sizeof(struct rte_udp_hdr));
udph->dgram_len = rte_cpu_to_be_16(mb->pkt_len - sqh_len -
- sa->hdr_l3_off - sa->hdr_len);
+ sa->hdr_len + sizeof(struct rte_udp_hdr));
}
/* update original and new ip header fields */
diff --git a/lib/ipsec/sa.c b/lib/ipsec/sa.c
index 59a547637d..2297bd6d72 100644
--- a/lib/ipsec/sa.c
+++ b/lib/ipsec/sa.c
@@ -371,7 +371,7 @@ esp_outb_tun_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm)
/* update l2_len and l3_len fields for outbound mbuf */
sa->tx_offload.val = rte_mbuf_tx_offload(sa->hdr_l3_off,
- sa->hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);
+ prm->tun.hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);
esp_outb_init(sa, sa->hdr_len, prm->ipsec_xform.esn.value);
}
--
2.41.0
next prev parent reply other threads:[~2023-07-11 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 8:46 [PATCH] ipsec: fix NAT-T " Xiao Liang
2023-07-05 13:49 ` [EXT] " Akhil Goyal
2023-07-06 9:08 ` Konstantin Ananyev
2023-07-06 10:20 ` Radu Nicolau
2023-07-07 2:06 ` Xiao Liang
2023-07-07 3:12 ` Xiao Liang
2023-07-07 8:59 ` Radu Nicolau
2023-07-07 12:51 ` Xiao Liang
2023-07-07 13:17 ` Xiao Liang
2023-07-07 13:26 ` Radu Nicolau
2023-07-10 9:24 ` Konstantin Ananyev
2023-07-10 9:38 ` Radu Nicolau
2023-07-10 9:20 ` Konstantin Ananyev
2023-07-11 2:13 ` Xiao Liang [this message]
2023-07-11 2:18 ` [PATCH v2] ipsec: fix NAT-T header " Xiao Liang
2023-07-11 8:48 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711021335.7239-1-shaw.leon@gmail.com \
--to=shaw.leon@gmail.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).