From: Raslan Darawsheh <rasland@nvidia.com>
To: <thomas@monjalon.net>
Cc: <dev@dpdk.org>
Subject: [PATCH] devtools: fix bad substitution
Date: Tue, 11 Jul 2023 10:16:19 +0300 [thread overview]
Message-ID: <20230711071619.26797-1-rasland@nvidia.com> (raw)
When running check-git-log, it showed a Bad substitution.
It is fixed by using tr to escape the open parenthesis.
Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")
Cc: thomas@monjalon.net
Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
devtools/check-git-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 89544a2cc5..5c869b7683 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
sed -rn 's,.*: (.*<.*@.*>),\1,p' |
sort -u)
bad=$(for contributor in $names ; do
- contributor=${contributor//(/\\(}
+ contributor=$(echo $contributor | tr '(' '\\(')
! grep -qE "^$contributor($| <)" $selfdir/../.mailmap || continue
name=${contributor%% <*}
if grep -q "^$name <" $selfdir/../.mailmap ; then
--
2.25.1
next reply other threads:[~2023-07-11 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 7:16 Raslan Darawsheh [this message]
2023-07-12 16:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711071619.26797-1-rasland@nvidia.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).