From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 775E542E6D; Fri, 14 Jul 2023 08:01:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53276406B8; Fri, 14 Jul 2023 08:01:47 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id AFC5340685; Fri, 14 Jul 2023 08:01:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689314506; x=1720850506; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AZInOFZBGpxRAFhoija6maAvuFXHSZ2HNUdeyO3dOOY=; b=M1G3StyVtHMBzHaWvEXzi6AcMCW4DBnBdiEzfvQM05lhJlo1noa2piox /L+8Ckdj6rahbcgiZEV6bfOdk2vV5L335I6mYO1qawLpjpUTqR4IOQT71 X+JaqBU8efbb4MdwU3uvNRM30rzpIkzw1j1j6ocCL7sU7T3BoJ6xqcr8B oYzH5VSEKr8G9KXsoxd/zD/JhAef3G+RnpTEjGM015rrSDRMIvEV+6SDH fFA6Ls0WMNfjzpt/+D9LmGd7FubHPySVeNW1aMOunQIkMcZq8MMJviCoS CAbqzAki/YjXFy5d29WNhpTYtlNeWZK8Dkj716v0Y7Rhydm8aqf8UyUAS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="451763114" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="451763114" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 23:01:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="846342314" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="846342314" Received: from unknown (HELO localhost.localdomain) ([10.239.252.104]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 23:01:42 -0700 From: Kaisen You To: dev@dpdk.org Cc: qiming.yang@intel.com, yidingx.zhou@intel.com, Kaisen You , stable@dpdk.org Subject: [PATCH v2] app/test:subprocess synchronization of parameters Date: Fri, 14 Jul 2023 13:59:27 +0800 Message-Id: <20230714055927.3197652-1-kaisenx.you@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230705093515.3285574-1-kaisenx.you@intel.com> References: <20230705093515.3285574-1-kaisenx.you@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In meson_test, because the child process does not synchronize the NIC startup parameters of the parent process at startup, it uses all NICs bound by vfio as startup parameters by default, and an exception occurs in the subsequent hugefile check, causing the test to fail. Synchronize the NIC startup parameters of the parent process to the child process to solve this problem. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Kaisen You --- Changes since v1: - change the patch title to modify the way child processes get NIC parameters, --- app/test/process.h | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/app/test/process.h b/app/test/process.h index 1f073b9c5c..6a8505b80c 100644 --- a/app/test/process.h +++ b/app/test/process.h @@ -15,9 +15,12 @@ #include /* strerror */ #include /* readlink */ #include +#include #include /* strlcpy */ +#define MAX_EXTRA_ARGS 32 +#define PCI_PRI_FMT "%.4" PRIx32 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 #ifdef RTE_EXEC_ENV_FREEBSD #define self "curproc" #define exe "file" @@ -33,7 +36,6 @@ extern void *send_pkts(void *empty); extern uint16_t flag_for_send_pkts; #endif #endif - /* * launches a second copy of the test process using the given argv parameters, * which should include argv[0] as the process name. To identify in the @@ -44,9 +46,13 @@ static inline int process_dup(const char *const argv[], int numargs, const char *env_value) { int num; - char *argv_cpy[numargs + 1]; - int i, status; + char *argv_cpy[MAX_EXTRA_ARGS]; + int i, status, s; char path[32]; + struct rte_pci_device *dev = NULL; + char type[MAX_EXTRA_ARGS]; + char *argv_str[MAX_EXTRA_ARGS]; + char str_1[] = "-a"; #ifdef RTE_LIB_PDUMP #ifdef RTE_NET_RING pthread_t thread; @@ -113,10 +119,23 @@ process_dup(const char *const argv[], int numargs, const char *env_value) closedir(dir); } #endif + s = -1; + argv_str[0] = strdup(str_1); + FOREACH_DEVICE_ON_PCIBUS(dev) { + s = s + 2; + sprintf(type, PCI_PRI_FMT, dev->addr.domain, + dev->addr.bus, dev->addr.devid, dev->addr.function); + argv_str[s - 1] = strdup(str_1); + argv_str[s] = strdup(type); + } + for (i = 0; i < s + 1; i++) + argv_cpy[num + i] = strdup(argv_str[i]); + printf("Running binary with argv[]:"); - for (i = 0; i < num; i++) + for (i = 0; i < num + s + 1; i++) printf("'%s' ", argv_cpy[i]); printf("\n"); + argv_cpy[numargs + s + 1] = NULL; fflush(stdout); /* set the environment variable */ -- 2.25.1