From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93A7542E8E; Sun, 16 Jul 2023 19:21:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C2CF4114A; Sun, 16 Jul 2023 19:21:38 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id CF47D4113F for ; Sun, 16 Jul 2023 19:21:36 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-668711086f4so2186468b3a.1 for ; Sun, 16 Jul 2023 10:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689528096; x=1692120096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Im428iPo7JAQ8/dhzIUIRWCT87OkoTgJkCYWU8AtDvc=; b=cllxkxiO7G0oIHn9wKqOvSQhVp4brO8ofuA71yf/70lcmUIPsVT+hMr83Zh0JXas8k snJGxttH5m6kA55yzSOcIIU42VMMu9c95IZjY2mfTHgpCEJ4cV9iYdQt8CGzuT5ynfzA 9U5d2ZMuogN+k2Pp5MsUXht/0gE4Q9SGHjL43I9+3X/025gyI42e/qmY35MWvQAbzptv dySKCIrFJGDIfO+EykHXy743e+FjswbevMyRA9wmF5z5lCw2FNddL4UDsNcM11ijXE7z E1f0NXzDvLHanuWXgX6dzAuU5rcqJ3DdGacknP3DPlo/WEwbu6SCRgY7sqUC4oiut12l 25lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689528096; x=1692120096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Im428iPo7JAQ8/dhzIUIRWCT87OkoTgJkCYWU8AtDvc=; b=CMYRbAmSlM9zsM7F1xE++TkyHsHu6qqUC5WNtafrGkeiR/bJMcuxK+QCAOaF1Pr1uL 0PD7Qg7obp0jbyoeOHt08RmH1+7LuRF7AtLdGWEDwLejbiZ3tCCtLNe+8Y3QfQvS6fxv 45ZQXPCnVfBzWxNuLCZcovh2dqhsNhrJl1XbneFoD1Tt/zUOiiF2PU2ezoevhlcOLqox MTNQZPAKRREtv/ftuEd65zIwBymB12+ymco6q+7D9IaO9RsDHhYxVoqoverJ2ZwnRaLM VL3eGxYC70+8uz2lA4P7gmWhqidXotySCUIXX+jJHOWqBl8nvxcELqKm3TY9HWjz0tW8 I/HQ== X-Gm-Message-State: ABy/qLb0T7+a2w33R+cy8XQh/kTVrzqzW8TkufwNgXFXnIRMNFQC/ifC VVirbdoqTkkaqoSXG1BBD6sXZQ== X-Google-Smtp-Source: APBJJlFLiEk7L9BXDwrBtP4Oww5Ofxuy1aEnaANFkPE4ZBOxeTcucWYcc6Yw+dnWkoXAQobzPCUzPw== X-Received: by 2002:a05:6a00:1a8b:b0:666:c1ab:d6e5 with SMTP id e11-20020a056a001a8b00b00666c1abd6e5mr9890950pfv.16.1689528095993; Sun, 16 Jul 2023 10:21:35 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id a16-20020aa78650000000b0066e7a540ea5sm10429601pfo.205.2023.07.16.10.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jul 2023 10:21:35 -0700 (PDT) Date: Sun, 16 Jul 2023 10:21:34 -0700 From: Stephen Hemminger To: Gabriel Ganne Cc: Bruce Richardson , dev@dpdk.org, thomas@monjalon.net, thierry.herbelot@6wind.com, olivier.matz@6wind.com Subject: Re: [dpdk-dev] [PATCH v4] meson: remove unnecessary explicit link to libpcap Message-ID: <20230716102134.54c61cd5@hermes.local> In-Reply-To: <20210409083927.8345-1-gabriel.ganne@6wind.com> References: <20210322140757.7888-2-gabriel.ganne@6wind.com> <20210409083927.8345-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 9 Apr 2021 10:39:27 +0200 Gabriel Ganne wrote: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > The pcap PMD and the librte_port both declare their dependency to > libpcap with a line "ext_deps += pcap_dep". > "pcap_dep" is declared using the dependency() directive in > config/meson.build meson automatically adds this dependency to the > pkg-config file in the private section for static builds. > > Signed-off-by: Gabriel Ganne > --- > config/meson.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 66a2edcc47f5..95777cf33169 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -183,7 +183,6 @@ if not pcap_dep.found() > endif > if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) > dpdk_conf.set('RTE_PORT_PCAP', 1) > - dpdk_extra_ldflags += '-lpcap' > endif > Patch needs to be rebased and retested, now that Windows has pcap support. Need to make sure that Windows is not depending on this.